fix(vault): drop the 12-character master password minimum - #24
Merged
Conversation
Setting up or recovering a vault refused any master password shorter than 12 characters, which blocked passwords that were perfectly usable. The length check is gone from both paths; only an empty password is refused now, since an empty master password derives a useless key. The strength meter keeps rating length — anything under 8 characters still reads as Weak — but it no longer tells you to use at least 12, and nothing it says blocks the form. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrHcQXSjCeCcAKhWPZg8w9
ThreatCrush Security Scan12 finding(s) MEDIUM: 8 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault setup and recovery refused any master password shorter than 12 characters. The gate is gone from both paths — only an empty password is refused now, since an empty master password derives a useless key.
The strength meter still rates length (under 8 characters reads as Weak), but it no longer says "Use at least 12 characters" and nothing it reports blocks the form.
Unlock was never gated, so existing vaults are unaffected. No change to the KDF or to how keys are derived.
Checks: 787/787 extension tests pass, lint clean, full turbo build passes (pre-commit hook ran both).
🤖 Generated with Claude Code
https://claude.ai/code/session_01MrHcQXSjCeCcAKhWPZg8w9