feat: a codecs subpath, and let the host name the thing - #2
Merged
Conversation
genrewatch and tipoffwatch each carry a copy of the codec table. It is the most expensive 150 lines in either repo -- every rule was written in response to a channel that failed in production, and two of them were got wrong twice -- and three copies is the thing this package exists to stop. `@profullstack/player/codecs` is a subpath rather than the root export because those two bundle their client by hand and are careful about its weight: importing from the root would pull the player and its dynamic engine imports into a bundle that wants a lookup table and nothing else. dist/codecs.js is 151 bytes. `unplayableReason` also takes a `subject` now. Those sites say "channel", because that is what their reader clicked; a recording is a "stream" at best. Naming it wrongly is a small thing that makes shared copy read as though it came from somewhere else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WFLwZtXE6iBJyJSgrsWqRM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
genrewatch and tipoffwatch each carry a copy of the codec table — the most expensive 150 lines in either repo, every rule written in response to a channel that failed in production, two of them got wrong twice. Three copies is the thing this package exists to stop.
@profullstack/player/codecsis a subpath rather than the root export because those two bundle their client by hand and are careful about its weight: importing from the root would pull the player and its dynamic engine imports into a bundle that wants a lookup table and nothing else.dist/codecs.jsis 151 bytes.unplayableReasonalso takes asubject. Those sites say "channel", because that is what their reader clicked; a recording is a "stream" at best. Without it, adopting this would quietly reword their copy.80 tests, tsc and prettier clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WFLwZtXE6iBJyJSgrsWqRM