fix(codecs): restore the runtime kind guard the port dropped - #3
Merged
Conversation
The original JavaScript guarded both arguments -- `if (!codec || !kind)`. Porting it to TypeScript, `kind` became a union type and the runtime check looked redundant, so it went. It is not redundant: this module is imported by two plain-JavaScript client bundles, where a missing kind is an ordinary runtime value rather than a compile error. Without it, `mseCandidates(null, 'mp3')` stopped meaning "nothing to ask" and started asking MSE about `null/mp4`. Caught by genrewatch's own suite the moment it adopted the shared table, which is the argument for adopting it there rather than leaving three copies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WFLwZtXE6iBJyJSgrsWqRM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original JavaScript guarded both arguments —
if (!codec || !kind). Porting to TypeScript,kindbecame a union type and the runtime check looked redundant, so it went. It is not redundant: this module is imported by two plain-JavaScript client bundles, where a missing kind is an ordinary runtime value rather than a compile error.Without it,
mseCandidates(null, 'mp3')stopped meaning "nothing to ask" and started asking MSE aboutnull/mp4.Caught by genrewatch's own suite the moment it adopted the shared table — which is rather the argument for adopting it there instead of leaving three copies drifting.
80 tests, tsc and prettier clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WFLwZtXE6iBJyJSgrsWqRM