Fix wrong step-id reference blanking frontend image tag in build-docker-images.yml - #1103
Conversation
…er-images.yml The 'Ensure frontend sha is used in docker-compose' step read steps.frontend.outputs.tag, but the step that stores the frontend short SHA has id 'frontend_tag', not 'frontend'. Since steps.frontend does not exist, SHORT_HASH resolved to an empty string, causing the sed to blank out the frontend image tag in docker-compose.yml on every push that reached this step (observed on PR #1101). Fixes #1102
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Docker image build workflow now reads the frontend image tag from Suggested reviewers: Merge Risk: ⚪ Minimal · up to The workflow now uses the frontend tag output from the correct step, preventing Docker Compose frontend image references from being updated with a blank tag. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The change replaces the nonexistent steps.frontend reference with steps.frontend_tag, which satisfies the direct issue objectives to prevent blank frontend image tags and preserve valid Docker Compose references [ Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
Summary
Fixes #1102.
.github/workflows/build-docker-images.ymlruns on every push and auto-commits the backend/frontend image SHA tags intodocker-compose.yml. The frontend step referenced the wrong step id, soSHORT_HASHwas always empty and the sed blanked out the frontend image tag instead of setting it, e.g.:This was observed live on an unrelated docs PR (#1101), where the workflow fired on push and committed this blank-tag change directly onto that branch.
Changes
Ensure frontend sha is used in docker-composestep now readssteps.frontend_tag.outputs.tag(matching the id of theStore frontend tagstep) instead of the nonexistentsteps.frontend.outputs.tag.Testing
build-docker-images.yml; verify in the Actions run for this branch that the frontend tag step now populatesdocker-compose.ymlwith a real short SHA instead of blanking it.