Skip to content

Fix wrong step-id reference blanking frontend image tag in build-docker-images.yml - #1103

Merged
rquidute merged 1 commit into
mainfrom
fix/1102-docker-compose-frontend-tag
Sep 4, 2026
Merged

Fix wrong step-id reference blanking frontend image tag in build-docker-images.yml#1103
rquidute merged 1 commit into
mainfrom
fix/1102-docker-compose-frontend-tag

Conversation

@rquidute

@rquidute rquidute commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #1102.

.github/workflows/build-docker-images.yml runs on every push and auto-commits the backend/frontend image SHA tags into docker-compose.yml. The frontend step referenced the wrong step id, so SHORT_HASH was always empty and the sed blanked out the frontend image tag instead of setting it, e.g.:

-    image: 'ghcr.io/project-chip/csa-certification-tool-frontend:5be5818'
+    image: 'ghcr.io/project-chip/csa-certification-tool-frontend:'

This was observed live on an unrelated docs PR (#1101), where the workflow fired on push and committed this blank-tag change directly onto that branch.

Changes

  • Ensure frontend sha is used in docker-compose step now reads steps.frontend_tag.outputs.tag (matching the id of the Store frontend tag step) instead of the nonexistent steps.frontend.outputs.tag.

Testing

  • N/A (workflow-only fix). Pushing this branch will itself trigger build-docker-images.yml; verify in the Actions run for this branch that the frontend tag step now populates docker-compose.yml with a real short SHA instead of blanking it.

…er-images.yml

The 'Ensure frontend sha is used in docker-compose' step read
steps.frontend.outputs.tag, but the step that stores the frontend
short SHA has id 'frontend_tag', not 'frontend'. Since steps.frontend
does not exist, SHORT_HASH resolved to an empty string, causing the
sed to blank out the frontend image tag in docker-compose.yml on every
push that reached this step (observed on PR #1101).

Fixes #1102
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: e402b259-e4fe-4b45-8104-4a8128b4ece7

📥 Commits

Reviewing files that changed from the base of the PR and between 4aa5148 and abb04e0.

📒 Files selected for processing (1)
  • .github/workflows/build-docker-images.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Docker image build workflow now reads the frontend image tag from steps.frontend_tag.outputs.tag when updating docker-compose.yml. This replaces the nonexistent steps.frontend.outputs.tag reference.

Suggested reviewers: greens

Merge Risk: ⚪ Minimal · up to abb04

The workflow now uses the frontend tag output from the correct step, preventing Docker Compose frontend image references from being updated with a blank tag. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the incorrect step-ID reference and the resulting blank frontend image tag in the affected workflow.
Description check ✅ Passed The description accurately explains the root cause, impact, fix, and validation approach for the workflow change.
Linked Issues check ✅ Passed The change replaces the nonexistent steps.frontend reference with steps.frontend_tag, which satisfies the direct issue objectives to prevent blank frontend image tags and preserve valid Docker Compose…
Out of Scope Changes check ✅ Passed The pull request changes only the workflow reference required to fix the linked issue. No unrelated code changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The change replaces the nonexistent steps.frontend reference with steps.frontend_tag, which satisfies the direct issue objectives to prevent blank frontend image tags and preserve valid Docker Compose references [#1102]. Branch-scoped triggering was listed as a consideration, not a required fix.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@rquidute
rquidute merged commit cf0e08d into main Sep 4, 2026
6 checks passed
@rquidute
rquidute deleted the fix/1102-docker-compose-frontend-tag branch September 4, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] build-docker-images.yml wrong step-id blanks frontend image tag in docker-compose.yml

5 participants