Conversation
* Replace `Arrays.asList()` with single element with `List.of()` * enhanced switch expression * pattern variable * Use String.repeat() * Use `.isEmpty()` * Remove unused `ParseError` * Remove unused function in TypeErrors * Remove duplicate `if`
XN137
approved these changes
Sep 17, 2026
| for (int i = 0; i < location.column(); i++) { | ||
| result.append(dot); | ||
| } | ||
| result.append(String.valueOf(dot).repeat(Math.max(0, location.column()))); |
Contributor
There was a problem hiding this comment.
are these kind of changes really an improvement in terms of readability/performance?
|
|
||
| import org.projectnessie.cel.common.Location; | ||
|
|
||
| public final class ParseError extends RuntimeException { |
Contributor
There was a problem hiding this comment.
does this break backward-compatibility of our public api?
if yes maybe need to document this in the release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrays.asList()with single element withList.of().isEmpty()ParseErrorif