fix: Surface removeResourceSummary failures in ClusterSummary status - #1947
Merged
Conversation
removeResourceSummary failing (in both prepareForDeployment and cleanupBeforeFinalizerRemoval) was only logged, never written to ClusterSummary.status. An ongoing failure was invisible to `kubectl get clustersummary`; status just sat wherever it last was (often Provisioning), silently retrying every reconcile with no visible sign anything was wrong. Both call sites now call setFailureMessage/resetFeatureStatus on that error, the same helpers updateChartMap's NotFound handling already used three lines above one of them. FeatureStatusFailed (retriable) rather than FeatureStatusFailedNonRetriable, since this class of failure is generally transient and already retried via requeue.
Member
Author
|
Fixes #1945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeResourceSummary failing (in both prepareForDeployment and cleanupBeforeFinalizerRemoval) was only logged, never written to ClusterSummary.status. An ongoing failure was invisible to
kubectl get clustersummary; status just sat wherever it last was (often Provisioning), silently retrying every reconcile with no visible sign anything was wrong.Both call sites now call setFailureMessage/resetFeatureStatus on that error, the same helpers updateChartMap's NotFound handling already used three lines above one of them. FeatureStatusFailed (retriable) rather than FeatureStatusFailedNonRetriable, since this class of failure is generally transient and already retried via requeue.