docs: note that weekday ranges cannot wrap around the week - #5552
docs: note that weekday ranges cannot wrap around the week#5552xenon898 wants to merge 1 commit into
Conversation
A weekday_range like 'saturday:sunday' is rejected by the parser
("start day cannot be before end day") because the start day must come
before the end day. Document this so users know to list the days
individually instead. Docs-only.
Closes prometheus#3213
Signed-off-by: xenon898 <88700568+xenon898@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe ChangesWeekday range documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The documentation clarifies that weekday ranges cannot wrap and shows the correct weekend syntax. No user-facing runtime risk remains, so this change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Duplicate of #5172, which is already approved and awaiting merge. Apologies for the noise — closing in its favour. |
What
A
weekday_rangesuch assaturday:sundayis rejected by the parser withstart day cannot be before end day(timeinterval.go), because the start day index must be less than or equal to the end day index (Sunday = 0 … Saturday = 6). The docs don't mention this, so users try to express a weekend assaturday:sundayand hit a config error (see #3213).This adds a sentence to the
weekday_rangedescription indocs/configuration.mdexplaining that ranges cannot wrap around the end of the week, and that individual days should be listed instead.Docs-only.
Closes #3213
🤖 Generated with Claude Code