feat: expose sysfs_device label for network, nvme, and infiniband#3746
Open
sulaimantok wants to merge 1 commit into
Open
feat: expose sysfs_device label for network, nvme, and infiniband#3746sulaimantok wants to merge 1 commit into
sulaimantok wants to merge 1 commit into
Conversation
sulaimantok
force-pushed
the
master
branch
2 times, most recently
from
74cd423 to
47ae1b4
Compare
Closes prometheus#3721 Signed-off-by: Sulaiman Al farisi <23329919+sulaimantok@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the feature requested in #3721 by introducing a new
sysfs_devicelabel to the following info metrics:node_network_infonode_nvme_infonode_infiniband_infoWhat changed:
sysfsDevicehelper to dynamically resolve the symlink target of/sys/class/<class>/<device>/device.0000:00:1f.3) into the metrics as a new labelsysfs_device.e2e-output.txtande2e-64k-page-output.txtfixtures to reflect the new label format.Why this is needed:
As detailed in #3721, when a physical hardware issue occurs (e.g., NIC or cable failure), operators need a reliable way to map the affected logical interface directly to its physical PCI/Hardware location on the chassis. Exposing the
sysfs_devicelabel makes it seamless to identify the physical BDF location for maintenance or part replacements.Closes #3721