Skip to content

test(daemon): expect slug-based allocation names in the resource matrix - #416

Merged
clvsh merged 1 commit into
mainfrom
fix/real-artifact-matrix-slug
Oct 11, 2026
Merged

clvsh merged 1 commit into
mainfrom
fix/real-artifact-matrix-slug

Conversation

@clvsh

@clvsh clvsh commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

The real-artifact resource matrix has been failing at its .env check since c29be2f (2026-07-29, resource-only projects). That commit made Project slugs come from the Project's directory name instead of its hostname.

The test still expected Redis prefix and bucket names built from the hostname (real-artifact-resources-test-cache-, real-artifact-resources-test-uploads). PV now generates project-cache- and project-uploads, because the test's Project directory is project. The test stopped at that check, before the remaining evidence.

It only runs in the manual Real Artifact E2E workflow, so normal CI never caught it. It showed up while checking the monitor cutover (#414) against real artifacts.

Test plan

Summary by CodeRabbit

  • Tests
    • Updated resource-matrix checks to expect allocation names prefixed with the project slug.

Project slugs come from the Project directory since c29be2f, not its hostname. The real-artifact resource matrix still expected hostname-based Redis prefix and bucket names, so it failed at its .env check before reaching the remaining evidence. It only runs in the manual Real Artifact E2E workflow, so normal CI never caught it.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T19:00:50.441879Z 0be8d81 PR opened
🔒 Security Review ✅ Completed 2026-10-10T19:01:10.056707Z 0be8d81 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 943bf245-57cd-4258-b9b3-8f697c3e330f

📥 Commits

Reviewing files that changed from the base of the PR and between 3c26bcc and 0be8d81.


📒 Files selected for processing (1)
  • crates/daemon/tests/real_artifact_resource_matrix.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.



📝 Walkthrough

Walkthrough

The resource-matrix test now expects the Redis prefix and AWS bucket names to use the project slug. The Mailpit dashboard expectation remains unchanged.

Changes

Resource matrix test

Layer / File(s) Summary
Update resource slug expectations
crates/daemon/tests/real_artifact_resource_matrix.rs
The Redis prefix and AWS bucket expectations use the project slug. A comment identifies the project directory name as the slug source.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 0be8d

The resource-matrix expectations now match the allocation naming behavior, and no actionable merge risk remains.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the test change: expect slug-based allocation names in the resource matrix.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR



🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing fix/real-artifact-matrix-slug (0be8d81) with main (3c26bcc)

Open in CodSpeed

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Checked the resource-matrix assertions against the fixture, Project slug assignment, allocation generation, and env rendering.

  • Slug-based expectations: Redis now expects project-cache- and RustFS expects project-uploads, matching the isolated fixture's directory-derived slug project rather than its hostname.
  • Naming explanation: The added comment accurately describes the slug source; production behavior is unchanged.
  • Verification: Real Artifact E2E run 38077439221 ran at this exact head and passed the resource matrix and both runtime-contract steps. The separate Gateway E2E step failed as noted in the PR. No local rerun was attempted because this Linux runner cannot execute the macOS integration.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@clvsh
clvsh merged commit e96203a into main Oct 11, 2026
11 of 12 checks passed
@clvsh
clvsh deleted the fix/real-artifact-matrix-slug branch October 11, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant