Repository navigation
test(daemon): expect slug-based allocation names in the resource matrix - #416
Merged
Merged
Conversation
Project slugs come from the Project directory since c29be2f, not its hostname. The real-artifact resource matrix still expected hostname-based Redis prefix and bucket names, so it failed at its .env check before reaching the remaining evidence. It only runs in the manual Real Artifact E2E workflow, so normal CI never caught it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 tasks done
Contributor
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Checked the resource-matrix assertions against the fixture, Project slug assignment, allocation generation, and env rendering.
- Slug-based expectations: Redis now expects
project-cache-and RustFS expectsproject-uploads, matching the isolated fixture's directory-derived slugprojectrather than its hostname. - Naming explanation: The added comment accurately describes the slug source; production behavior is unchanged.
- Verification: Real Artifact E2E run 38077439221 ran at this exact head and passed the resource matrix and both runtime-contract steps. The separate Gateway E2E step failed as noted in the PR. No local rerun was attempted because this Linux runner cannot execute the macOS integration.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The real-artifact resource matrix has been failing at its
.envcheck since c29be2f (2026-07-29, resource-only projects). That commit made Project slugs come from the Project's directory name instead of its hostname.The test still expected Redis prefix and bucket names built from the hostname (
real-artifact-resources-test-cache-,real-artifact-resources-test-uploads). PV now generatesproject-cache-andproject-uploads, because the test's Project directory isproject. The test stopped at that check, before the remaining evidence.It only runs in the manual Real Artifact E2E workflow, so normal CI never caught it. It showed up while checking the monitor cutover (#414) against real artifacts.
Test plan
*.api.laravel.test).Summary by CodeRabbit