Skip to content

Split up on_close and on_open kwargs and fix Windows#111

Open
puddly wants to merge 7 commits into
devfrom
puddly/windows-drt-pin
Open

Split up on_close and on_open kwargs and fix Windows#111
puddly wants to merge 7 commits into
devfrom
puddly/windows-drt-pin

Conversation

@puddly

@puddly puddly commented Jul 17, 2026

Copy link
Copy Markdown
Owner

This PR splits rtsdtr_on_open and rtsdtr_on_close into separate kwargs for dtr_on_open, rts_on_open, etc.

I've also fixed Windows pin low behavior with RTS_CONTROL_DISABLE.

Fixes #107.

@puddly
puddly force-pushed the puddly/windows-drt-pin branch from 79ca339 to 15d5942 Compare July 17, 2026 01:17
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev@7261b30). Learn more about missing BASE report.

Files with missing lines Patch % Lines
serialx/platforms/serial_win32.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #111   +/-   ##
======================================
  Coverage       ?   92.47%           
======================================
  Files          ?       22           
  Lines          ?     3747           
  Branches       ?        0           
======================================
  Hits           ?     3465           
  Misses         ?      282           
  Partials       ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to set dtr=False in method serialx.create_serial_connection()?

1 participant