Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
<RoslynVersion>5.9.0</RoslynVersion>
<TUnitVersion>1.67.0</TUnitVersion>
<PurviewSGFVersion>1.0.0-prerelease.53</PurviewSGFVersion>
<PurviewSGFVersion>1.0.0-prerelease.54</PurviewSGFVersion>
<DotnetRuntimeVersion>10.0.12</DotnetRuntimeVersion>
<MSExtensionVersion>10.10.0</MSExtensionVersion>
<OpenTelemetryVersion>1.18.0</OpenTelemetryVersion>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "purview-telemetry-sourcegenerator",
"version": "5.0.0-prerelease.18",
"version": "5.0.0-prerelease.19",
"description": "Generates [`ActivitySource`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activitysource), [`ILogger`](https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.ilogger), and [`Metrics`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics) based on interface methods.",
"license": "MIT",
"readme": "README.md",
Expand Down
7 changes: 6 additions & 1 deletion src/src/SourceGenerator/Records/GenericRecords.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ public readonly void Validate()
throw new Exception("Destructure and Stringify cannot both be true.");
}

public static EquatableArray<MessageTemplateHole> FromMatches(MatchCollection matches)
/// <summary>
/// Projects the regex matches into the hole records. Internal because the returned
/// <c>EquatableArray</c> is a framework type the merge internalizes in the shipped analyzer (seen by
/// <c>PSGFR41</c>); the BuildSdk grants the test assemblies access to internals.
/// </summary>
internal static EquatableArray<MessageTemplateHole> FromMatches(MatchCollection matches)
{
List<MessageTemplateHole>? holes = null;
if (matches != null)
Expand Down
7 changes: 6 additions & 1 deletion src/src/SourceGenerator/Records/TelemetryCapabilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ namespace Purview.Telemetry.SourceGenerator.Records;
/// <summary>
/// Capabilities detected for the current compilation.
/// </summary>
public sealed record TelemetryCapabilities(
/// <remarks>
/// Internal because it implements a <c>Purview.SourceGeneratorFramework</c> interface, which the merge
/// internalizes in the shipped analyzer (seen by <c>PSGFR41</c>); the BuildSdk grants the test
/// assemblies access to internals.
/// </remarks>
sealed record TelemetryCapabilities(
//bool SupportsNullableAnnotations,
bool SupportsIMeterFactory
) : IGenerationCapabilities;
Loading