Replace Damage Envelope graph with Application Profile graph#2779
Open
GET-R3AL wants to merge 2 commits into
Open
Replace Damage Envelope graph with Application Profile graph#2779GET-R3AL wants to merge 2 commits into
GET-R3AL wants to merge 2 commits into
Conversation
The new graph plots optimal-ammo DPS/volley versus distance, selecting the best charge at each range and drawing each ammo as its own segment. - graphs/data/fitApplicationProfile: new getter/graph and calc helpers (turret/launcher hit math, ammo optimization, projected effects, charge filtering); removes the old fitDamageEnvelope module - Canvas: segmented plotting with per-segment legend and ammo styling - Control panel: Ammo Style (None/Pattern/Color) and Ammo Meta (T1/Navy/All) dropdowns; dynamic distance range derived from fit weapon ranges - Lists: auto-switch ammo style on weapon-class conflicts; refreshDefaultColumns - Context menus: Apply Projected Effects / Ignore Target Resists for the new graph - service/settings: add ammoOptimalApplyProjected and ammoOptimalIgnoreResists keys
Contributor
|
I cannot distinguish between added fits, because there are only ammo names on graph. How to understand which graph belongs to which fit? |
Author
Fits can be differentiated by the ammo they use. When using fits that use the same ammo, the graph should auto swap to pattern based ammo distinction where the lines are color coded similarly to the traditional graphs. |
…uckets to fix bug related to Exotic plasma not having navy variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps out the old Damage Envelope graph for a new Application Profile graph. Instead of graphing a single segment it draws each ammo as its own segment, so you can see where one ammo overtakes another and read the ammo type at each distance.
New options in the control panel (only show up for this graph):
There's also per-segment legend/coloring on the canvas, and the source list auto-switches to Pattern style when multiple fits use the same weapon class so you can still tell them apart. Added Apply Projected Effects / Ignore Target Resists context menu options for this graph too, with their own settings keys.
The new code lives in
graphs/data/fitApplicationProfile/(getter/graph + calc helpers for the turret/launcher math, ammo selection, etc.), and the oldfitDamageEnvelopemodule is removed.Added White Text Outlines & Offsetting to the X Axis Indicator for improved legibility