Skip to content

[Documentation] Explain handling of SLURM errors#1019

Merged
jan-janssen merged 1 commit into
mainfrom
slurm_error
Jun 14, 2026
Merged

[Documentation] Explain handling of SLURM errors#1019
jan-janssen merged 1 commit into
mainfrom
slurm_error

Conversation

@jan-janssen

@jan-janssen jan-janssen commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated Python kernel version to 3.13.14 in the HPC cluster notebook.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 44840136-1b4b-4cb6-a383-bc97653a58a0

📥 Commits

Reviewing files that changed from the base of the PR and between 1ec85bf and d9e6dba.

📒 Files selected for processing (1)
  • notebooks/2-hpc-cluster.ipynb

📝 Walkthrough

Walkthrough

The HPC cluster notebook's kernel language_info Python patch version is bumped from 3.13.13 to 3.13.14, and the metadata.trusted flag on code cells is flipped from true to false. No cell content or outputs are changed.

Changes

Notebook metadata update

Layer / File(s) Summary
Kernel version and cell trusted flags
notebooks/2-hpc-cluster.ipynb
Python patch version in language_info updated from 3.13.13 to 3.13.14; metadata.trusted set to false on code cells.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • pyiron/executorlib#614: Modifies the same notebooks/2-hpc-cluster.ipynb notebook metadata, including kernel/Python version details and related notebook metadata structure.
  • pyiron/executorlib#1008: Also modifies notebooks/2-hpc-cluster.ipynb by changing metadata.trusted flags on notebook cells.

Poem

🐰 A tiny hop, a patch version bumped with care,
The trusted flag flipped to false — a lighter affair,
No outputs changed, no cells gone astray,
Just metadata tidied in a Pythonic way,
Three dots updated, and now we're all set — hooray! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to explain SLURM error handling, but the actual changes only update Python kernel metadata and trust flags in a notebook—no documentation about SLURM errors is present. Either update the title to reflect the actual changes (e.g., 'Update Python kernel version and notebook metadata'), or add the promised SLURM error documentation to the PR.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slurm_error

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Ruff (0.15.15)
notebooks/2-hpc-cluster.ipynb

Unexpected end of JSON input


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (1ec85bf) to head (d9e6dba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          39       39           
  Lines        2119     2119           
=======================================
  Hits         1997     1997           
  Misses        122      122           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 8d9d2a2 into main Jun 14, 2026
63 of 65 checks passed
@jan-janssen jan-janssen deleted the slurm_error branch June 14, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] sbatch errors hang executor - explain CalledProcessError output for debugging

1 participant