tests: skip test_celery gracefully when celery/testcontainers aren't installed - #752
Open
dchaudhari7177 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #750.
test_celerygenerates a test module that doesfrom celery import Celery/from celery.contrib.testing import worker/from testcontainers.redis import RedisContainer. When those packages aren't installed the innerpytester.runpytest(...)errors out withImportError, so the test fails hard instead of being skipped. The existingsys.platformskips only cover Windows/macOS, so on other platforms (e.g. FreeBSD, per the report) it blows up.This adds a
skipifguarding onceleryandtestcontainersbeing importable (viaimportlib.util.find_spec), matching how the suite already gates optional/platform-specific tests. When both are installed the test runs exactly as before.Verified locally: with neither package installed,
test_celerynow reportsSKIPPED [celery and testcontainers are required]instead of erroring;ruff check/formatclean.Happy to add a
CHANGELOG.rstentry in whatever section you'd prefer for an unreleased test-only fix.