Skip to content

reverted exception type in FileSet.sample to NotImplementedError #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tclose merged 1 commit into from
Aug 18, 2026
Merged

reverted exception type in FileSet.sample to NotImplementedError #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fileformats/core/fileset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ def sample(
mime_like = cls.mime_like
except FormatDefinitionError:
mime_like = cls.__module__ + "." + cls.__name__
raise FormatMismatchError(
raise NotImplementedError(
f"File paths generated by override of FileSet.generate_sample_data() "
f"({fspaths}) do not match '{mime_like}' file type. A more specific "
f"implementation is required. Reason:\n\n{e}"
Expand Down
Loading