Ensure map stride is at least one full row of pixels#9719
Open
radarhere wants to merge 1 commit into
Open
Conversation
PyImaging_MapBuffer only recomputed the row stride when it was <= 0; a positive stride smaller than a full row of pixels was used as-is. Memory mapping then laid out the row pointers that close together while consumers read a full row (xsize * pixelsize) from each, reading past the mapped buffer -- an out-of-bounds read leading to process-memory disclosure or a SIGBUS crash. This is reachable from Image.open() on a crafted McIdas AREA file (the header supplies the stride) opened from a path, which engages the mmap fast-path. Ensure the stride is at least one full row of pixels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.