Skip to content

[stubsabot] Mark Flask-Cors as obsolete since 6.0.4#15880

Merged
srittau merged 3 commits into
mainfrom
stubsabot/flask-cors
Jun 8, 2026
Merged

[stubsabot] Mark Flask-Cors as obsolete since 6.0.4#15880
srittau merged 3 commits into
mainfrom
stubsabot/flask-cors

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the bot: stubsabot 🤖 Third-party stub updates by stubsabot 🤖 label Jun 8, 2026
@brianschubert brianschubert linked an issue Jun 8, 2026 that may be closed by this pull request
Comment thread stubs/Flask-Cors/METADATA.toml Outdated
Comment on lines -1 to -3
# Requires a version of flask with a `py.typed` file
version = "~=6.0.3"
upstream-repository = "https://github.com/corydolphin/flask-cors"
# Requires a version of flask with a `py.typed` file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this loop from #15614 is causing all the keys to be shifted to the end, which puts them after the comment. Is that kind of transformation logic needed now that the underscore-to-dash transition is complete?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pushed a manual fix for this PR)

Comment thread stubs/Flask-Cors/METADATA.toml Outdated
@@ -2,3 +2,4 @@ version = "~=6.0.3"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "==6.0.3"

Pin to the last version that doesn't have type annotations, to fix stubtest?

@srittau

srittau commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

I'd really appreciate if someone could review typeshed-internal/stub_uploader#202 and #15682, because it's a burden to keep them up-to-date whenever something is marked as obsolete.

@srittau srittau merged commit a4282ec into main Jun 8, 2026
37 checks passed
@srittau srittau deleted the stubsabot/flask-cors branch June 8, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: stubsabot 🤖 Third-party stub updates by stubsabot 🤖

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily tests failed on Mon Jun 08 2026

3 participants