Skip to content

Build the docker images on GitHub-hosted runners - #3887

Merged
huydhn merged 1 commit into
masterfrom
osdc/docker-build
Oct 14, 2026
Merged

huydhn merged 1 commit into
masterfrom
osdc/docker-build

Conversation

@huydhn

@huydhn huydhn commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
  • Build the docker images on Meta's GitHub-hosted 4-core-ubuntu and 16-core-ubuntu runners instead of EC2 linux.4xlarge and linux.12xlarge, since OSDC runners have no docker daemon for build.sh and push_all.sh.
  • Drop the test-infra setup-linux step, which logs in to ECR with credentials GitHub-hosted runners don't have.

Testing: the [DO NOT MERGE] commit touches docker/docker.cfg so this PR builds all four image groups, https://github.com/pytorch/ignite/actions/runs/38001401349. Drop it before merging.

@huydhn
huydhn added this pull request to stack #3886 October 9, 2026 22:47
@huydhn
huydhn force-pushed the osdc/docker-build branch from 2227f85 to 1664b1e Compare October 9, 2026 22:50
@huydhn
huydhn requested a review from vfdev-5 October 9, 2026 22:50
@huydhn huydhn changed the title Build the docker images with remote BuildKit on OSDC runners Build the docker images on GitHub-hosted runners Oct 9, 2026
@huydhn
huydhn marked this pull request as ready for review October 9, 2026 22:52
@huydhn
huydhn force-pushed the osdc/docker-build branch from f199b74 to 90e64a7 Compare October 13, 2026 23:33
@huydhn
huydhn requested a review from atalman October 14, 2026 07:20
@huydhn
huydhn force-pushed the osdc/docker-build branch from 6d7626b to 88040b5 Compare October 14, 2026 20:45
@huydhn
huydhn removed this pull request from stack #3886 October 14, 2026 20:46
@huydhn
huydhn changed the base branch from osdc/gpu-hvd-tests to master October 14, 2026 20:46
@huydhn
huydhn merged commit f3f4e94 into master Oct 14, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants