Honour force='yes' in stringify_param - #619
Open
ckarnell wants to merge 1 commit into
Open
Conversation
ChildRelationship.stringify_param accepted force and never read it, so path(force='yes') returned None for an unrepresentable dict key, the case its own docstring promises to render as '(unrepresentable)'. Adds test_unrepresentable_dict_key_path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChildRelationship.stringify_paramtakesforceand never reads it, sopath(force='yes')returns None for the case its own docstring calls out.path()documents it like this:A custom object used as a dictionary key:
reprdoesn't round-trip here, sostringify_paramsetsresult = Noneand returns it whateverforcesays.NonSubscriptableIterableRelationship.get_param_reprdoes implementforce, which is why the set case intest_non_subscriptable_iterable_pathworks and this one never has.Three lines, in
stringify_paramwhereforcealready arrives.One judgement call for you. The result goes through
param_repr_format, so a dict key comes out asroot[(unrepresentable)]while the existing set case isroot(unrepresentable)because it bypasses the format. Brackets seemed right since the key is the part being replaced, but say the word if you'd rather have it raw. I leftforce='fake'alone.Test is
test_unrepresentable_dict_key_path, next to the set-case test. Suite goes 1258 to 1259, with the same 5 failures and 1 error before and after (they are intest_serialization.pyandtest_lfucache.pyand predate this). Reverting onlymodel.pyfails the new test alone.