Skip to content

Add UFS support for Glymur Qualcomm SoC - #1832

Open
Pradeep P V K (Pradeep-pvk) wants to merge 2 commits into
qualcomm-linux:tech/all/dt/glymurfrom
Pradeep-pvk:topic/glymur_ufs_v1
Open

Pradeep P V K (Pradeep-pvk) wants to merge 2 commits into
qualcomm-linux:tech/all/dt/glymurfrom
Pradeep-pvk:topic/glymur_ufs_v1

Conversation

@Pradeep-pvk

Copy link
Copy Markdown
Contributor

This series adds the DT bindings, device tree support for the UFS PHY
and UFS Host Controller, along with the required PHY driver updates to
enable UFS support on the Glymur Qualcomm platform.

This series depends on Glymur LNBB clocks1 and Glymur QCB platform2
series.

Link: https://lore.kernel.org/all/20260911-glymur_ufs_qcb_enablement-v1-0-b9fc5e2ee99a@oss.qualcomm.com/
Signed-off-by: Pradeep P V K pradeep.pragallapati@oss.qualcomm.com

Add UFS PHY and UFS host controller nodes for Glymur SoC.

Link: https://lore.kernel.org/all/20260911-glymur_ufs_qcb_enablement-v1-3-b9fc5e2ee99a@oss.qualcomm.com/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Enable UFS for glymur-qcb board.

Link: https://lore.kernel.org/all/20260911-glymur_ufs_qcb_enablement-v1-4-b9fc5e2ee99a@oss.qualcomm.com/
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1832 — validate-patch

PR: #1832

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — both commits include correct Link: tags pointing to lore.kernel.org message IDs
  2. Lore link matches PR commits: Yes — diff content is faithful to lore patches 3/5 and 4/5; line number shifts in commit 1/2 are due to legitimate context differences in the target tree
  3. Upstream patch status: ✅ ACKed — both patches received Reviewed-by: from Abel Vesa and Acked-by: from Konrad Dybcio; posted Sep 11, 2026; not yet merged into mainline (expected for recent posting)
  4. PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1832 - Add UFS support for Glymur SoC
Upstream commits:


Commit 1/2: FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes

Commit Message

Check Status Note
Subject matches upstream Identical to lore patch 3/5 subject
Body preserves rationale Body text matches: "Add UFS PHY and UFS host controller nodes for Glymur SoC."
Fixes tag present/correct N/A No Fixes tag in upstream or PR (new feature, not a fix)
Authorship preserved From: matches lore author: Pradeep P V K pradeep.pragallapati@oss.qualcomm.com
Backport note N/A FROMLIST prefix — not yet merged upstream
Link tag present Correct lore link present

Diff Comparison

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Content matches lore patch 3/5; line numbers differ slightly (PR: 830, lore: 812; PR: 4354, lore: 4103dev (@4103)) due to context differences in the target tree

Detailed diff analysis:

  • UFS PHY clock references in GCC node: Identical (lines updating <&ufs_mem_phy 0>, <&ufs_mem_phy 1>, <&ufs_mem_phy 2>)
  • ufs_mem_phy node: Identical structure, compatible string, clocks, resets, status
  • ufs_mem_hc node: Identical structure, compatible strings, reg, interrupts, clocks, interconnects, power-domains, iommus, phys, OPP table
  • Context shift: Line number differences are due to the PR tree having additional content between the GCC node and the UFS nodes compared to the lore baseline — this is a legitimate context difference, not a content mismatch

Commit 2/2: FROMLIST: arm64: dts: qcom: glymur-qcb: Enable UFS

Commit Message

Check Status Note
Subject matches upstream Identical to lore patch 4/5 subject
Body preserves rationale Body text matches: "Enable UFS for glymur-qcb board."
Fixes tag present/correct N/A No Fixes tag in upstream or PR (new feature, not a fix)
Authorship preserved From: matches lore author: Pradeep P V K pradeep.pragallapati@oss.qualcomm.com
Backport note N/A FROMLIST prefix — not yet merged upstream
Link tag present Correct lore link present

Diff Comparison

File Status Notes
arch/arm64/boot/dts/qcom/glymur-qcb.dts Content matches lore patch 4/5 exactly; identical hunks for &ufs_mem_phy and &ufs_mem_hc nodes

Detailed diff analysis:

  • &ufs_mem_phy node: Identical (vdda-phy-supply, vdda-pll-supply, status)
  • &ufs_mem_hc node: Identical (reset-gpios, vcc-supply, vcc-max-microamp, vccq-supply, vccq-max-microamp, status)
  • No context differences: Line numbers and hunks match exactly

Upstream Patch Status

Commit Community Verdict
[PATCH 3/5] arm64: dts: qcom: glymur: Add UFS nodes ACKed — Reviewed-by: Abel Vesa abel.vesa@oss.qualcomm.com; Acked-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com
[PATCH 4/5] arm64: dts: qcom: glymur-qcb: Enable UFS ACKed — Reviewed-by: Abel Vesa abel.vesa@oss.qualcomm.com; Acked-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com

Evidence: Both patches received formal Reviewed-by: from Abel Vesa (Qualcomm maintainer) and Acked-by: from Konrad Dybcio (Qualcomm maintainer) in the lore thread. These are strong acceptance signals indicating the patches are ready for merge into the maintainer tree.

Status: Patches are under review with positive maintainer feedback. Not yet merged into torvalds/linux mainline (posted Sep 11, 2026). The FROMLIST: prefix is correct and appropriate.


Integration Presence (qcom-next/topics)

Per integration_presence_report.md:

Commit Status
1/2: arm64: dts: qcom: glymur: Add UFS nodes ⚠️ Partial — subject or partial tree evidence found, but full change not verified in qcom-next or topics
2/2: arm64: dts: qcom: glymur-qcb: Enable UFS ⚠️ Partial — subject or partial tree evidence found, but full change not verified in qcom-next or topics

Overall: 0/2 commits fully present; 2/2 commits have partial evidence. This is expected for recently posted patches (Sep 11, 2026) that have not yet been merged into the integration tree.


Issues Found

None. Both commits are faithful representations of their upstream lore patches.


Verdict

✅ Merge as-is. Both commits correctly use the FROMLIST: prefix, include proper Link: tags pointing to the lore posting, preserve the original author, and faithfully represent the upstream patch content. The patches have received positive review signals from Qualcomm maintainers (Reviewed-by + Acked-by), indicating they are on track for upstream acceptance.


Final Summary

  1. Lore link present: Yes — both commits include correct Link: tags pointing to lore.kernel.org message IDs
  2. Lore link matches PR commits: Yes — diff content is faithful to lore patches 3/5 and 4/5; line number shifts in commit 1/2 are due to legitimate context differences in the target tree
  3. Upstream patch status: ✅ ACKed — both patches received Reviewed-by: from Abel Vesa and Acked-by: from Konrad Dybcio; posted Sep 11, 2026; not yet merged into mainline (expected for recent posting)
  4. PR present in qcom-next/topics: Partial (2/2 commits) — partial evidence found; full integration not yet verified (expected for recently posted patches)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/2 [PATCH 2/2] FROMLIST: arm64: dts: qcom: glymur-qcb: Enable UFS partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/2
partial_commits: 2/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1832 — checker-log-analyzer

PR: #1832
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34959926187

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Not run - automerge failed
dt-binding-check ⏭️ Not run - automerge failed
dtb-check ⏭️ Not run - automerge failed
sparse-check ⏭️ Not run - automerge failed
check-uapi-headers ⏭️ Not run - automerge failed
check-patch-compliance ⏭️ Not run - automerge failed
tag-check N/A Not applicable - topic branch target
qcom-next-check N/A Not applicable - topic branch target

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1832 - FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34959926187

Checker Result Summary
checkpatch ⏭️ Not run - automerge failed
dt-binding-check ⏭️ Not run - automerge failed
dtb-check ⏭️ Not run - automerge failed
sparse-check ⏭️ Not run - automerge failed
check-uapi-headers ⏭️ Not run - automerge failed
check-patch-compliance ⏭️ Not run - automerge failed
tag-check N/A Not applicable - topic branch target
qcom-next-check N/A Not applicable - topic branch target

❌ Automerge Failure (Pre-Checker Stage)

Root cause: Merge conflict during automerge integration step prevented all checkers from running.

Failure details:

Normal merge conflict for 'Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts

Context:

  • Target branch: tech/all/dt/glymur (kernel-topics repo)
  • Automerge config: baseline qcom-next + topic tech/all/dt/glymur
  • Conflicting file: Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml

The CI workflow attempts to integrate the topic branch (tech/all/dt/glymur) with the baseline (qcom-next) before running checkers. This automerge step failed due to a merge conflict in a DT binding file that is unrelated to the UFS changes in this PR.

Fix:

This is a topic branch integration conflict, not a defect in the PR patches themselves. The conflict is between the topic branch and qcom-next baseline, likely caused by concurrent changes to the same binding file in different topic branches.

Resolution options:

  1. Rebase the topic branch tech/all/dt/glymur onto the latest qcom-next:

    git checkout tech/all/dt/glymur
    git fetch origin qcom-next
    git rebase origin/qcom-next
    # Resolve conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
    git add Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
    git rebase --continue
    git push --force-with-lease
  2. Re-trigger CI after the topic branch is rebased and the conflict is resolved.

Note: The PR patches themselves (UFS nodes for glymur) appear well-formed with proper FROMLIST: prefixes and lore links. Once the topic branch conflict is resolved, the checkers should run cleanly.

Verdict

Cannot assess PR quality — all checkers were blocked by a pre-existing topic branch integration conflict unrelated to this PR's changes. The conflict must be resolved at the topic branch level before checkers can run.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1832

PR: #1832
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34963229863

# Error File:Line PR-introduced? Root Cause
1 Automerge conflict Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml No Pre-existing merge conflict during integration with base branch tech/all/dt/glymur

Verdict

This is NOT a compilation failure. The build failed during the automerge/integration step due to a merge conflict in a file unrelated to this PR. The PR itself (adding UFS nodes to glymur.dtsi and glymur-qcb.dts) does not introduce any compilation errors.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1832

PR: #1832
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34963229863

# Error File:Line PR-introduced? Root Cause
1 Automerge failure: 137 merge conflicts Multiple files No Integration conflicts during automerge with qcom-next baseline and other topic branches. Build never reached compilation stage.
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur.dtsi Partial PR modifies this file; conflict arose when merging with other branches that also modified it.
3 Merge conflict (add/add) arch/arm64/boot/dts/qcom/glymur-qcb.dts Partial PR modifies this file; conflict arose when merging with other branches that also added/modified it.

Verdict

This is NOT a compilation failure. The build failed during the automerge (integration) step with 137 merge conflicts across the codebase. Two of the conflicting files are modified by this PR, but the conflicts are due to concurrent changes in other topic branches, not errors in the PR code itself. The PR code was never compiled.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1832 — validate-patch

PR: #1832

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — both commits include correct Link: tags pointing to lore.kernel.org message IDs from the glymur_ufs_qcb_enablement-v1 patch series

  2. Lore link matches PR commits: Yes — diff content is identical; only line numbers differ due to context (830→812, 4354→4103 in commit 1/2), which is a legitimate context-only delta

  3. Upstream patch status: ✅ ACKed — both patches received Acked-by: Konrad Dybcio and Reviewed-by: Abel Vesa on 2026-09-11; posted to linux-arm-msm, linux-phy, devicetree, linux-kernel, and linux-scsi mailing lists; awaiting maintainer merge

  4. PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1832 - Add UFS support for Glymur SoC
Upstream commits:


Commit 1/2: FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes

Commit Message

Check Status Note
Subject matches upstream Identical after stripping FROMLIST: prefix
Body preserves rationale "Add UFS PHY and UFS host controller nodes for Glymur SoC." preserved verbatim
Fixes tag present/correct N/A No Fixes tag in upstream (new feature, not a fix)
Authorship preserved From: matches lore author: Pradeep P V K pradeep.pragallapati@oss.qualcomm.com
Backport note N/A FROMLIST: prefix correctly used; patch posted to mailing list but not yet merged
Link tag present Correct lore.kernel.org link included

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Identical code changes; line number differences (830 vs 812, 4354 vs 4103) are context-only deltas due to tree differences

Upstream Patch Status:ACKed — Received formal review tags:

  • Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
  • Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Posted on 2026-09-11. Part of 5-patch series (this is patch 3/5). Patches 1-2 add DT binding documentation; patches 3-5 add DTS nodes. PR correctly includes only the DTS changes (patches 3-4 from the series).


Commit 2/2: FROMLIST: arm64: dts: qcom: glymur-qcb: Enable UFS

Commit Message

Check Status Note
Subject matches upstream Identical after stripping FROMLIST: prefix
Body preserves rationale "Enable UFS for glymur-qcb board." preserved verbatim
Fixes tag present/correct N/A No Fixes tag in upstream (new feature, not a fix)
Authorship preserved From: matches lore author: Pradeep P V K pradeep.pragallapati@oss.qualcomm.com
Backport note N/A FROMLIST: prefix correctly used
Link tag present Correct lore.kernel.org link included

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-qcb.dts Identical code changes; adds UFS PHY and controller supplies/config

Upstream Patch Status:ACKed — Received formal review tags:

  • Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
  • Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Posted on 2026-09-11. Part of 5-patch series (this is patch 4/5).


Issues

None. Both commits faithfully represent their upstream lore sources with correct FROMLIST: prefix, proper authorship, and accurate Link tags.


Verdict

Merge as-is — Both commits are faithful representations of their lore.kernel.org sources. The patches have received positive review from subsystem maintainers (Konrad Dybcio and Abel Vesa). The FROMLIST: prefix is correctly applied since the patches are posted to the mailing list but not yet merged into mainline. Line number differences in the diff context are expected and legitimate due to tree state differences.


Final Summary

  1. Lore link present: Yes — both commits include correct Link: tags pointing to lore.kernel.org message IDs from the glymur_ufs_qcb_enablement-v1 patch series

  2. Lore link matches PR commits: Yes — diff content is identical; only line numbers differ due to context (830→812, 4354→4103 in commit 1/2), which is a legitimate context-only delta

  3. Upstream patch status: ✅ ACKed — both patches received Acked-by: Konrad Dybcio and Reviewed-by: Abel Vesa on 2026-09-11; posted to linux-arm-msm, linux-phy, devicetree, linux-kernel, and linux-scsi mailing lists; awaiting maintainer merge

  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows both commits have "partial" status (subject or partial tree evidence found, but full change not verified in qcom-next or topics branches). This is expected for FROMLIST: patches that are under upstream review but not yet merged.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/2 [PATCH 2/2] FROMLIST: arm64: dts: qcom: glymur-qcb: Enable UFS partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/2
partial_commits: 2/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1832 — checker-log-analyzer

PR: #1832
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34963231792

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict
dt-binding-check ⏭️ Skipped - automerge conflict
dtb-check ⏭️ Skipped - automerge conflict
sparse-check ⏭️ Skipped - automerge conflict
check-uapi-headers ⏭️ Skipped - automerge conflict
check-patch-compliance ⏭️ Skipped - automerge conflict
tag-check Both commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1832 - FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34963231792

Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict
dt-binding-check ⏭️ Skipped - automerge conflict
dtb-check ⏭️ Skipped - automerge conflict
sparse-check ⏭️ Skipped - automerge conflict
check-uapi-headers ⏭️ Skipped - automerge conflict
check-patch-compliance ⏭️ Skipped - automerge conflict
tag-check Both commits have valid FROMLIST: prefix

❌ Automerge Failure (CI Infrastructure)

Root cause: Merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml during automerge step prevented all checker jobs from running.

Failure details:

Normal merge conflict for 'Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts

Analysis:

This PR targets a topic branch (not qcom-next or qcom-next-staging), so the CI workflow attempts to:

  1. Merge qcom-next baseline
  2. Run automerge to integrate all topic branches
  3. Merge this PR on top
  4. Run checkers

The automerge step failed at step 2 due to a merge conflict in a DT binding file that is unrelated to this PR. This PR only modifies:

  • arch/arm64/boot/dts/qcom/glymur.dtsi (UFS nodes)
  • arch/arm64/boot/dts/qcom/glymur-qcb.dts (UFS enablement)

The conflict is in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml, which this PR does not touch.

Impact: None of the individual checkers (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) were able to run. The CI failure is not caused by defects in this PR.

Fix:

This is a CI infrastructure issue, not a patch defect. The conflict must be resolved in the topic branch integration before this PR can be tested. Options:

  1. Rebase the topic branch that introduced the conflicting change to qcom,coresight-ctcu.yaml
  2. Manually resolve the automerge conflict in the topic branch integration
  3. Re-trigger CI after the topic branch conflict is resolved
  4. Test this PR against qcom-next directly (if the topic branch is qcom-next-staging or a feature branch)

Manual verification (recommended):

Since the CI couldn't run, manually verify the patches locally:

# Clone and checkout the PR branch
git fetch origin pull/1832/head:pr-1832
git checkout pr-1832

# Run checkpatch
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git HEAD~2..HEAD

# Build DTBs (if you have a cross-compiler)
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) arch/arm64/boot/dts/qcom/glymur-qcb.dtb

# Validate DT bindings (if modified - not applicable here)
# make dt_binding_check DT_SCHEMA_FILES=...

✅ tag-check

Status: PASS

Both commits in this PR have valid subject prefixes:

  • Commit 1: FROMLIST: arm64: dts: qcom: glymur: Add UFS nodes
  • Commit 2: FROMLIST: arm64: dts: qcom: glymur-qcb: Enable UFS

Both include Link: trailers pointing to lore.kernel.org, which is correct for FROMLIST: patches.

Verdict

Cannot assess patch quality — all checker jobs were blocked by an unrelated automerge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml.

Recommended actions:

  1. Resolve the topic branch automerge conflict (not in this PR's scope)
  2. Re-trigger CI after conflict resolution
  3. Optionally: run manual verification commands above to validate patches locally

No changes required to this PR — the failure is a CI infrastructure issue, not a defect in the submitted patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants