Skip to content

Revert lt9611 driver - #1851

Merged
Komal Bajaj (Komal-Bajaj) merged 2 commits into
qualcomm-linux:tech/all/shikrafrom
mohitdsor:revert-lt9611-driver
Sep 17, 2026
Merged

Komal Bajaj (Komal-Bajaj) merged 2 commits into
qualcomm-linux:tech/all/shikrafrom
mohitdsor:revert-lt9611-driver

Conversation

@mohitdsor

Copy link
Copy Markdown
  • Revert "FROMLIST: drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"
  • Revert "FROMLIST: dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"

CRs-Fixed: 4560244

… HDMI driver"

This reverts commit 9df5f01.

Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
…PI DSI to HDMI driver"

This reverts commit 55256b3.

Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1851

PR: #1851
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35200362404

# Error File:Line PR-introduced? Root Cause
1 Merge conflict Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml No Pre-existing conflict between base and topic branch tech/all/shikra
2 Merge conflict Documentation/devicetree/bindings/arm/qcom.yaml No Pre-existing conflict between base and topic branch tech/all/shikra
3 Merge conflict Documentation/devicetree/bindings/clock/qcom,glymur-evacc.yaml No Pre-existing conflict between base and topic branch tech/all/shikra
4 Merge conflict Documentation/devicetree/bindings/clock/qcom,qcm2290-dispcc.yaml No Pre-existing conflict between base and topic branch tech/all/shikra
5 Merge conflict Documentation/devicetree/bindings/clock/qcom,shikra-audiocorecc.yaml No Pre-existing conflict between base and topic branch tech/all/shikra
6 Merge conflict Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml No Pre-existing conflict between base and topic branch tech/all/shikra

Verdict

All 6 merge conflicts are pre-existing integration issues. None are introduced by this PR. The PR only reverts Lontium LT9611C driver changes and does not touch any of the conflicting files.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1851

PR: #1851
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35200362404

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml No Pre-existing merge conflict in the integration branch, unrelated to PR changes

Verdict

The build failure is not caused by this PR. The failure occurred during the automerge phase due to a pre-existing merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml, which is completely unrelated to the PR's changes to the Lontium LT9611 bridge driver files.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1851 — validate-patch

PR: #1851

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — Revert commits do not require lore links; they reference the original commits being reverted (9df5f01 and 55256b3)
  2. Lore link matches PR commits: N/A — The original commits being reverted have lore links (https://lore.kernel.org/all/20260808-lt9611c-v7-v10-2-ee90a136d82a@oss.qualcomm.com/ and https://lore.kernel.org/all/20260808-lt9611c-v7-v10-1-ee90a136d82a@oss.qualcomm.com/), but the revert commits themselves do not need lore links
  3. Upstream patch status: N/A — The original FROMLIST patches being reverted were posted to lore.kernel.org but their upstream acceptance status cannot be verified due to network restrictions. The patches are present in Qualcomm topic branches (Shikra headphone support).
  4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1851 - Revert LT9611C(EX/UXD) MIPI DSI to HDMI driver patches
Upstream commit: N/A (Revert commits)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Correctly references the original FROMLIST commits being reverted
Body preserves rationale No explanation provided for why these commits are being reverted
Fixes tag present/correct N/A Not applicable for revert commits
Authorship preserved Mohit Dsor is the submitter and signer
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
Documentation/ABI/testing/sysfs-lontium-firmware Correctly removes file added by commit 9df5f01
drivers/gpu/drm/bridge/Kconfig Correctly removes DRM_LONTIUM_LT9611C config added by commit 9df5f01
drivers/gpu/drm/bridge/Makefile Correctly removes lontium-lt9611c.o from build
drivers/gpu/drm/bridge/lontium-lt9611c.c Correctly removes entire 1283-line driver file
Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml Correctly reverts dt-binding changes from commit 55256b3

Issues

Critical Issues:

  1. Missing revert rationale — The commit messages provide no explanation for why these FROMLIST patches are being reverted. Revert commits should include a clear justification (e.g., "breaks boot on X platform", "causes regression in Y", "upstream rejected the approach", etc.).

  2. Incomplete revert in integration — According to integration_presence_report.md:

    • Commit 1/2 (driver revert): missing from both qcom-next and topics
    • Commit 2/2 (dt-binding revert): present in topics

    This indicates commit 1/2 has not been integrated into any branch yet, while commit 2/2 is already present. This asymmetry suggests the PR may be attempting to revert commits that are in different states of integration.

  3. Original commits exist in topic branches — The commits being reverted (9df5f01 and 55256b3) are present in topic branches:

    • topics/Headphone_support_for_shikra
    • topics/Shikra_headphone_support
    • topics/tech/all/shikra

    If these topic branches are still active, reverting these commits in isolation may cause integration conflicts or leave the topic branches in an inconsistent state.

Recommendations:

  1. Add a clear rationale to both commit messages explaining why the LT9611C driver is being reverted.
  2. Coordinate with the topic branch owners (Shikra headphone support) to ensure the revert doesn't break their integration.
  3. Consider whether both commits should be reverted together or if the dt-binding should remain (since it's already in topics).
  4. If the upstream patches were rejected or need rework, document that in the commit message with a Link: to the relevant lore thread discussion.

Verdict

Do not merge — While the revert diffs are technically correct (they cleanly undo the original commits), the lack of rationale and the asymmetric integration status (1/2 missing, 2/2 present) indicate this PR needs additional context and coordination before merging.

Final Summary

  1. Lore link present: No — Revert commits do not require lore links; they reference the original commits being reverted (9df5f01 and 55256b3)
  2. Lore link matches PR commits: N/A — The original commits being reverted have lore links (https://lore.kernel.org/all/20260808-lt9611c-v7-v10-2-ee90a136d82a@oss.qualcomm.com/ and https://lore.kernel.org/all/20260808-lt9611c-v7-v10-1-ee90a136d82a@oss.qualcomm.com/), but the revert commits themselves do not need lore links
  3. Upstream patch status: N/A — The original FROMLIST patches being reverted were posted to lore.kernel.org but their upstream acceptance status cannot be verified due to network restrictions. The patches are present in Qualcomm topic branches (Shikra headphone support).
  4. PR present in qcom-next/topics: Fail — 1/2 commit (driver revert) is missing from both qcom-next and topics; 2/2 commit (dt-binding revert) is present in topics. This asymmetric state requires investigation before merging.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] Revert "FROMLIST: drm/bridge: Add Lontium LT9611C(EX/UXD) missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] Revert "FROMLIST: dt-bindings: bridge: Add Lontium missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: FAIL
present_commits: 1/2
partial_commits: 0/2
missing_commits: 1/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1851 — checker-log-analyzer

PR: #1851
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35200362615

Checker Result Summary
Checker Result Summary
checkpatch CI infrastructure failure: automerge conflicts
dt-binding-check CI infrastructure failure: automerge conflicts
dtb-check CI infrastructure failure: automerge conflicts
sparse-check CI infrastructure failure: automerge conflicts
check-uapi-headers CI infrastructure failure: automerge conflicts
check-patch-compliance CI infrastructure failure: automerge conflicts
tag-check ⏭️ Cannot evaluate: automerge failed before tag check

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1851 - Revert LT9611C driver patches
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35200362615

Checker Result Summary
checkpatch CI infrastructure failure: automerge conflicts
dt-binding-check CI infrastructure failure: automerge conflicts
dtb-check CI infrastructure failure: automerge conflicts
sparse-check CI infrastructure failure: automerge conflicts
check-uapi-headers CI infrastructure failure: automerge conflicts
check-patch-compliance CI infrastructure failure: automerge conflicts
tag-check ⏭️ Cannot evaluate: automerge failed before tag check

❌ CI Infrastructure Failure — Automerge Conflicts

Root cause: All checker jobs failed during the automerge step when attempting to merge the PR branch into the baseline qcom-next branch. The CI encountered merge conflicts in multiple files and could not proceed to run any actual checker validation.

Failure details:

From all checker logs (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance):

Normal merge conflict for 'Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts
Hit return to start merge resolution tool (vimdiff): Continue merging other unresolved paths [y/n]? 
##[error]Process completed with exit code 1.

The automerge script detected conflicts in at least:

  • Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml
  • Plus 100+ other files listed in the merge conflict output

Analysis:

This PR contains 2 revert commits:

  1. Revert "FROMLIST: drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"
  2. Revert "FROMLIST: dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"

The revert commits are attempting to remove code that was previously added. However, when the CI attempts to merge this PR into the current qcom-next baseline, it encounters conflicts because:

  1. The baseline has diverged significantly since the original commits were added
  2. Other PRs may have modified the same files or related code
  3. The revert may be targeting commits that have already been modified or removed in the baseline

This is NOT a patch quality issue — the revert commits themselves may be correctly formatted. The issue is that the PR branch has become stale and cannot be cleanly merged into the current baseline without manual conflict resolution.

Fix:

The PR author needs to rebase the PR branch onto the latest qcom-next baseline and resolve all merge conflicts manually:

# In the PR branch
git fetch origin qcom-next
git rebase origin/qcom-next

# Resolve conflicts in each file as prompted
# For each conflicted file:
git add <file>
git rebase --continue

# Force-push the rebased branch
git push --force-with-lease

Alternative approach:

If the original commits being reverted are no longer present in qcom-next (already removed or modified), this PR may no longer be necessary. The author should:

  1. Check if the LT9611C driver code still exists in the current qcom-next branch
  2. If it's already gone, close this PR as no longer needed
  3. If it's still present but modified, create a new revert commit based on the current state

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics
git fetch origin pull/1851/head:pr-1851
git checkout qcom-next
git merge pr-1851
# Observe merge conflicts

⚠️ Subject Prefix Check (tag-check)

Status: Cannot evaluate — automerge failed before the PR commits could be analyzed.

Note: Both commits in this PR appear to be revert commits with subjects starting with Revert "FROMLIST: .... According to the tag-check rules (Section 2.7 of the skill), revert commits must carry a prefix before the word Revert.

Expected format:

UPSTREAM: Revert "FROMLIST: drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"

or

FROMLIST: Revert "FROMLIST: drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"

Current format (from pr.patch):

Revert "FROMLIST: drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"
Revert "FROMLIST: dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver"

Action required: Once the merge conflicts are resolved, the commit subjects should be amended to include the appropriate prefix before Revert.


Verdict

Cannot merge — CI infrastructure failure due to merge conflicts.

Immediate action required:

  1. Rebase the PR branch onto the latest qcom-next baseline
  2. Resolve all merge conflicts manually
  3. Verify the revert commits are still necessary (check if the code being reverted still exists)
  4. Add subject-line prefixes before Revert in both commit messages
  5. Force-push the updated branch to re-trigger CI

No patch quality issues can be assessed until the automerge step succeeds and the checkers can run against the actual patch content.

@Komal-Bajaj
Komal Bajaj (Komal-Bajaj) merged commit 9c4ea00 into qualcomm-linux:tech/all/shikra Sep 17, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants