Skip to content

WORKAROUND: phy: qcom: qmp-combo: Request synced GDSC power-off on PHY exit #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quicmahap wants to merge 1 commit into
base: tech/bus/usb/phy
Choose a base branch
from
Open

WORKAROUND: phy: qcom: qmp-combo: Request synced GDSC power-off on PHY exit #1853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions drivers/phy/qualcomm/phy-qcom-qmp-combo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <linux/of_graph.h>
#include <linux/phy/phy.h>
#include <linux/platform_device.h>
#include <linux/pm_domain.h>
#include <linux/regulator/consumer.h>
#include <linux/reset.h>
#include <linux/slab.h>
Expand Down Expand Up @@ -2262,6 +2263,12 @@ struct qmp_phy_cfg {
unsigned int pcs_usb_offset;

bool invert_cc_polarity;

/*
* true, if the PHY GDSC must be kept on until the common PHY block
* is fully exited, and powered off via a synced power-off request
*/
bool use_synced_poweroff;
};

struct qmp_combo {
Expand Down Expand Up @@ -3027,6 +3034,8 @@ static const struct qmp_phy_cfg glymur_usb3dpphy_cfg = {
.num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l),
.vreg_list = qmp_phy_vreg_refgen,
.num_vregs = ARRAY_SIZE(qmp_phy_vreg_refgen),

.use_synced_poweroff = true,
};

static int qmp_combo_dp_serdes_init(struct qmp_combo *qmp)
Expand Down Expand Up @@ -3775,6 +3784,15 @@ static int qmp_combo_com_exit(struct qmp_combo *qmp, bool force)
if (!force && --qmp->init_count)
return 0;

/*
* The PHY GDSC is kept on across runtime suspend so that host-mode bus
* suspend can resume without losing PHY state. Now that the common PHY
* block is fully exited, request a synced power-off to let the GDSC
* actually power down.
*/
if (cfg->use_synced_poweroff)
dev_pm_genpd_synced_poweroff(qmp->dev);

reset_control_bulk_assert(cfg->num_resets, qmp->resets);

clk_disable_unprepare(qmp->pipe_clk);
Expand Down