Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending

[maulik-k-shah]

Denying idle state entry requires local_irq_enable() before returning back to caller which is missing.

This reverts commit b2fe44e.

CRs-Fixed: 4681020

[qswat-orbit-external]

Dev Completion validation failed

CR: 4681020
Change Task: kernel.qli.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR could not be moved to Dev Complete because of the error above. Please resolve the issue in Orbit and re-run the failed Orbit check.

[qlijarvis]

🔨 Build Failure Analysis — PR #1855

PR: #1855
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35260028066

#	Error	File:Line	PR-introduced?	Root Cause
1	Automerge conflict	Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml	No	Pre-existing merge conflict between topic branch tech/pm/power and baseline qcom-next in an unrelated devicetree binding file

Verdict

This is a pre-existing integration issue, not a compilation error. The PR changes to drivers/cpuidle/cpuidle.c are not the cause of the build failure.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1855

PR: #1855
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35260028066

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Automerge failure	Multiple files	No	Build failed during automerge/integration phase with 146 merge conflicts. No compilation was attempted.

Verdict

This is not a compilation failure. The build failed during the pre-compilation automerge/integration phase when attempting to merge the PR branch (topic/tech/pm/power) with other topic branches. The PR itself contains a clean 3-line revert in drivers/cpuidle/cpuidle.c and does not introduce any compilation errors. The 146 merge conflicts are integration issues between multiple topic branches, not caused by this specific PR change.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1855

PR: #1855
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35261602639

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Automerge failure (146 merge conflicts)	Multiple files	No	Pre-existing integration conflicts between base branch and topic branches

Verdict

This is not a compilation failure. The build failed during the automerge phase with 146 merge conflicts across device tree bindings, DTS files, sound drivers, and other subsystems. None of these conflicts are introduced by this PR. The PR only modifies drivers/cpuidle/cpuidle.c, which is not involved in any conflicts. This is a pre-existing integration issue in the kernel-config CI workflow.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1855

PR: #1855
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35261602639

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflicts (146 files)	Multiple files	No	Pre-existing integration conflicts between topic branch and baseline

Verdict

No compilation errors found. The build failed during the merge phase with 146 pre-existing merge conflicts in files unrelated to this PR. The PR's changes to drivers/cpuidle/cpuidle.c merged cleanly without conflicts.

📎 Detailed analysis: Full report

[qlijarvis]

PR #1855 — validate-patch

PR: #1855

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

1. Lore link present: No — Revert commit; no lore link expected for the revert itself, though the original commit being reverted (b2fe44e) should have had one
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — This is a revert of a FROMLIST commit; the revert itself is not posted upstream
4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1855 - Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"
Upstream commit: N/A (Revert commit with no lore link)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Revert commit; no upstream source to compare
Body preserves rationale	✅	Clear revert reason provided: missing local_irq_enable()
Fixes tag present/correct	⚠️	No Fixes tag; should reference the reverted commit SHA
Authorship preserved	✅	Author is Maulik Shah (appropriate for revert)
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/cpuidle/cpuidle.c	✅	Clean revert: removes 3 lines that check for pending IPI

Issues

1. Missing commit prefix: The subject line lacks a prefix before "Revert". According to kernel topic branch conventions, reverts should have a prefix indicating the context (e.g., FROMLIST: Revert "..." or QCLINUX: Revert "...").

2. Missing Fixes tag: The commit message should include a Fixes: tag referencing the commit being reverted (b2fe44e6c97ebb6ed95d8d4d60b0955f439c8d69).

3. No lore link for original commit: While the revert itself doesn't need a lore link, the commit message could benefit from referencing the original lore posting of the commit being reverted, to provide full context for reviewers.

4. Incomplete revert justification: The commit message states "requires local_irq_enable() before returning back to caller which is missing" but doesn't explain whether:

   • This is a bug in the original patch that was merged
   • Whether the original patch was rejected upstream for this reason
   • Whether a fixed version is expected

Verdict

Merge with minor improvements recommended. The revert is technically correct (removes the problematic code cleanly), but the commit message could be enhanced with a Fixes tag and a commit prefix for better traceability.

Final Summary

1. Lore link present: No — Revert commit; no lore link expected for the revert itself, though the original commit being reverted (b2fe44e) should have had one
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — This is a revert of a FROMLIST commit; the revert itself is not posted upstream
4. PR present in qcom-next/topics: Yes — present in topics branch at 179ed43 (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] Revert "FROMLIST: cpuidle: Deny idle entry when CPU already	missing - no subject, patch-id, or full tree-content match found	present - exact patch-id match at 179ed43	present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

[qlijarvis]

PR #1855 — checker-log-analyzer

PR: #1855
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35261603442

Checker	Result	Summary
Checker	Result	Summary
checkpatch	⏭️	Skipped - automerge failed
dt-binding-check	⏭️	Skipped - automerge failed
dtb-check	⏭️	Skipped - automerge failed
sparse-check	⏭️	Skipped - automerge failed
check-uapi-headers	⏭️	Skipped - automerge failed
check-patch-compliance	⏭️	Skipped - automerge failed
tag-check	⚠️	Subject prefix issue (see below)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1855 - Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35261603442

Checker	Result	Summary
checkpatch	⏭️	Skipped - automerge failed
dt-binding-check	⏭️	Skipped - automerge failed
dtb-check	⏭️	Skipped - automerge failed
sparse-check	⏭️	Skipped - automerge failed
check-uapi-headers	⏭️	Skipped - automerge failed
check-patch-compliance	⏭️	Skipped - automerge failed
tag-check	⚠️	Subject prefix issue (see below)

⚠️ CI Infrastructure Issue: Automerge Failure

Root cause: The kernel-checkers CI workflow failed during the automerge step when attempting to merge the PR branch with the integration baseline (d49c33864d06e9672dce57738be8851384578fcf) and topic branch topic/tech/pm/power.

Failure details:

Merging topic branches...
** Merging topic branch: topic/tech/pm/power
CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml
CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/arm/qcom.yaml
CONFLICT (add/add): Merge conflict in Documentation/devicetree/bindings/clock/qcom,glymur-evacc.yaml
[... 100+ additional conflicts in DT bindings, DTS files, drivers, sound subsystem ...]
Automatic merge failed; fix conflicts and then commit the result.
automerge returned non-zero; check logs for conflicts
##[error]Process completed with exit code 1.

Analysis:
This PR contains a single, simple revert commit that only touches drivers/cpuidle/cpuidle.c. The merge conflicts are not caused by this PR's changes. Instead, they arise from conflicts between the integration baseline and the topic/tech/pm/power topic branch that the CI is attempting to merge alongside this PR.

The conflicts span 100+ files across:

• DT bindings (YAML files)
• Device tree source files (DTS/DTSI)
• Sound subsystem (ASoC/QDSP6)
• Clock drivers
• Various other subsystems

Impact:
Because the automerge step failed, none of the checker jobs could run. All checkers (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) were skipped.

Fix:
This is a CI infrastructure/workflow issue, not a defect in PR #1855. The PR author cannot fix this by modifying their patch.

Recommended actions:

1. Re-trigger the CI workflow after the topic/tech/pm/power branch conflicts are resolved in the integration tree
2. Or: Run the checkers locally on the PR branch to validate the revert commit:

   # Checkpatch
   ./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git HEAD~1..HEAD
   
   # Sparse (if applicable)
   make C=2 drivers/cpuidle/cpuidle.o

---

⚠️ tag-check — Subject Prefix Issue

Root cause: The commit subject line starts with Revert "FROMLIST: ... but does not have a prefix tag before the word Revert.

Commit subject:

Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"

Issue:
Per the tag-check requirement (mandatory for all branches except qcom-next and qcom-next-staging), every commit subject must start with a valid prefix tag. Revert commits must carry a prefix before the word Revert.

Valid prefix tags:

• FROMLIST: — Patch posted to mailing list
• FROMGIT: — Patch from a maintainer git tree
• UPSTREAM: — Patch merged into mainline
• BACKPORT: — Upstream patch backported with modifications
• QCLINUX: — Vendor-only change
• PENDING: — Work-in-progress
• WORKAROUND: — Temporary fix

Fix:

git rebase -i HEAD~1   # mark commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending\""
# (keep the rest of the commit message body unchanged)
git rebase --continue

Choose the appropriate prefix based on where the revert itself should be categorized:

• If this revert is being posted upstream → FROMLIST: Revert ...
• If this revert is already merged upstream → UPSTREAM: Revert ...
• If this is a vendor-only revert → QCLINUX: Revert ...

Note: This check assumes the target branch is not qcom-next or qcom-next-staging. If the target branch is one of those, the prefix requirement does not apply.

---

Verdict

Cannot assess merge readiness — all checker jobs were skipped due to automerge failure.

Blockers:

1. ❌ CI infrastructure issue: Automerge conflicts between integration baseline and topic/tech/pm/power prevent checkers from running
2. ⚠️ Subject prefix: Revert commit needs a prefix tag before Revert (e.g., UPSTREAM: Revert ...)

Recommendation:

• Fix the subject prefix issue in the PR
• Wait for the integration tree conflicts to be resolved, then re-trigger CI
• Or: Validate the patch locally using checkpatch and sparse, then proceed with merge if the revert logic is sound