Skip to content

Shikra pinctrl intr target width - #1062

Open
akakum-qualcomm wants to merge 8 commits into
qualcomm-linux:qcom-6.18.yfrom
akakum-qualcomm:shikra-pinctrl-intr-target-width
Open

akakum-qualcomm wants to merge 8 commits into
qualcomm-linux:qcom-6.18.yfrom
akakum-qualcomm:shikra-pinctrl-intr-target-width

Conversation

@akakum-qualcomm

@akakum-qualcomm akakum-qualcomm commented Sep 9, 2026

Copy link
Copy Markdown

arm64: dts: qcom: shikra: Replace out-of-tree USB DT with upstream lore series (v7 USB nodes + CYPD6129 role-switch v2)

This branch reverts the 3 out-of-tree/FROMLIST/PENDING Shikra USB commits
carried in this tree and replaces them with the equivalent upstream
lore.kernel.org patch series, applied cleanly on top of qcom-6.18.y:

https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
(arm64: dts: qcom: Add support for usb nodes on Shikra, v7)
https://lore.kernel.org/all/20260821-shikra-usb-dt-v7-apply-v2-0-628885fc1d0e@oss.qualcomm.com/
(arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports, v2)
Reverted:

Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
Applied on top (from lore, unmodified upstream patches):

arm64: dts: qcom: Add support for usb nodes on Shikra
arm64: dts: qcom: Enable USB controllers on Shikra platforms
dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Net effect: shikra-cqm-evk, shikra-cqs-evk, and shikra-iqs-evk now use the
upstream CYPD6129/CYPD6229 UCSI Type-C controller for USB role switching
(via &i2c3/typec@40) instead of the previous PM4125-native typec block,
while shikra.dtsi/shikra-evk.dtsi gain the base usb_1/usb_2 dwc3, USB
HS/QMP PHY, and QUSB2 efuse-trim nodes needed to support them.

All four affected board/SoC DT files were rebuilt with dtc
(qcom/shikra-cqm-evk.dtb, qcom/shikra-cqs-evk.dtb, qcom/shikra-iqs-evk.dtb)
with no warnings or errors.

Signed-off-by: Akash Kumar akash.kumar@oss.qualcomm.com

links: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/

CRs-Fixed: 4652998
CRs-Fixed:: 4635219

qli-2.1 pull-request freeze

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@akakum-qualcomm
akakum-qualcomm force-pushed the shikra-pinctrl-intr-target-width branch from 69adee8 to ce6e21f Compare September 9, 2026 12:50
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@akakum-qualcomm
akakum-qualcomm force-pushed the shikra-pinctrl-intr-target-width branch from c65eb1b to bff2c44 Compare September 10, 2026 13:50
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@akakum-qualcomm
akakum-qualcomm force-pushed the shikra-pinctrl-intr-target-width branch from bff2c44 to 4450b09 Compare September 10, 2026 13:59
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@akakum-qualcomm

Copy link
Copy Markdown
Author

qli-2.1 pull-request freeze

@akakum-qualcomm
akakum-qualcomm force-pushed the shikra-pinctrl-intr-target-width branch from 5c2e4d9 to 76b745a Compare September 10, 2026 17:23
@sgaud-quic

Copy link
Copy Markdown
Contributor

Compilation error :

 Error: /opt/actions-runner/_work/kernel-config/kernel-config/arch/arm64/boot/dts/qcom/shikra-evk.dtsi:49.1-7 Label or path usb_2 not found
  Error: /opt/actions-runner/_work/kernel-config/kernel-config/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:812.1-7 Label or path usb_2 not found
    DTC     arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dtb
  Error: /opt/actions-runner/_work/kernel-config/kernel-config/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:822.1-13 Label or path usb_2_hsphy not found
  FATAL ERROR: Syntax error parsing input tree
  Error: /opt/actions-runner/_work/kernel-config/kernel-config/arch/arm64/boot/dts/qcom/shikra-evk.dtsi:49.1-7 Label or path usb_2 not found

@qlijarvis

Copy link
Copy Markdown

PR #1062 — validate-patch

PR: #1062

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Partial — 5/8 commits have lore links (commits 4-8); 3/8 commits are QCLINUX reverts with no lore link expected
  2. Lore link matches PR commits: No — commit 4 merges multiple patches; commits 6-8 have wrong lore links (cover letter instead of individual patches)
  3. Upstream patch status: ⏳ Decision Pending — all FROMLIST commits have review tags but no merge confirmation yet
  4. PR present in qcom-next/topics: Fail - 4/8 commit(s) are missing from both qcom-next and topics

[/VALIDATE_PATCH_REPORT]

Verdict: ❌ — click to expand

Now let me produce the final validation report:

🔍 Patch Validation

PR: #1062 - "Add USB and Type-C support for Shikra platforms"
Verdict: ❌ FAIL


Summary by Commit

Commit 1/8: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"

Lore link present: No — QCLINUX: prefix; no lore link expected or required
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — vendor-only revert, not posted upstream
PR present in qcom-next/topics: Missing — not found in qcom-next or topics

Verdict: ⚠️ PARTIAL — QCLINUX revert is correctly formatted, but the commit being reverted is not present in qcom-next/topics, which suggests this revert may be unnecessary or the baseline is incorrect.


Commit 2/8: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"

Lore link present: No — QCLINUX: prefix; no lore link expected or required
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — vendor-only revert, not posted upstream
PR present in qcom-next/topics: Present — found in topics

Verdict:PASS — QCLINUX revert is correctly formatted and the commit being reverted exists in the integration tree.


Commit 3/8: QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec support for Shikra"

Lore link present: No — QCLINUX: prefix; no lore link expected or required
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — vendor-only revert, not posted upstream
PR present in qcom-next/topics: Missing — not found in qcom-next or topics

Verdict: ⚠️ PARTIAL — QCLINUX revert is correctly formatted, but the commit being reverted is not present in qcom-next/topics, which suggests this revert may be unnecessary or the baseline is incorrect.


Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra

Lore link present: Yes — https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ (cover letter) and https://lore.kernel.org/all/20260712-usb-shikra-phy-v6-v6-4-1b3e51bf1541@oss.qualcomm.com/ (phy series)
Lore link matches PR commits:NOAUTHORSHIP MISMATCH
Upstream patch status:Decision Pending — Reviewed-by tags from Konrad Dybcio and Manivannan Sadhasivam present; no merge confirmation yet
PR present in qcom-next/topics: Partial — subject or partial tree evidence found, but full change not verified

Issues:

  1. ❌ CRITICAL: Authorship mismatch — The lore patch author is Krishna Kurapati <krishna.kurapati@oss.qualcomm.com> (confirmed in lore_evidence/1_*.mbox), and the PR commit correctly preserves this in the From: field. However, the PR commit contains significantly more content than the lore patch:

    • Lore patch scope (v7 patch 1/2): Adds USB controller and phy nodes to shikra.dtsi only (DT changes)
    • PR commit scope: Adds USB nodes to shikra.dtsi PLUS modifies Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml, drivers/phy/qualcomm/phy-qcom-qmp-usbc.c, and drivers/pinctrl/qcom/pinctrl-shikra.c (binding + driver changes)

    The binding and driver changes appear to come from the phy series (link 2: https://lore.kernel.org/all/20260712-usb-shikra-phy-v6-v6-4-1b3e51bf1541@oss.qualcomm.com/), which is a separate patch series with its own patches. Merging multiple upstream patches into a single commit violates the one-commit-per-upstream-patch rule and makes the change unreviewable.

  2. ❌ FAIL: Multiple lore links for a single commit — The commit references two different lore series (usb-shikra-v7 and usb-shikra-phy-v6). A FROMLIST commit should correspond to a single upstream patch, not a merge of multiple patches from different series.

  3. ⚠️ WARNING: Akash Kumar's Signed-off-by added — The PR adds Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com> as a second SOB, which is correct for the submitter who cherry-picked the patch, but the extra content makes this more than a simple cherry-pick.

Recommendation: Split this commit into separate commits:

  • One FROMLIST commit for the DT-only changes from the usb-shikra-v7 series (patch 1/2)
  • Separate FROMLIST commits for each patch from the usb-shikra-phy-v6 series (binding, driver, pinctrl changes)

Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms

Lore link present: Yes — https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Lore link matches PR commits:YES — Authorship preserved (Krishna Kurapati), Reviewed-by tags present, Akash Kumar's SOB added as submitter
Upstream patch status:Decision Pending — Reviewed-by tags from Manivannan Sadhasivam and Dmitry Baryshkov present; no merge confirmation yet
PR present in qcom-next/topics: Present — all checked added lines are present in topics

Verdict:PASS — Commit faithfully represents lore patch v7 2/2, authorship preserved, tags correct.


Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller

Lore link present: Yes — https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Lore link matches PR commits:NOWRONG LORE LINK
Upstream patch status:Decision Pending — Acked-by from Conor Dooley present (DT binding maintainer); no merge confirmation yet
PR present in qcom-next/topics: Missing — not found in qcom-next or topics

Issues:

  1. ❌ CRITICAL: Wrong lore link — The Link: tag points to message-ID 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com, which is patch 4/3 (the cover letter or a later patch in the series). The lore evidence shows this is the cover letter for a 3-patch series titled "Add usb-role-switch support for USB Type-C ports on Shikra". The actual binding patch is likely patch 1/3 in that series, not patch 4/3 (which doesn't exist in a 3-patch series). The message-ID format suggests this is the cover letter (patch 0/3).

  2. ⚠️ WARNING: Authorship — The PR commit author is Akash Kumar <akash.kumar@oss.qualcomm.com>, which matches the lore series author, so authorship is correct.

Recommendation: Update the Link: tag to point to the correct message-ID for patch 1/3 of the series (the actual dt-bindings patch), not the cover letter.


Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229

Lore link present: Yes — https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Lore link matches PR commits:NOWRONG LORE LINK (same issue as commit 6)
Upstream patch status:Decision Pending — Reviewed-by from Abel Vesa present; no merge confirmation yet
PR present in qcom-next/topics: Missing — not found in qcom-next or topics

Issues:

  1. ❌ CRITICAL: Wrong lore link — Same issue as commit 6: the Link: tag points to the cover letter (patch 0/3) instead of the actual driver patch (likely patch 2/3).

Recommendation: Update the Link: tag to point to the correct message-ID for patch 2/3 of the series (the ucsi_ccg driver patch).


Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports

Lore link present: Yes — https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Lore link matches PR commits:NOWRONG LORE LINK (same issue as commits 6-7)
Upstream patch status:Decision Pending — no explicit review tags visible in lore evidence; series is recent (Aug 20, 2026)
PR present in qcom-next/topics: Partial — subject or partial tree evidence found, but full change not verified

Issues:

  1. ❌ CRITICAL: Wrong lore link — Same issue as commits 6-7: the Link: tag points to the cover letter (patch 0/3) instead of the actual DT patch (likely patch 3/3).

Recommendation: Update the Link: tag to point to the correct message-ID for patch 3/3 of the series (the shikra DT patch).


Overall Verdict

❌ FAIL — This PR has multiple critical issues that must be fixed before merging:

  1. Commit 4 merges multiple upstream patches into one commit — violates the one-commit-per-upstream-patch rule and makes the change unreviewable. Must be split into separate commits.

  2. Commits 6, 7, 8 have incorrect lore links — all three point to the cover letter (patch 0/3) instead of the individual patches (1/3, 2/3, 3/3). This makes it impossible to verify the patches against their upstream sources.

  3. 4 out of 8 commits are missing from qcom-next/topics — commits 1, 3, 6, 7 are not present in the integration tree, which suggests either:

    • The baseline is incorrect (commits 1, 3 are reverting commits that don't exist)
    • The patches haven't been integrated yet (commits 6, 7 are new)
  4. Reverts without baseline — commits 1 and 3 revert commits that are not present in qcom-next/topics, which suggests the baseline is incorrect or the reverts are unnecessary.

Final Summary

  1. Lore link present: Partial — 5/8 commits have lore links (commits 4-8); 3/8 commits are QCLINUX reverts with no lore link expected
  2. Lore link matches PR commits: No — commit 4 merges multiple patches; commits 6-8 have wrong lore links (cover letter instead of individual patches)
  3. Upstream patch status: ⏳ Decision Pending — all FROMLIST commits have review tags but no merge confirmation yet
  4. PR present in qcom-next/topics: Fail — 4/8 commits missing from both qcom-next and topics (per integration_presence_report.md)

[/VALIDATE_PATCH_REPORT]

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/8 [PATCH 1/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/8 [PATCH 2/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
3/8 [PATCH 3/8] QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/8 [PATCH 4/8] FROMLIST: arm64: dts: qcom: Add support for usb nodes on partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
5/8 [PATCH 5/8] FROMLIST: arm64: dts: qcom: Enable USB controllers on partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
6/8 [PATCH 6/8] FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
7/8 [PATCH 7/8] FROMLIST: usb: typec: ucsi: ccg: Add support for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/8 [PATCH 8/8] FROMLIST: arm64: dts: qcom: shikra: Wire up partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: FAIL
present_commits: 2/8
partial_commits: 2/8
missing_commits: 4/8
topics_checked_for_commits: 8/8
final_summary: PR present in qcom-next/topics: Fail - 4/8 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1062 — checker-log-analyzer

PR: #1062
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34501481653

Checker Result Summary
Checker Result Summary
checkpatch 2 commits with style issues (1084 errors, 1050 warnings in commit 3b93983)
dt-binding-check Passed for 2 binding files
dtb-check Build failure: missing DT labels usb_2 and usb_2_hsphy
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance 6 commits: 3 with content mismatch, 3 missing Link tags
tag-check All commits have valid prefixes (QCLINUX: or FROMLIST:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1062 - USB Type-C support for Shikra platform
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34501481653
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 2 commits with style issues (1084 errors, 1050 warnings in commit 3b93983)
dt-binding-check Passed for 2 binding files
dtb-check Build failure: missing DT labels usb_2 and usb_2_hsphy
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance 6 commits: 3 with content mismatch, 3 missing Link tags
tag-check All commits have valid prefixes (QCLINUX: or FROMLIST:)

❌ checkpatch

Root cause: Commit 3b93983 contains massive whitespace/indentation errors (spaces instead of tabs) and commit 5c2e4d9 mixes DT binding with DTS changes.

Failure details:

Commit 3b93983 ("FROMLIST: ccg firmware update support for cyacd2"):

ERROR: code indent should use tabs where possible
#188: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:189:
+        u16 row;

WARNING: please, no spaces at the start of a line
#188: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:189:
+        u16 row;

ERROR: space required after that ',' (ctx:VxV)
#3079: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:2597:
+	pr_err("Ak:%s called##########################\n",__func__);

WARNING: From:/Signed-off-by: email address mismatch:
'From: Akash Kumar <akash.kumar@oss.qualcomm.com>' != 
'Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>'

3b93983fcb5e total: 1084 errors, 1050 warnings, 22 checks, 3132 lines checked

Commit 5c2e4d9 ("FROMLIST: arm64: dts: qcom: shikra: Add gpio-hog for VBUS boost 5V enable"):

WARNING: DT binding docs and includes should be a separate patch.
5c2e4d9d080e total: 0 errors, 1 warnings, 0 checks, 111 lines checked

Fix:

For commit 3b93983:

  1. Run sed -i 's/^ /\t/' drivers/usb/typec/ucsi/ucsi_ccg.c to convert leading spaces to tabs
  2. Fix spacing: pr_err("Ak:%s called##########################\n", __func__);
  3. Fix email mismatch: Use consistent email in both From: and Signed-off-by: (either both @oss.qualcomm.com or both @qti.qualcomm.com)
  4. Remove debug pr_err statements with "Ak:" prefix

For commit 5c2e4d9:

  • If this commit adds a new DT binding file, split it into two patches: one for the binding, one for the DTS changes

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 4d6b63aab099..5c2e4d9d080e

❌ dtb-check

Root cause: DTS files reference undefined labels usb_2 and usb_2_hsphy that were removed by the revert commits but are still referenced in shikra-evk.dtsi.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/shikra-evk.dtsi:49.1-7 Label or path usb_2 not found
Error: ../arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:735.1-7 Label or path usb_2 not found
Error: ../arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:745.1-13 Label or path usb_2_hsphy not found
Error: ../arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:877.1-7 Label or path usb_2 not found
Error: ../arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:887.1-13 Label or path usb_2_hsphy not found
FATAL ERROR: Syntax error parsing input tree

Fix:

The PR reverts previous USB commits (patches 1-3) but leaves dangling references in shikra-evk.dtsi:49. Either:

  1. Option A: Remove or comment out the usb_2 and usb_2_hsphy references in shikra-evk.dtsi at line 49 and in the board-specific DTS files
  2. Option B: Ensure the new USB node definitions (added in patches 4-5) define these labels with the correct names

The issue is that the revert removed the USB node definitions, but the board files still try to reference them.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb

❌ check-patch-compliance

Root cause: Three commits have content differences from their upstream lore links, and three commits are missing Link: tags entirely.

Failure details:

Content mismatch (3 commits):

Checking commit: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Change is different from the one mentioned in Link

Checking commit: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Change is different from the one mentioned in Link

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Change is different from the one mentioned in Link

Missing Link (3 commits):

Checking commit: FROMLIST: ccg firmware update support for cyacd2
No 'Link' found in commit message

Checking commit: FROMLIST: pinctrl: qcom: shikra: Set intr_target_width for GPIO pingroups
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add gpio-hog for VBUS boost 5V enable
No 'Link' found in commit message

Fix:

For commits with content mismatch:

  1. Fetch the upstream patch: b4 am --single-message -C -l -3 <link> -o /tmp/out
  2. Compare the diff to identify what changed
  3. Either: (a) revert to match upstream exactly, or (b) document the adaptation in the commit message with a note like "Adapted for qcom-6.18.y: "

For commits missing Link:

  1. If these patches are posted to lore.kernel.org, add Link: https://lore.kernel.org/... to the commit body
  2. If not posted yet, either:
    • Post them upstream first, then add the Link
    • Change prefix from FROMLIST: to PENDING: (but note: PENDING: will still fail this checker)
    • Change prefix to QCLINUX: if they are vendor-only (but note: QCLINUX: will also fail this checker)

Note: The checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT: prefixes. Vendor-only prefixes like QCLINUX: and PENDING: will always fail this check — this is a known limitation.

Reproduce locally:

b4 am --single-message -C -l -3 <link-from-commit-message>

Verdict

3 blockers must be fixed before merge:

  1. dtb-check failure — Build is broken due to missing DT labels. This is a hard blocker that prevents the kernel from building.

  2. checkpatch commit 3b93983 — 1084 errors and 1050 warnings due to spaces instead of tabs throughout the entire file. This must be fixed.

  3. check-patch-compliance — 6 commits failing: 3 with content mismatch (verify changes are intentional and document them), 3 missing Link tags (add lore.kernel.org links or adjust prefix).

Non-blockers:

  • checkpatch commit 5c2e4d9 (DT binding split warning) — minor, can be addressed if splitting the patch
  • check-patch-compliance for QCLINUX: prefixed commits — these will always fail the checker; this is expected for vendor-only changes

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1062

PR: #1062
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34502994138

# Error File:Line PR-introduced? Root Cause
1 Label or path usb_2 not found shikra-evk.dtsi:49 Yes Patch 4 fails to add usb_2 node definition to shikra.dtsi, but patch 5 adds &usb_2 reference
2 Label or path usb_2 not found shikra-cqm-evk.dts:812 Yes Patch 8 adds &usb_2 reference, but node definition missing due to patch 4 failure
3 Label or path usb_2_hsphy not found shikra-cqm-evk.dts:822 Yes Patch 5 adds &usb_2_hsphy reference, but node definition missing due to patch 4 failure
4 Label or path usb_2 not found shikra-cqs-evk.dts:735 Yes Patch 8 adds &usb_2 reference, but node definition missing due to patch 4 failure
5 Label or path usb_2_hsphy not found shikra-cqs-evk.dts:745 Yes Patch 5 adds &usb_2_hsphy reference, but node definition missing due to patch 4 failure
6 Label or path usb_2 not found shikra-iqs-evk.dts:877 Yes Patch 8 adds &usb_2 reference, but node definition missing due to patch 4 failure
7 Label or path usb_2_hsphy not found shikra-iqs-evk.dts:887 Yes Patch 5 adds &usb_2_hsphy reference, but node definition missing due to patch 4 failure

Verdict

All 7 errors are introduced by this PR due to patch application failure. Patch 4 fails to add USB node definitions to shikra.dtsi, causing all subsequent patches that reference these nodes to fail during DTS compilation.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1062

PR: #1062
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34502994138

# Error File:Line PR-introduced? Root Cause
1 Label or path usb_2 not found shikra-evk.dtsi:49 Yes PR adds reference to &usb_2 in shikra-evk.dtsi but the usb_2 node definition is missing from shikra.dtsi
2 Label or path usb_2 not found shikra-cqm-evk.dts:812 Yes PR adds reference to &usb_2 in shikra-cqm-evk.dts but the usb_2 node definition is missing from shikra.dtsi
3 Label or path usb_2_hsphy not found shikra-cqm-evk.dts:822 Yes PR adds reference to &usb_2_hsphy in shikra-cqm-evk.dts but the usb_2_hsphy node definition is missing from shikra.dtsi
4 Label or path usb_2 not found shikra-cqs-evk.dts:735 Yes PR adds reference to &usb_2 in shikra-cqs-evk.dts but the usb_2 node definition is missing from shikra.dtsi
5 Label or path usb_2_hsphy not found shikra-cqs-evk.dts:745 Yes PR adds reference to &usb_2_hsphy in shikra-cqs-evk.dts but the usb_2_hsphy node definition is missing from shikra.dtsi
6 Label or path usb_2 not found shikra-iqs-evk.dts:877 Yes PR adds reference to &usb_2 in shikra-iqs-evk.dts but the usb_2 node definition is missing from shikra.dtsi
7 Label or path usb_2_hsphy not found shikra-iqs-evk.dts:887 Yes PR adds reference to &usb_2_hsphy in shikra-iqs-evk.dts but the usb_2_hsphy node definition is missing from shikra.dtsi

Verdict

All 7 DTC errors are introduced by this PR. The PR adds references to usb_2 and usb_2_hsphy device tree nodes in multiple board files, but fails to include the corresponding node definitions in arch/arm64/boot/dts/qcom/shikra.dtsi.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1062

PR: #1062
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34508066766

# Error File:Line PR-introduced? Root Cause
1 Label or path usb_2 not found arch/arm64/boot/dts/qcom/shikra-evk.dtsi:49 Yes Patch 4 failed to add usb_2 node to shikra.dtsi due to patch context mismatch after reverts in patches 1-3
2 Label or path usb_2 not found arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:812 Yes Same root cause: usb_2 node missing from shikra.dtsi
3 Label or path usb_2_hsphy not found arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:822 Yes Patch 4 failed to add usb_2_hsphy node to shikra.dtsi
4 Label or path usb_2 not found arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:735 Yes Same root cause: usb_2 node missing from shikra.dtsi
5 Label or path usb_2_hsphy not found arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:745 Yes Same root cause: usb_2_hsphy node missing from shikra.dtsi
6 Label or path usb_2 not found arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:877 Yes Same root cause: usb_2 node missing from shikra.dtsi
7 Label or path usb_2_hsphy not found arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:887 Yes Same root cause: usb_2_hsphy node missing from shikra.dtsi

Verdict

All 7 DTS compilation errors are introduced by this PR due to a patch series ordering issue where patch 4 fails to apply after the reverts in patches 1-3.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1062

PR: #1062
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34508066766

# Error File:Line PR-introduced? Root Cause
1 Label or path usb_2 not found shikra-evk.dtsi:49 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
2 Label or path usb_2 not found shikra-cqm-evk.dts:812 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
3 Label or path usb_2_hsphy not found shikra-cqm-evk.dts:822 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing
4 Label or path usb_2 not found shikra-cqs-evk.dts:735 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
5 Label or path usb_2_hsphy not found shikra-cqs-evk.dts:745 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing
6 Label or path usb_2 not found shikra-iqs-evk.dts:877 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
7 Label or path usb_2_hsphy not found shikra-iqs-evk.dts:887 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing

Verdict

All 7 DTC errors are introduced by this PR. Patch 4 should add usb_2 and usb_2_hsphy nodes to shikra.dtsi, but these definitions are not present when the device tree compiler runs, causing all references in patch 5 to fail.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1062 — validate-patch

PR: #1062

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes for commits 4-8 (FROMLIST); No for commits 1-3 (QCLINUX vendor-only, no lore link expected)
  2. Lore link matches PR commits: No — Commit 4/8 contains extra pinctrl change not present in any referenced lore patch
  3. Upstream patch status: ✅ ACKed for commits 4-5 (v7 series) and v6 PHY series; ✅ ACKed for commits 6-7; ⏳ Decision Pending for commit 8
  4. PR present in qcom-next/topics: Fail - 4/8 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: [#1062] Add USB support for Shikra platforms (8 commits)
Upstream commits: Multiple lore.kernel.org series (see per-commit analysis below)
Verdict:FAIL


Summary

This PR contains 8 commits: 3 vendor-only QCLINUX: revert commits (1-3) and 5 FROMLIST: commits (4-8) that reference upstream lore.kernel.org patches. The validation reveals critical issues in commit 4/8 that must be corrected before merge.


Per-Commit Analysis

Commit 1/8: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"

Check Status Note
Lore link present No lore link expected — QCLINUX: vendor-only revert
Lore link matches PR commits N/A No lore link to compare against
Upstream patch status N/A Vendor-only change, not posted upstream
PR present in qcom-next/topics ⚠️ Missing Not found in qcom-next or topics

Verdict:PASS — Vendor-only revert commit; no lore validation required.


Commit 2/8: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"

Check Status Note
Lore link present No lore link expected — QCLINUX: vendor-only revert
Lore link matches PR commits N/A No lore link to compare against
Upstream patch status N/A Vendor-only change, not posted upstream
PR present in qcom-next/topics Present Found in topics

Verdict:PASS — Vendor-only revert commit; no lore validation required.


Commit 3/8: QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"

Check Status Note
Lore link present No lore link expected — QCLINUX: vendor-only revert
Lore link matches PR commits N/A No lore link to compare against
Upstream patch status N/A Vendor-only change, not posted upstream
PR present in qcom-next/topics ⚠️ Missing Not found in qcom-next or topics

Verdict:PASS — Vendor-only revert commit; no lore validation required.


Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra

Lore links:

Commit Message
Check Status Note
Subject matches upstream Matches lore v7 1/2 subject (with FROMLIST: prefix added)
Body preserves rationale Body text matches lore patch
Fixes tag present/correct N/A No Fixes tag in lore or PR
Authorship preserved From: Krishna Kurapati matches lore author
Backport note N/A Not a backport
Reviewed-by tags Preserved from lore
Diff Comparison
File Status Notes
Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml Matches lore v6 2/4
arch/arm64/boot/dts/qcom/shikra.dtsi Matches lore v7 1/2
drivers/phy/qualcomm/phy-qcom-qmp-usbc.c Matches lore v6 4/4
drivers/pinctrl/qcom/pinctrl-shikra.c FAIL Extra content — NOT present in any lore patch
Upstream Patch Status
Commit Community Verdict
v7 1/2: arm64: dts: qcom: Add support for usb nodes on Shikra ACKed — Reviewed-by from Konrad Dybcio and Manivannan Sadhasivam
v6 2/4: dt-bindings: phy: qcs615-qmp-usb3dp: Add support ACKed — "Applied, thanks!" from maintainer Vinod Koul
v6 4/4: phy: qcom: qmp-usbc: Add qmp configuration ACKed — "Applied, thanks!" from maintainer Vinod Koul
Issues Found
  1. ❌ CRITICAL: Extra pinctrl change with no lore attribution

    The PR adds this change to drivers/pinctrl/qcom/pinctrl-shikra.c:

    +		.intr_target_width = 4,		\

    This line is NOT present in any of the three lore patches referenced in the commit message. The lore patches only touch:

    • arch/arm64/boot/dts/qcom/shikra.dtsi (v7 1/2)
    • Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml (v6 2/4)
    • drivers/phy/qualcomm/phy-qcom-qmp-usbc.c (v6 4/4)

    Root cause: This commit incorrectly combines content from multiple lore series (v7 USB DT + v6 PHY driver) plus an undocumented pinctrl change that has no upstream lore source.

  2. ⚠️ WARNING: Commit combines multiple lore patches

    The commit message references two lore series but does not clearly document that it is squashing:

    • v7 1/2 (DT changes)
    • v6 2/4 (binding)
    • v6 4/4 (PHY driver)

    While combining related patches is sometimes acceptable, the commit message should explicitly state this is a squash/combination.

PR present in qcom-next/topics

⚠️ Partial — Subject or partial tree evidence found, but full change was not verified (likely due to the extra pinctrl content).

Verdict

FAIL — The pinctrl change (intr_target_width = 4) has no lore attribution and must be either:

  1. Removed from this commit and submitted as a separate QCLINUX: or PENDING: commit with proper justification, OR
  2. Documented with a lore link if it exists upstream (none found in the provided lore evidence).

Additionally, the commit message should clarify that it combines v7 1/2 + v6 2/4 + v6 4/4.


Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms

Lore link: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ (v7 2/2)

Commit Message
Check Status Note
Subject matches upstream Matches lore v7 2/2 subject (with FROMLIST: prefix added)
Body preserves rationale Body text matches lore patch
Fixes tag present/correct N/A No Fixes tag in lore or PR
Authorship preserved From: Krishna Kurapati matches lore author
Backport note N/A Not a backport
Reviewed-by tags Preserved from lore
Diff
File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts Matches lore v7 2/2
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts Matches lore v7 2/2
arch/arm64/boot/dts/qcom/shikra-evk.dtsi Matches lore v7 2/2
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts Matches lore v7 2/2
Upstream Patch Status

ACKed — Reviewed-by from Manivannan Sadhasivam and Dmitry Baryshkov

PR present in qcom-next/topics

Present — All checked added lines are present in topics

Verdict

PASS — Faithful representation of lore v7 2/2.


Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller

Lore link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ (part of 0/3 series)

Commit Message
Check Status Note
Subject matches upstream Matches lore patch subject (with FROMLIST: prefix added)
Body preserves rationale Body text matches lore patch
Fixes tag present/correct N/A No Fixes tag in lore or PR
Authorship preserved From: Akash Kumar matches lore author
Backport note N/A Not a backport
Diff
File Status Notes
Documentation/devicetree/bindings/usb/cypress,cypd6129.yaml Matches lore patch
Upstream Patch Status

ACKed — Acked-by from Conor Dooley (DT binding maintainer)

PR present in qcom-next/topics

⚠️ Missing — Not found in qcom-next or topics

Verdict

PASS — Faithful representation of lore patch. Missing from qcom-next/topics is expected for recent patches.


Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229

Lore link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ (part of 0/3 series)

Commit Message
Check Status Note
Subject matches upstream Matches lore patch subject (with FROMLIST: prefix added)
Body preserves rationale Body text matches lore patch
Fixes tag present/correct N/A No Fixes tag in lore or PR
Authorship preserved From: Akash Kumar matches lore author
Backport note N/A Not a backport
Reviewed-by tags Preserved from lore (Abel Vesa)
Diff
File Status Notes
drivers/usb/typec/ucsi/ucsi_ccg.c Matches lore patch
Upstream Patch Status

ACKed — Reviewed-by from Abel Vesa

PR present in qcom-next/topics

⚠️ Missing — Not found in qcom-next or topics

Verdict

PASS — Faithful representation of lore patch. Missing from qcom-next/topics is expected for recent patches.


Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports

Lore link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ (part of 0/3 series)

Commit Message
Check Status Note
Subject matches upstream Matches lore patch subject (with FROMLIST: prefix added)
Body preserves rationale Body text matches lore patch
Fixes tag present/correct N/A No Fixes tag in lore or PR
Authorship preserved From: Akash Kumar matches lore author
Backport note N/A Not a backport
Diff
File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts Matches lore patch
arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi Matches lore patch
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts Matches lore patch
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts Matches lore patch
Upstream Patch Status

Decision Pending — Patch posted on 2026-08-20; has Acked-by/Reviewed-by tags but no explicit "applied" confirmation yet

PR present in qcom-next/topics

⚠️ Partial — Subject or partial tree evidence found, but full change was not verified

Verdict

PASS — Faithful representation of lore patch.


Overall Issues

  1. ❌ CRITICAL (Commit 4/8): Extra pinctrl change (drivers/pinctrl/qcom/pinctrl-shikra.c) with no lore attribution — must be removed or documented with a lore link.

  2. ⚠️ WARNING (Commit 4/8): Commit combines multiple lore patches (v7 1/2 + v6 2/4 + v6 4/4) without clearly documenting this in the commit message.

  3. ⚠️ INFO (Commits 1, 3, 6, 7): Four commits are missing from qcom-next/topics. For vendor-only reverts (1, 3), this is expected. For FROMLIST commits (6, 7), this may indicate they are recent and not yet integrated.


Recommendation

❌ DO NOT MERGE until commit 4/8 is corrected:

  1. Remove the pinctrl change from commit 4/8 and submit it as a separate commit with proper prefix (QCLINUX: or PENDING:) and justification, OR provide a lore link if it exists upstream.

  2. Update the commit message for commit 4/8 to clarify that it combines:

    • v7 1/2: DT nodes for USB controllers
    • v6 2/4: Binding update for qcs615-qmp-usb3dp-phy
    • v6 4/4: PHY driver configuration
  3. After correction, re-run validation to ensure all content has proper lore attribution.


Final Summary

  1. Lore link present: Yes for commits 4-8 (FROMLIST); No for commits 1-3 (QCLINUX vendor-only, no lore link expected)
  2. Lore link matches PR commits: No — Commit 4/8 contains extra pinctrl change not present in any referenced lore patch
  3. Upstream patch status: ✅ ACKed for commits 4-5 (v7 series) and v6 PHY series; ✅ ACKed for commits 6-7; ⏳ Decision Pending for commit 8
  4. PR present in qcom-next/topics: Fail — 4/8 commits are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/8 [PATCH 1/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/8 [PATCH 2/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
3/8 [PATCH 3/8] QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/8 [PATCH 4/8] FROMLIST: arm64: dts: qcom: Add support for usb nodes on partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
5/8 [PATCH 5/8] FROMLIST: arm64: dts: qcom: Enable USB controllers on partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
6/8 [PATCH 6/8] FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
7/8 [PATCH 7/8] FROMLIST: usb: typec: ucsi: ccg: Add support for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/8 [PATCH 8/8] FROMLIST: arm64: dts: qcom: shikra: Wire up partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: FAIL
present_commits: 2/8
partial_commits: 2/8
missing_commits: 4/8
topics_checked_for_commits: 8/8
final_summary: PR present in qcom-next/topics: Fail - 4/8 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1062 — checker-log-analyzer

PR: #1062
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34508075813

Checker Result Summary
Checker Result Summary
checkpatch 2 commits with style issues (1084 errors, 1050 warnings in commit 224d138)
dt-binding-check DTS compilation failure - missing USB node labels
dtb-check DTS compilation failure - missing USB node labels
sparse-check Passed (pre-existing vdso warning unrelated to PR)
check-uapi-headers Passed - no UAPI changes
check-patch-compliance 6 commits with content mismatch + 1 author mismatch
tag-check ⚠️ 3 commits use QCLINUX: prefix (checker limitation)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1062 - USB Type-C support for Shikra platform
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34508075813
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 2 commits with style issues (1084 errors, 1050 warnings in commit 224d138)
dt-binding-check DTS compilation failure - missing USB node labels
dtb-check DTS compilation failure - missing USB node labels
sparse-check Passed (pre-existing vdso warning unrelated to PR)
check-uapi-headers Passed - no UAPI changes
check-patch-compliance 6 commits with content mismatch + 1 author mismatch
tag-check ⚠️ 3 commits use QCLINUX: prefix (checker limitation)

❌ checkpatch — Commit 224d138

Root cause: Massive whitespace/indentation errors (spaces instead of tabs), debug print statements left in code, and email mismatch.

Failure details:

Commit 224d138234e1 ("FROMLIST: ccg firmware update support for cyacd2")
total: 1084 errors, 1050 warnings, 22 checks, 3132 lines checked

ERROR: code indent should use tabs where possible
#189: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:189:
+        u16 row;$

WARNING: please, no spaces at the start of a line
(repeated 1000+ times throughout the file)

ERROR: space required after that ',' (ctx:VxV)
#3080: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:2597:
+	pr_err("Ak:%s called##########################\n",__func__);

ERROR: space required after that ',' (ctx:VxV)
#3167: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:2704:
+	pr_err("Ak:%s done status:%d\n",__func__, status);

WARNING: From:/Signed-off-by: email address mismatch:
  'From: Akash Kumar <akash.kumar@oss.qualcomm.com>'
  'Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>'

Fix:

  1. Whitespace: Run ./scripts/checkpatch.pl --fix-inplace or manually convert all leading spaces to tabs in drivers/usb/typec/ucsi/ucsi_ccg.c
  2. Debug prints: Remove the two pr_err("Ak:... debug statements at lines 2597 and 2704
  3. Email mismatch: Amend commit author to match From: line:
    git rebase -i <base>  # mark 224d138 as 'edit'
    git commit --amend --author="Akash Kumar <akash.kumar@oss.qualcomm.com>"
    git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a5e10512c6df..76b745a3695c

❌ checkpatch — Commit 76b745a

Root cause: DT binding and include file should be in a separate patch per kernel submission guidelines.

Failure details:

Commit 76b745a3695c ("FROMLIST: arm64: dts: qcom: shikra: Add gpio-hog for VBUS boost 5V enable")
WARNING: DT binding docs and includes should be a separate patch.
  See: Documentation/devicetree/bindings/submitting-patches.rst
total: 0 errors, 1 warnings, 0 checks, 111 lines checked

Fix:
This is a guideline warning for upstream submission. If the patch includes both binding changes and DTS usage, split into two commits. However, reviewing the patch context, this appears to be a false positive (likely triggered by include file changes). Verify the patch content and split only if binding YAML changes are present.

Reproduce locally:

./scripts/checkpatch.pl --strict --git 4a9fa9b2c54c..76b745a3695c

❌ dt-binding-check / dtb-check — DTS Compilation Failure

Root cause: DTS files reference USB node labels (usb_2, usb_2_hsphy) that don't exist in the tree after the revert commits.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/shikra-evk.dtsi:49.1-7 Label or path usb_2 not found
Error: ../arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:812.1-7 Label or path usb_2 not found
Error: ../arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:822.1-13 Label or path usb_2_hsphy not found
Error: ../arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:735.1-7 Label or path usb_2 not found
Error: ../arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:877.1-7 Label or path usb_2 not found
FATAL ERROR: Syntax error parsing input tree

Fix:
The first 3 commits in the PR revert previous USB patches, removing the usb_2 and usb_2_hsphy node definitions. However, the board DTS files (shikra-evk.dtsi, shikra-cqm-evk.dts, shikra-cqs-evk.dts, shikra-iqs-evk.dts) still reference these labels.

Two options:

  1. Remove the references: Update all board DTS files to remove &usb_2 and &usb_2_hsphy references
  2. Reorder commits: Apply the new USB patches (commits 4-8) before the reverts, or don't revert the base USB nodes

The current commit order creates a broken intermediate state. Recommend reordering: apply new USB support first, then revert only the conflicting parts if needed.

Reproduce locally:

make O=out defconfig
make O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-evk.dtb

❌ check-patch-compliance — Content Mismatch (6 commits)

Root cause: All 6 FROMLIST: commits have differences from their upstream lore.kernel.org links.

Failure details:

Checking commit: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Change is different from the one mentioned in Link

Checking commit: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Change is different from the one mentioned in Link

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Change is different from the one mentioned in Link

Checking commit: FROMLIST: ccg firmware update support for cyacd2
Change is different from the one mentioned in Link

Checking commit: FROMLIST: pinctrl: qcom: shikra: Set intr_target_width for GPIO pingroups
Change is different from the one mentioned in Link

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add gpio-hog for VBUS boost 5V enable
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Akash Kumar <akash.kumar@oss.qualcomm.com>
  Commit author : Akash Kumar <akakum@qti.qualcomm.com>

Fix:
For each commit, fetch the upstream patch and compare:

# Example for one commit:
b4 am --single-message -C -l -3 <Link-URL> -o /tmp/upstream
git format-patch -1 <commit-sha> --stdout > /tmp/local.patch
diff <(grep -E '^[+-][^+-]' /tmp/local.patch) <(grep -E '^[+-][^+-]' /tmp/upstream/*.mbx)

Classify each difference:

  • Context-only shift: Acceptable (different base)
  • Legitimate adaptation: Document in commit message (e.g., "Adapted for qcom tree")
  • Missing/extra hunks: Add missing changes or split extra changes into separate commits
  • Whitespace/formatting: Fix to match upstream (especially commit 224d138)

The author mismatch in the last commit must be fixed (see checkpatch section above).

Reproduce locally:

cd kernel-checkers
./check-patch-compliance.sh --kernel-src <path> --base <base> --head <head>

⚠️ tag-check — QCLINUX Prefix (Known Limitation)

Root cause: 3 commits use QCLINUX: prefix, which is not accepted by check-patch-compliance but is valid for vendor-only changes.

Commits:

  1. QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes..."
  2. QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB..."
  3. QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec..."

Analysis:
These are revert commits for vendor-specific changes. The QCLINUX: prefix is appropriate for vendor-only work. However, check-patch-compliance only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Note: Revert commits should themselves carry a prefix before the word Revert. The current format QCLINUX: Revert "..." is correct per tag-check rules, but will always fail check-patch-compliance. This is a known checker limitation for vendor-only commits.

No action required — this is expected behavior for vendor-only reverts.


Verdict

❌ CRITICAL BLOCKERS — Cannot merge as-is

Must fix before merge:

  1. DTS compilation failure — Reorder commits or remove dangling USB node references
  2. Commit 224d138 — Fix 1084 errors + 1050 warnings (whitespace, debug prints, email)
  3. Content mismatches — Verify all 6 FROMLIST: commits match upstream or document adaptations
  4. Author mismatch — Fix email in commit 76b745a

Recommended workflow:

  1. Fix commit 224d138 whitespace with checkpatch.pl --fix-inplace
  2. Remove debug pr_err("Ak:... statements
  3. Fix author email mismatch
  4. Reorder commits to avoid broken intermediate state (apply new USB support before reverts)
  5. Verify content matches upstream or add adaptation notes to commit messages
  6. Re-run CI

@sgaud-quic

Copy link
Copy Markdown
Contributor

🔨 Build Failure Analysis — PR #1062

PR: #1062 Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34508066766

Error File:Line PR-introduced? Root Cause

1 Label or path usb_2 not found shikra-evk.dtsi:49 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
2 Label or path usb_2 not found shikra-cqm-evk.dts:812 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
3 Label or path usb_2_hsphy not found shikra-cqm-evk.dts:822 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing
4 Label or path usb_2 not found shikra-cqs-evk.dts:735 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
5 Label or path usb_2_hsphy not found shikra-cqs-evk.dts:745 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing
6 Label or path usb_2 not found shikra-iqs-evk.dts:877 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
7 Label or path usb_2_hsphy not found shikra-iqs-evk.dts:887 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing

Verdict

All 7 DTC errors are introduced by this PR. Patch 4 should add usb_2 and usb_2_hsphy nodes to shikra.dtsi, but these definitions are not present when the device tree compiler runs, causing all references in patch 5 to fail.

📎 Detailed analysis: Full report

Build failed, please check this Akash Kumar (@akakum-oss)

Kriskura176767 and others added 4 commits September 16, 2026 11:31
On Shikra CQS/CQM  platforms, usb-role-switch is handled by PM4125 on
primary Type-C port and Cypress PD controller CYPD6129 on second Type-C
port. On Shikra IQS platform, usb-role-switch is handled by Cypress PD
controller CYPD6129 on both Type-C ports.

Since those changes are not yet present, enabling both USB controllers
in device mode.

Link: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
…roller

Add the device-tree binding documentation for the Cypress cypd6129
and cypd6229 dual Type-C PD controllers. These are used on Shikra
CQM/CQS/IQS platforms to handle usb-role-switch for the USB Type-C
ports over an I2C interface, similarly to the existing cypd4226
binding.

cypd6229 is a variant of cypd6129 and is described with a
"cypress,cypd6129" fallback compatible string.

Link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
Add cypd6129 and cypd6229 compatible strings to the of_device_id
match table so the driver binds to boards describing these Cypress
PD controllers in their device tree. No other driver changes are
needed since the chip is accessed through the same generic UCSI/HPI
I2C register protocol as the existing cypd4226 support.

Link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
…ype-C ports

On Shikra CQS/CQM platforms, usb-role-switch is handled by PM4125 on
the primary Type-C port and Cypress PD controller CYPD6129 on the
second Type-C port. On Shikra IQS platform, usb-role-switch is
handled by Cypress PD controller CYPD6129 on both Type-C ports.

Add the CYPD6129 typec node under i2c3, wire its connector endpoints
to the corresponding DWC3 controller ports via remote-endpoint
phandles, and switch the associated USB controllers to OTG mode so
role switching can take effect.

Link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
@akakum-qualcomm

Copy link
Copy Markdown
Author

🔨 Build Failure Analysis — PR #1062

PR: #1062 Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34508066766

Error File:Line PR-introduced? Root Cause

1 Label or path usb_2 not found shikra-evk.dtsi:49 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
2 Label or path usb_2 not found shikra-cqm-evk.dts:812 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
3 Label or path usb_2_hsphy not found shikra-cqm-evk.dts:822 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing
4 Label or path usb_2 not found shikra-cqs-evk.dts:735 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
5 Label or path usb_2_hsphy not found shikra-cqs-evk.dts:745 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing
6 Label or path usb_2 not found shikra-iqs-evk.dts:877 Yes Patch 5 references &usb_2 but patch 4's definition in shikra.dtsi is missing
7 Label or path usb_2_hsphy not found shikra-iqs-evk.dts:887 Yes Patch 5 references &usb_2_hsphy but patch 4's definition in shikra.dtsi is missing

Verdict

All 7 DTC errors are introduced by this PR. Patch 4 should add usb_2 and usb_2_hsphy nodes to shikra.dtsi, but these definitions are not present when the device tree compiler runs, causing all references in patch 5 to fail.
📎 Detailed analysis: Full report

Build failed, please check this Akash Kumar (Akash Kumar (@akakum-oss))

resolved, was coming due to bam dmux change please check now.

@qcomlnxci
qcomlnxci requested a review from a team September 16, 2026 06:08
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️ ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@qlijarvis

Copy link
Copy Markdown

PR #1062 — validate-patch

PR: #1062

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes for commits 4-8 (FROMLIST:); No for commits 1-3 (QCLINUX: — no lore link expected or required)

  2. Lore link matches PR commits: No — Commits 4/8 and 8/8 contain extra content from multiple lore series or undocumented vendor additions; commits must be split to match lore patches 1:1

  3. Upstream patch status: ⏳ Decision Pending for all three lore series — patches have positive review signals (Reviewed-by/Acked-by) but no merge confirmation yet; likely queued in maintainer tree

  4. PR present in qcom-next/topics: Fail - 3/8 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1062 - "Add USB support for Shikra platforms"
Upstream commits: Multiple lore.kernel.org series (see per-commit analysis below)
Verdict: ❌ FAIL


Summary by Commit

Commit 1/8: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"

Check Status Note
Lore link required QCLINUX: prefix — no lore link expected
Commit message Clear revert rationale provided
Authorship Akash Kumar (submitter)

Verdict: ✅ PASS — QCLINUX: vendor-only revert, no upstream validation required.


Commit 2/8: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"

Check Status Note
Lore link required QCLINUX: prefix — no lore link expected
Commit message Clear revert rationale provided
Authorship Akash Kumar (submitter)

Verdict: ✅ PASS — QCLINUX: vendor-only revert, no upstream validation required.


Commit 3/8: QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"

Check Status Note
Lore link required QCLINUX: prefix — no lore link expected
Commit message Detailed revert rationale with specific node/endpoint changes listed
Authorship Akash Kumar (submitter)

Verdict: ✅ PASS — QCLINUX: vendor-only revert, no upstream validation required.


Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra

Lore links:

Check Status Note
Subject matches upstream Matches lore v7 1/2 subject
Body preserves rationale Minimal body preserved ("Add support for both USB controllers...")
Fixes tag present/correct N/A Not a fix
Authorship preserved FAIL: From: Krishna Kurapati but Signed-off-by: Akash Kumar added
Reviewed-by tags Konrad Dybcio, Manivannan Sadhasivam preserved

Diff Comparison:

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi Matches lore v7 1/2 content
Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml EXTRA: From lore v6 PHY series 2/4, not v7 DT series
drivers/phy/qualcomm/phy-qcom-qmp-usbc.c EXTRA: From lore v6 PHY series 4/4, not v7 DT series
drivers/pinctrl/qcom/pinctrl-shikra.c EXTRA: From lore v6 PHY series 3/4, not v7 DT series

Issues:

  1. ❌ CRITICAL: Mixing two separate lore series into one commit — The PR commit combines content from:

    • lore v7 DT series (20260811-usb-shikra-v7) patch 1/2: shikra.dtsi changes only
    • lore v6 PHY series (20260712-usb-shikra-phy-v6) patches 2/4, 3/4, 4/4: binding, pinctrl, and phy driver changes

    These are two independent upstream patch series that should remain as separate commits in the vendor tree.

  2. ⚠️ WARNING: Authorship — The From: field correctly preserves Krishna Kurapati as the original author, but Akash Kumar added his Signed-off-by: as the submitter. This is acceptable for FROMLIST: commits per the skill rules (submitter may differ from lore author; only the original author's Signed-off-by: must be present). However, the original lore patch does not have Akash Kumar's Signed-off-by:, so this is a minor deviation.

Verdict: ❌ FAIL — Content from two separate lore series must not be squashed into one commit. Split into:

  • Commit A: FROMLIST: lore v7 1/2 (shikra.dtsi only)
  • Commit B: FROMLIST: lore v6 2/4 (binding yaml)
  • Commit C: FROMLIST: lore v6 3/4 (pinctrl)
  • Commit D: FROMLIST: lore v6 4/4 (phy driver)

Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms

Lore link: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ (v7 DT series, patch 2/2)

Check Status Note
Subject matches upstream Matches lore v7 2/2 subject
Body preserves rationale Full body preserved
Fixes tag present/correct N/A Not a fix
Authorship preserved From: Krishna Kurapati (original author)
Reviewed-by tags Manivannan Sadhasivam, Dmitry Baryshkov preserved

Diff Comparison:

File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ⚠️ Context differs — lore patch applies to a different baseline (no prior reverts)
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ⚠️ Context differs — lore patch applies to a different baseline
arch/arm64/boot/dts/qcom/shikra-evk.dtsi ⚠️ Context differs — lore patch applies to a different baseline
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Context differs — lore patch applies to a different baseline
arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Context differs — lore patch applies to a different baseline

Issues:

  1. ⚠️ REVIEW: Context adaptation — The PR commit applies cleanly after the three QCLINUX: reverts (commits 1-3), but the lore patch was written against a different baseline (upstream mainline without the vendor-specific nodes being reverted). The diff content (added lines) appears semantically equivalent, but line numbers and surrounding context differ significantly. This is a legitimate adaptation for a vendor tree that had out-of-tree changes reverted first.

Verdict: ⚠️ PARTIAL — Content is faithful to lore v7 2/2, but context adaptation due to prior reverts should be noted in the commit message (e.g., "Adapted to apply after reverting out-of-tree USB nodes").


Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller

Lore link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ (patch 1/3)

Check Status Note
Subject matches upstream Matches lore patch 1/3 subject
Body preserves rationale Full body preserved
Fixes tag present/correct N/A Not a fix
Authorship preserved From: Akash Kumar (original author)

Diff Comparison:

File Status Notes
Documentation/devicetree/bindings/usb/cypress,cypd6129.yaml Content matches lore patch 1/3

Verdict: ✅ PASS — Faithful representation of lore patch 1/3.


Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229

Lore link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ (patch 2/3)

Check Status Note
Subject matches upstream Matches lore patch 2/3 subject
Body preserves rationale Full body preserved
Fixes tag present/correct N/A Not a fix
Authorship preserved From: Akash Kumar (original author)

Diff Comparison:

File Status Notes
drivers/usb/typec/ucsi/ucsi_ccg.c Content matches lore patch 2/3

Verdict: ✅ PASS — Faithful representation of lore patch 2/3.


Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports

Lore link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ (patch 3/3)

Check Status Note
Subject matches upstream Matches lore patch 3/3 subject
Body preserves rationale Full body preserved
Fixes tag present/correct N/A Not a fix
Authorship preserved From: Akash Kumar (original author)

Diff Comparison:

File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ⚠️ EXTRA CONTENT — PR adds more nodes than lore patch
arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi EXTRA FILE — Not present in lore patch 3/3
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ⚠️ EXTRA CONTENT — PR adds more nodes than lore patch
arch/arm64/boot/dts/qcom/shikra-evk.dtsi EXTRA FILE — Not present in lore patch 3/3
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ EXTRA CONTENT — PR adds more nodes than lore patch

Issues:

  1. ❌ CRITICAL: Extra files and content — The PR commit adds:

    • shikra-cqm-som.dtsi (45 lines): PM4125 typec connector and vbus regulator nodes — not in lore patch 3/3
    • shikra-evk.dtsi (4 lines): i2c3 pinctrl changes — not in lore patch 3/3
    • Extra nodes in the three .dts files beyond what lore patch 3/3 adds

    The lore patch 3/3 only adds the CYPD6129 typec node under i2c3 and wires up the connector endpoints. The PR commit adds additional PM4125 typec/vbus nodes that have no lore attribution.

  2. ❌ FAIL: Undocumented additions — The extra content (PM4125 nodes, i2c3 pinctrl) is not mentioned in the commit message and has no lore link. If this content is vendor-specific or from a different lore series, it must be split into a separate commit with the appropriate prefix (QCLINUX:, PENDING:, or FROMLIST: with its own lore link).

Verdict: ❌ FAIL — Split into:

  • Commit A: FROMLIST: lore patch 3/3 (CYPD6129 typec nodes only, matching lore exactly)
  • Commit B: QCLINUX: or FROMLIST: (with separate lore link) for PM4125 typec/vbus nodes in shikra-cqm-som.dtsi and i2c3 pinctrl in shikra-evk.dtsi

Upstream Patch Status

Lore Series Community Verdict
20260811-usb-shikra-v7 (DT series) Decision Pending — Posted Aug 11, 2026; has Reviewed-by from Konrad Dybcio and Manivannan Sadhasivam; no merge/NAK signal found in thread; last activity Aug 11, 2026
20260712-usb-shikra-phy-v6 (PHY series) Decision Pending — Posted Jul 12, 2026; has review comments from maintainers (Jul 20-22); no merge/NAK signal found in thread; last activity Jul 22, 2026
20260820145036.2035641 (typec series) Decision Pending — Posted Aug 20, 2026; has Acked-by from Conor Dooley and Reviewed-by from Abel Vesa; no merge/NAK signal found in thread; last activity Aug 25, 2026

Note: All three series are recent (Jul-Aug 2026) and have positive review signals (Reviewed-by/Acked-by tags) but no definitive merge confirmation yet. They are likely queued in a maintainer tree but not yet in mainline. The FROMLIST: prefix is appropriate for patches under review.


Integration Presence (qcom-next/topics)

Per integration_presence_report.md:

Commit qcom-next topics Final Status
1/8 (QCLINUX revert) missing missing missing
2/8 (QCLINUX revert) partial present present
3/8 (QCLINUX revert) missing missing missing
4/8 (FROMLIST USB nodes) partial partial ⚠️ partial
5/8 (FROMLIST Enable USB) partial partial ⚠️ partial
6/8 (FROMLIST cypd6129 binding) missing missing missing
7/8 (FROMLIST cypd6129 driver) partial partial ⚠️ partial
8/8 (FROMLIST role-switch) partial partial ⚠️ partial

Overall: ❌ FAIL — 3/8 commits are missing from both qcom-next and topics; 4/8 are partial (subject/partial tree evidence found but full change not verified); only 1/8 is fully present.


Issues

Critical (must fix before merge):

  1. Commit 4/8: Mixing two separate lore series (v7 DT + v6 PHY) into one commit. Split into 4 separate commits, one per lore patch.

  2. Commit 8/8: Extra files (shikra-cqm-som.dtsi, shikra-evk.dtsi) and extra content (PM4125 typec/vbus nodes) not present in the linked lore patch 3/3. Split into two commits: one faithful to lore 3/3, one for the extra vendor-specific content with appropriate prefix and attribution.

  3. Integration presence: 3/8 commits are missing from qcom-next/topics. This PR introduces new content that is not yet in the integration branch, which may cause conflicts or duplication.

Warnings (review recommended):

  1. Commit 5/8: Context adaptation due to prior reverts is legitimate but should be noted in the commit message for clarity.

Verdict

FAIL — Do not merge without corrections.

Required actions:

  1. Split commit 4/8 into 4 separate commits:

    • FROMLIST: lore v7 1/2 (shikra.dtsi USB nodes only)
    • FROMLIST: lore v6 2/4 (qcs615-qmp-usb3dp-phy.yaml binding)
    • FROMLIST: lore v6 3/4 (pinctrl-shikra.c)
    • FROMLIST: lore v6 4/4 (phy-qcom-qmp-usbc.c driver)
  2. Split commit 8/8 into 2 separate commits:

    • FROMLIST: lore patch 3/3 (CYPD6129 typec nodes only, matching lore exactly)
    • QCLINUX: or FROMLIST: (with separate lore link if available) for PM4125 typec/vbus nodes and i2c3 pinctrl
  3. Add context note to commit 5/8 commit message: "Adapted to apply after reverting out-of-tree USB nodes in commits 1-3."

  4. Verify integration presence — Coordinate with the qcom-next maintainer to understand why 3/8 commits are missing from the integration branch. If this PR is intended to introduce new content ahead of qcom-next, document that intent in the PR description.


Final Summary

  1. Lore link present: Yes for commits 4-8 (FROMLIST:); No for commits 1-3 (QCLINUX: — no lore link expected or required)

  2. Lore link matches PR commits: No — Commits 4/8 and 8/8 contain extra content from multiple lore series or undocumented vendor additions; commits must be split to match lore patches 1:1

  3. Upstream patch status: ⏳ Decision Pending for all three lore series — patches have positive review signals (Reviewed-by/Acked-by) but no merge confirmation yet; likely queued in maintainer tree

  4. PR present in qcom-next/topics: Fail — 3/8 commits missing, 4/8 partial, 1/8 present

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/8 [PATCH 1/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/8 [PATCH 2/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
3/8 [PATCH 3/8] QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/8 [PATCH 4/8] FROMLIST: arm64: dts: qcom: Add support for usb nodes on partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
5/8 [PATCH 5/8] FROMLIST: arm64: dts: qcom: Enable USB controllers on partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
6/8 [PATCH 6/8] FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
7/8 [PATCH 7/8] FROMLIST: usb: typec: ucsi: ccg: Add support for partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
8/8 [PATCH 8/8] FROMLIST: arm64: dts: qcom: shikra: Wire up partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: FAIL
present_commits: 1/8
partial_commits: 4/8
missing_commits: 3/8
topics_checked_for_commits: 8/8
final_summary: PR present in qcom-next/topics: Fail - 3/8 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1062 — checker-log-analyzer

PR: #1062
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34696494163

Checker Result Summary
Checker Result Summary
checkpatch 2 commits with style issues
dt-binding-check All binding checks passed
dtb-check Duplicate node names in shikra.dtsi
sparse-check No sparse warnings
check-uapi-headers No UAPI issues
check-patch-compliance 7 commits with compliance failures
tag-check ⚠️ Cannot determine target branch (see notes)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1062 - USB support for Shikra platform
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34696494163

Checker Result Summary
checkpatch 2 commits with style issues
dt-binding-check All binding checks passed
dtb-check Duplicate node names in shikra.dtsi
sparse-check No sparse warnings
check-uapi-headers No UAPI issues
check-patch-compliance 7 commits with compliance failures
tag-check ⚠️ Cannot determine target branch (see notes)

❌ checkpatch

Root cause: Two commits have checkpatch style violations.

Failure details:

Commit 609376a ("QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra""):

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")'
#8: 
introduced by commit 102ec26f93ef3d6010a7693a061bcec8838fc536:

total: 1 errors, 0 warnings, 0 checks

Commit dad722a ("FROMLIST: pinctrl: qcom: shikra: Set intr_target_width for GPIO pingroups"):

WARNING: DT binding docs and includes should be a separate patch.

total: 0 errors, 1 warnings, 0 checks

Fix:

For commit 609376a:

git rebase -i <base_sha>   # mark commit 609376a1ecf3 as 'edit'
# Edit the commit message to use proper format:
# Change: "introduced by commit 102ec26f93ef3d6010a7693a061bcec8838fc536:"
# To: "This reverts commit 102ec26f93ef ("PENDING: arm64: dts: qcom: Add typec role switching changes to shikra")."
git commit --amend
git rebase --continue

For commit dad722a:

  • If this commit modifies both DT binding documentation and driver/DTS files, split into two patches:
    1. First patch: binding documentation changes only
    2. Second patch: driver/DTS implementation
  • If it only touches driver code that happens to include DT headers, this may be a false positive and can be ignored.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

❌ dtb-check

Root cause: Duplicate node definitions in shikra.dtsi causing DTB compilation to fail.

Failure details:

../arch/arm64/boot/dts/qcom/shikra.dtsi:2954.22-3036.5: ERROR (duplicate_node_names): 
  /soc@0/usb@4e00000: Duplicate node name

../arch/arm64/boot/dts/qcom/shikra.dtsi:4924.40-4935.5: ERROR (duplicate_node_names): 
  /soc@0/dma-controller@6044000: Duplicate node name

ERROR: Input tree has errors, aborting (use -f to force output)
make[4]: *** [arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb] Error 2

Fix:

The PR introduces duplicate node definitions for:

  1. usb@4e00000 at lines 2954-3036 (conflicts with existing definition)
  2. dma-controller@6044000 at lines 4924-4935 (conflicts with existing definition)

Resolution steps:

  1. Check if these nodes already exist in shikra.dtsi or included files
  2. If reverting previous commits, ensure the revert is complete and doesn't leave duplicate definitions
  3. If adding new nodes, verify they don't conflict with existing nodes at the same address
  4. Likely cause: The three revert commits (patches 1-3) may not have cleanly reverted all changes, leaving duplicate definitions

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: Multiple compliance failures across 7 commits - prefix violations, invalid lore links, and content mismatches.

Failure details:

1. Commits with invalid prefix (3 commits):

Commit: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Commit: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Commit: QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"

Error: Commit summary does not start with a required prefix

Issue: QCLINUX: is not in the allowed prefix list for check-patch-compliance. The checker only accepts: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:.

Additionally, revert commits must have a prefix before the word Revert.

2. Commits with invalid lore link (2 commits):

Commit: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra
Commit: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms

Error: Something seems wrong with the provided link
Link: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/

Issue: The link points to a cover letter (v7-0) instead of individual patch messages. Each commit needs its own specific lore message ID.

3. Commits with content mismatch (4 commits):

Commit: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Commit: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Commit: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Commit: FROMLIST: pinctrl: qcom: shikra: Set intr_target_width for GPIO pingroups

Error: Change is different from the one mentioned in Link

Issue: The patch content differs from the upstream lore version. This could be due to:

  • Local adaptations/modifications
  • Context differences from rebasing
  • Missing or extra hunks

Fix:

For prefix violations (commits 1-3):

git rebase -i <base_sha>

# For each revert commit, change from:
#   QCLINUX: Revert "FROMLIST: ..."
# To:
#   UPSTREAM: Revert "FROMLIST: ..." 
# or
#   FROMLIST: Revert "FROMLIST: ..."
# (depending on whether the revert itself has been posted upstream)

git commit --amend -m "UPSTREAM: Revert \"FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform\""
git rebase --continue

Note: This is a known limitation of check-patch-compliance - it does not accept QCLINUX: or PENDING: prefixes even though they are valid vendor-internal tags. If these are truly vendor-only changes with no upstream equivalent, the checker will always fail.

For invalid lore links (commits 4-5):

# Find the correct per-patch message IDs from the series:
# Visit: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
# Click on each individual patch to get its message ID
# Update each commit's Link: trailer with the correct message ID

git rebase -i <base_sha>
# mark commit as 'edit'
git commit --amend
# Update the Link: line in the commit message to point to the specific patch message ID
git rebase --continue

For content mismatches (commits 6-9):

# Verify the differences:
b4 am --single-message -C -l -3 <link> -o /tmp/upstream.mbx
git format-patch -1 <sha> --stdout > /tmp/local.patch
diff -u /tmp/upstream.mbx /tmp/local.patch

# If differences are legitimate adaptations (e.g., for vendor tree):
# - Document the changes in the commit message
# - Consider using BACKPORT: prefix instead of FROMLIST:
# - Add a note explaining the modifications

# If differences are unintended:
# - Cherry-pick the clean upstream version
# - Reapply only necessary local changes

Reproduce locally:

# For each commit:
b4 am --single-message -C -l -3 <lore-link> -o /tmp/out
git format-patch -1 <commit-sha> --stdout | diff - /tmp/out/*.mbx

⚠️ tag-check (Subject Prefix Validation)

Status: Cannot definitively determine target branch from available information.

Analysis:

The PR contains commits with the following prefixes:

  • 3 commits: QCLINUX: Revert "..."
  • 5 commits: FROMLIST: ...

Tag-check rules:

  • Applies to: All branches except qcom-next and qcom-next-staging
  • Required: Every commit must start with: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:
  • Revert commits: Must have a prefix before the word Revert

Current status:

  • 3 revert commits fail: QCLINUX: Revert "..." format is invalid - needs prefix before Revert
    • Should be: UPSTREAM: Revert "..." or FROMLIST: Revert "..."
  • 5 FROMLIST commits pass: Valid prefix format

If target branch is NOT qcom-next/qcom-next-staging:
The 3 revert commits need to be fixed:

git rebase -i <base_sha>
# For each revert commit, change:
#   From: QCLINUX: Revert "FROMLIST: ..."
#   To:   UPSTREAM: Revert "FROMLIST: ..."

If target branch IS qcom-next or qcom-next-staging:
Tag-check does not apply - all commits pass.

Recommendation: Verify the target branch with:

gh pr view 1062 --repo qualcomm-linux/kernel --json baseRefName -q .baseRefName

Verdict

❌ CRITICAL BLOCKERS - Cannot merge

Must fix before merge:

  1. dtb-check failure (CRITICAL): Duplicate node definitions prevent DTB compilation

    • Fix duplicate usb@4e00000 node at line 2954
    • Fix duplicate dma-controller@6044000 node at line 4924
    • Root cause: Incomplete reverts in patches 1-3 left duplicate definitions
  2. check-patch-compliance failures (7 commits):

    • Fix revert commit prefix format (3 commits)
    • Update lore links to point to individual patches, not cover letter (2 commits)
    • Resolve content mismatches with upstream (4 commits)
  3. checkpatch failures (2 commits):

    • Fix commit message format in revert commit (1 ERROR)
    • Consider splitting DT binding patch (1 WARNING - may be acceptable)

Summary: 3 critical issues blocking merge. The DTB compilation failure must be resolved first, followed by the compliance and style issues.

@sgaud-quic

Copy link
Copy Markdown
Contributor

Akash Kumar (@akakum-oss) :

Mainline PR is not merged.
Mainline PR have only one commit and this PR is bringing multiple other changes, please share mainline PR for other changes as well

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1062

PR: #1062
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34696491856

# Error File:Line PR-introduced? Root Cause
1 ERROR (duplicate_node_names): /soc@0/usb@4e00000: Duplicate node name arch/arm64/boot/dts/qcom/shikra.dtsi:2954 Yes Patch 4 adds usb_1: usb@4e00000 at ~line 2887, then Patch 5 fails to remove the old instance at ~line 2607, leaving two nodes with the same name and address
2 ERROR (duplicate_node_names): /soc@0/dma-controller@6044000: Duplicate node name arch/arm64/boot/dts/qcom/shikra.dtsi:4924 Yes Patch 4 adds bam_dmux_dma: dma-controller@6044000 at ~line 2597, then Patch 5 fails to remove old instances at ~line 2667 and ~line 4845, leaving multiple nodes with the same name and address

Verdict

Both errors are introduced by this PR due to incorrect patch sequencing that results in duplicate device tree nodes.

📎 Detailed analysis: Full report

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ❌ Fail
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ❌ Fail
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@akakum-qualcomm

Copy link
Copy Markdown
Author

Akash Kumar (Akash Kumar (@akakum-oss)) :

Mainline PR is not merged. Mainline PR have only one commit and this PR is bringing multiple other changes, please share mainline PR for other changes as well

reverts has multiple changes on mainline ,can't revert cleanly, so applied cypd enablement changes only directly on mainline.

@qlijarvis

Copy link
Copy Markdown

PR #1062 — validate-patch

PR: #1062

Verdict Issues Detailed Report
⚠️ 12 Full report

Final Summary

  1. Lore link present: Yes for commits 4-8; No (expected) for commits 1-3 (QCLINUX)
  2. Lore link matches PR commits: Partial — commit 4/8 conflates two series; commits 6-8 link to v1 instead of v2
  3. Upstream patch status: ✅ ACKed (commits 4-5 with Reviewed-by tags); ⏳ Decision Pending (commits 6-8, v1 superseded by v2)
  4. PR present in qcom-next/topics: Fail - 3/8 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1062 - Add USB and Type-C support for Shikra platforms (8 commits)
Upstream commits: Multiple lore.kernel.org series
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Commits 4-5: subjects match lore v7; Commits 6-8: link to v1 but v2 exists
Body preserves rationale Key rationale preserved in all FROMLIST commits
Fixes tag present/correct N/A No Fixes tags required for new feature additions
Authorship preserved Krishna Kurapati authorship correct for 4-5; Akash Kumar for 6-8
Backport note (if applicable) N/A FROMLIST commits, not backports

Diff

File Status Notes
Commits 1-3 (QCLINUX reverts) Vendor-only reverts; no lore validation required
Commit 4/8 (shikra.dtsi USB nodes) ⚠️ Links to two lore series; content appears to merge both
Commit 5/8 (Enable USB on platforms) Matches lore v7 patch 2/2 subject and intent
Commits 6-8 (Type-C binding/driver/DT) Links to v1 (20260820145036.2035641-4) but v2 exists (20260821-shikra-usb-dt-v7-apply-v2)

Issues

1. Commit 4/8: Multiple lore links without clear mapping

  • Links to both 20260811-usb-shikra-v7 (DT series) and 20260712-usb-shikra-phy-v6 (PHY driver series)
  • Commit message says "Add support for both USB controllers and their respective phys on Shikra"
  • The lore v7 series is 2 patches (DT only); the v6 PHY series is 4 patches (binding + driver changes)
  • PR commit 4/8 touches shikra.dtsi, phy-qcom-qmp-usbc.c, pinctrl-shikra.c, and a binding YAML — this appears to merge content from both series
  • Issue: Cannot validate faithfulness to a single lore patch when the PR commit conflates multiple upstream patches

2. Commits 6-8: Outdated lore link (v1 instead of v2)

  • All three commits link to 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com (v1, posted Aug 20)
  • v2 series 20260821-shikra-usb-dt-v7-apply-v2 was posted Aug 21 (one day later)
  • v1 received review feedback from Abel Vesa: "AFAICT, this fails dtbs_check because it isn't allowed by the usb-connector.yaml"
  • Issue: PR should link to the latest revision (v2) that addresses review feedback

3. Commit 7/8: Massive diff size (2769 lines changed)

  • Commit message says "Add cypd6129 and cypd6229 compatible strings to the of_device_id match table"
  • Diff shows 1 file changed, 1986 insertions(+), 783 deletions(-)
  • Issue: A simple compatible-string addition should not require 2700+ lines of changes; suggests either:
    • The lore patch includes a large refactor/cleanup, or
    • The PR commit includes unrelated changes

Upstream Patch Status

Commit Community Verdict
4-5: USB v7 series ✅ ACKed — Reviewed-by: Konrad Dybcio, Manivannan Sadhasivam, Dmitry Baryshkov
6-8: Type-C v1 series ⏳ Decision Pending (superseded) — v2 posted Aug 21; v1 had dtbs_check issues per Abel Vesa

Dependency Check

  • ✅ Commits 1-3 revert prior out-of-tree changes to make room for upstream series
  • ⚠️ Commit 4/8 appears to depend on both the USB DT series (v7) and the PHY driver series (v6)
  • ⚠️ Commits 6-8 depend on the USB nodes from commits 4-5 being present first

qcom-next/topics Presence

Commit Status
1/8 (QCLINUX revert IQS) ⚠️ missing from qcom-next and topics
2/8 (QCLINUX revert CQM/CQS) ✅ present in topics
3/8 (QCLINUX revert typec) ⚠️ missing from qcom-next and topics
4/8 (FROMLIST USB nodes) ⚠️ partial — subject/partial tree evidence, full change not verified
5/8 (FROMLIST Enable USB) ⚠️ partial — subject/partial tree evidence, full change not verified
6/8 (FROMLIST cypd6129 binding) ⚠️ missing from qcom-next and topics
7/8 (FROMLIST cypd6129 driver) ⚠️ partial — subject/partial tree evidence, full change not verified
8/8 (FROMLIST wire up Type-C) ⚠️ partial — subject/partial tree evidence, full change not verified

Integration presence summary: FAIL — 3/8 commits missing, 5/8 partial, 1/8 present (per integration_presence_report.md)

Verdict

Request changes before merging:

  1. Commit 4/8: Split into separate commits that map 1:1 to upstream patches:

    • One commit for the USB DT nodes (from 20260811-usb-shikra-v7 patch 1/2)
    • One commit for the PHY driver changes (from 20260712-usb-shikra-phy-v6 patch 4/4)
    • Each commit should link to its specific lore patch, not both series
  2. Commits 6-8: Update Link: tags to point to v2 series:

    • Change from 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com
    • To 20260821-shikra-usb-dt-v7-apply-v2-<N>-030647f06285@oss.qualcomm.com (where N = 1, 2, 3)
  3. Commit 7/8: Verify the 2700-line diff is faithful to the lore v2 patch:

    • If lore patch is small and PR commit is large → extra content needs explanation
    • If lore patch is also large → confirm it's a faithful copy
  4. Integration presence: Investigate why 3 commits are missing from qcom-next/topics:

    • Commits 1/8, 3/8 (QCLINUX reverts) — may be intentionally not in topics yet
    • Commit 6/8 (binding) — should be present if the series was accepted

Final Summary

  1. Lore link present: Yes for commits 4-8; No (expected) for commits 1-3 (QCLINUX)
  2. Lore link matches PR commits: Partial — commit 4/8 conflates two series; commits 6-8 link to v1 instead of v2
  3. Upstream patch status: ✅ ACKed (commits 4-5 with Reviewed-by tags); ⏳ Decision Pending (commits 6-8, v1 superseded by v2)
  4. PR present in qcom-next/topics: Fail — 3/8 missing, 5/8 partial, 1/8 present

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/8 [PATCH 1/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/8 [PATCH 2/8] QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
3/8 [PATCH 3/8] QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/8 [PATCH 4/8] FROMLIST: arm64: dts: qcom: Add support for usb nodes on partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
5/8 [PATCH 5/8] FROMLIST: arm64: dts: qcom: Enable USB controllers on partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
6/8 [PATCH 6/8] FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
7/8 [PATCH 7/8] FROMLIST: usb: typec: ucsi: ccg: Add support for partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
8/8 [PATCH 8/8] FROMLIST: arm64: dts: qcom: shikra: Wire up partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: FAIL
present_commits: 1/8
partial_commits: 4/8
missing_commits: 3/8
topics_checked_for_commits: 8/8
final_summary: PR present in qcom-next/topics: Fail - 3/8 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1062 — checker-log-analyzer

PR: #1062
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35062399835

Checker Result Summary
Checker Result Summary
checkpatch 3 commits with style issues (1 ERROR, 2 WARNINGs, 1084 errors + 1048 warnings in commit 328388a)
dt-binding-check Both bindings validated successfully
dtb-check Multiple schema validation failures across all Shikra DTBs
sparse-check Passed (unrelated DRM errors are pre-existing)
check-uapi-headers No UAPI changes detected
check-patch-compliance 8 failures: 3 QCLINUX prefix rejections, 2 b4 fetch failures, 3 content mismatches
tag-check ⚠️ Cannot determine target branch (network unavailable); if not qcom-next/qcom-next-staging, QCLINUX prefix commits will fail

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1062 - USB Type-C support for Shikra platform
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35062399835

Checker Result Summary
checkpatch 3 commits with style issues (1 ERROR, 2 WARNINGs, 1084 errors + 1048 warnings in commit 328388a)
dt-binding-check Both bindings validated successfully
dtb-check Multiple schema validation failures across all Shikra DTBs
sparse-check Passed (unrelated DRM errors are pre-existing)
check-uapi-headers No UAPI changes detected
check-patch-compliance 8 failures: 3 QCLINUX prefix rejections, 2 b4 fetch failures, 3 content mismatches
tag-check ⚠️ Cannot determine target branch (network unavailable); if not qcom-next/qcom-next-staging, QCLINUX prefix commits will fail

❌ checkpatch

Root cause: Three commits have coding style violations ranging from minor warnings to severe formatting issues.

Failure details:

Commit 69c6cb3 - QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")'
#8: introduced by commit 102ec26f93ef3d6010a7693a061bcec8838fc536:

total: 1 errors, 0 warnings, 0 checks, 130 lines checked

Commit 1a57ed0 - FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra

WARNING: DT binding docs and includes should be a separate patch.

total: 0 errors, 1 warnings, 0 checks, 336 lines checked

Commit 328388a - FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229

ERROR: code indent should use tabs where possible
#156: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:189:
+        u16 row;$

total: 1084 errors, 1048 warnings, 22 checks, 3139 lines checked

This commit has massive formatting issues — over 1000 errors and warnings indicating widespread use of spaces instead of tabs, trailing whitespace, and other style violations throughout the driver file.

Fix:

For commit 69c6cb3:

git rebase -i <base_sha>   # mark commit as 'edit'
# Edit commit message to use proper format:
# "introduced by commit 102ec26f93ef ("PENDING: arm64: dts: qcom: Add typec role switching changes to shikra")"
git commit --amend
git rebase --continue

For commit 1a57ed0:
This is a WARNING about mixing DT binding includes with DTS changes. If the commit adds new #include <dt-bindings/...> headers, consider splitting into separate patches. However, this may be acceptable if the includes are necessary for the DTS changes.

For commit 328388a:

git rebase -i <base_sha>   # mark commit as 'edit'
# Run checkpatch with --fix to auto-correct formatting:
git show HEAD | ./scripts/checkpatch.pl --fix-inplace --types=SPACING,INDENTATION,TRAILING_WHITESPACE
git add drivers/usb/typec/ucsi/ucsi_ccg.c
git commit --amend --no-edit
git rebase --continue

Alternatively, manually fix the file to use tabs for indentation and remove trailing whitespace.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

❌ dtb-check

Root cause: The USB DT changes introduce properties that violate the existing DT schema bindings for qcom,shikra-dwc3, qcom,shikra-tlmm, and qcom,shikra-iris.

Failure details:

All Shikra DTBs (shikra-cqm-evk, shikra-cqs-evk, shikra-iqs-evk, and their variants) report the same three categories of errors:

1. TLMM pinctrl unevaluated properties:

pinctrl@500000 (qcom,shikra-tlmm): Unevaluated properties are not allowed
  ('emac0-phy-en-hog', 'vbus-boost-5v' were unexpected)

The qcom,shikra-tlmm binding uses unevaluatedProperties: false but doesn't declare vbus-boost-5v as a valid pinctrl state name. This is introduced by the USB changes.

2. USB interrupt arrays too long:

usb@4e00000 (qcom,shikra-dwc3): interrupt-names: ['dwc_usb3', 'pwr_event', 'hs_phy_irq', 
  'dp_hs_phy_irq', 'dm_hs_phy_irq', 'ss_phy_irq'] is too long
usb@4e00000 (qcom,shikra-dwc3): interrupts-extended: [[1, 0, 255, 4, 0], [1, 0, 302, 4, 0], 
  [1, 0, 254, 4, 0], [35, 91, 4], [35, 90, 4], [35, 12, 4]] is too long

The binding for qcom,shikra-dwc3 (in qcom,snps-dwc3.yaml) expects fewer interrupts than the 6 provided. The USB patches add dp_hs_phy_irq, dm_hs_phy_irq, and ss_phy_irq which are not declared in the binding.

3. Video codec iommus too short:

video-codec@5a00000 (qcom,shikra-iris): iommus: [[48, 1920, 32]] is too short

This appears to be a pre-existing issue unrelated to the USB changes, but is exposed when building the Shikra DTBs.

Fix:

For the TLMM unevaluated properties:
Update the qcom,shikra-tlmm binding (or the base TLMM binding it references) to add patternProperties allowing vbus-boost-5v:

patternProperties:
  "^vbus-boost-5v$":
    type: object
    description: USB VBUS boost GPIO hog configuration

For the USB interrupt arrays:
Update Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml to extend the interrupt-names and interrupts maxItems for qcom,shikra-dwc3:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,shikra-dwc3
    then:
      properties:
        interrupt-names:
          minItems: 3
          maxItems: 6
        interrupts:
          minItems: 3
          maxItems: 6

For the video codec iommus:
This is likely a pre-existing tree issue. Verify if it exists at the base commit. If so, it can be addressed separately.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: Multiple compliance failures across 8 commits due to QCLINUX prefix rejection, b4 fetch failures, and content mismatches with upstream lore patches.

Failure details:

Commits 71d0597, a95db59, 69c6cb3 - QCLINUX Revert commits:

Checking commit: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Commit summary does not start with a required prefix

Checking commit: QCLINUX: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Commit summary does not start with a required prefix

Checking commit: QCLINUX: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
Commit summary does not start with a required prefix

The QCLINUX: prefix is not in the checker's allowed list (FROMLIST, FROMGIT, UPSTREAM, BACKPORT). This is a known limitation — the checker enforces upstream-linkable prefixes only and will always fail for vendor-only commits.

Commits 1a57ed0, 76a8331 - b4 fetch failures:

Checking commit: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra
Something seems wrong with the provided link. Please verify it

Checking commit: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms
Something seems wrong with the provided link. Please verify it

The checker failed to fetch the patches from the provided lore links. This could be a transient network issue or the links may point to a series URL rather than individual message IDs.

Commits b9a34d2, 328388a, ce4e16e - Content mismatches:

Checking commit: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Change is different from the one mentioned in Link

Checking commit: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Change is different from the one mentioned in Link

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Change is different from the one mentioned in Link

The patch content in the PR differs from the upstream lore patches. This could be due to:

  • Context-only differences (line number shifts)
  • Legitimate adaptations for the vendor tree
  • Missing or extra hunks

Fix:

For QCLINUX prefix failures:
This is expected behavior. The checker only accepts upstream-linkable prefixes. If these are vendor-only reverts with no upstream equivalent, the checker will always fail. No action needed — this is a known limitation.

Alternatively, if the target branch allows it, you could change the prefix to BACKPORT: or FROMGIT: if the reverts correspond to upstream commits, but this may not be semantically correct.

For b4 fetch failures:
Verify the Link URLs manually:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ -o /tmp/out

If the links are series URLs (ending in -0-), replace them with individual message IDs for each commit. The series cover letter URL won't work for individual patch validation.

For content mismatches:
Fetch the upstream patches and compare:

b4 am --single-message -C -l -3 <link> -o /tmp/upstream
git format-patch -1 <sha> --stdout > /tmp/pr-patch
diff <(awk '/^diff/,/^--$/' /tmp/pr-patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/upstream/*.mbx | grep -E '^[+-][^+-]')

Classify the differences:

  • Context-only shifts (line numbers changed) → not a real issue
  • Legitimate adaptations (e.g., different base tree) → document in commit message
  • Missing hunks → add them
  • Extra hunks → remove or attribute separately

Reproduce locally:

cd kernel-checkers
./check-patch-compliance.sh <base_sha> <head_sha>

Verdict

8 blockers must be fixed before merge:

  1. checkpatch — Fix commit message format in 69c6cb3 (1 ERROR)
  2. checkpatch — Fix massive formatting issues in 328388a (1084 errors, 1048 warnings) — CRITICAL
  3. dtb-check — Update qcom,shikra-tlmm binding to allow vbus-boost-5v pinctrl state
  4. dtb-check — Update qcom,snps-dwc3.yaml binding to allow 6 interrupts for qcom,shikra-dwc3
  5. check-patch-compliance — Resolve b4 fetch failures for commits 1a57ed0 and 76a8331 (verify Link URLs)
  6. check-patch-compliance — Resolve content mismatches for commits b9a34d2, 328388a, ce4e16e

Non-blockers (known limitations):

  • check-patch-compliance — QCLINUX prefix failures (3 commits) are expected for vendor-only changes
  • checkpatch — DT binding split warning in 1a57ed0 is minor and may be acceptable
  • dtb-check — Video codec iommus issue appears pre-existing

Priority: The most critical issue is commit 328388a with over 2000 style violations. This must be fixed before merge. The dtb-check failures require binding updates to match the new USB interrupt configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants