Remove brownout risks from DPU - #1083
YongxingMou wants to merge 3 commits into
Conversation
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Prevent that from happening when _dpu_core_perf_get_core_clk_rate() returns 0. Fixes: 25fdd59 ("drm/msm: Add SDM845 DPU support") Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/742779/ Link: https://lore.kernel.org/r/20260728-topic-dpu_power-v1-1-e7783b859a70@oss.qualcomm.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Drop the explicit calls to it. Fixes: c943b49 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/742781/ Link: https://lore.kernel.org/r/20260728-topic-dpu_power-v1-2-e7783b859a70@oss.qualcomm.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4618390 on any of the following entities: Entities:
CR: 4618390 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
c4631f2 to
d60d588
Compare
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Drop the explicit call to it. Every call site of ops->link_clk_disable() is followed by pm_runtime_put(), so the power vote will be rescinded if deemed safe. Fixes: 32d3e0f ("drm/msm: dsi: Use OPP API to set clk/perf state") Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/742783/ Link: https://lore.kernel.org/r/20260728-topic-dpu_power-v1-3-e7783b859a70@oss.qualcomm.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
d60d588 to
5795ff5
Compare
Test Matrix
|
PR #1083 — validate-patchPR: #1083
Final Summary
|
PR #1083 — checker-log-analyzerPR: #1083
Detailed report: Full report
|
PR #1083 — validate-patchPR: #1083
Final Summary
|
PR #1083 — checker-log-analyzerPR: #1083
Detailed report: Full report
|
LAVA Failed Case Triage SummaryPR: #1083 Job 223501 | SoC lemans-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223501 Failed test cases in LAVA job 223501 (SoC: lemans-evk).
Job 223502 | SoC shikra-iqs-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223502 Failed test cases in LAVA job 223502 (SoC: shikra-iqs-evk).
Job 223503 | SoC purwa-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223503 Failed test cases in LAVA job 223503 (SoC: purwa-evk).
Job 223504 | SoC qcs9100-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223504 Failed test cases in LAVA job 223504 (SoC: qcs9100-ride).
Job 223505 | SoC qcs8300-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223505 Failed test cases in LAVA job 223505 (SoC: qcs8300-ride).
Job 223506 | SoC hamoa-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223506 Failed test cases in LAVA job 223506 (SoC: hamoa-evk).
Job 223507 | SoC qcs615-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223507 Failed test cases in LAVA job 223507 (SoC: qcs615-ride).
Job 223508 | SoC monaco-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/223508 Failed test cases in LAVA job 223508 (SoC: monaco-evk).
Job 223509 | SoC qcs6490-rb3gen2LAVA job: https://lava-oss.qualcomm.com/scheduler/job/223509 Failed test cases in LAVA job 223509 (SoC: qcs6490-rb3gen2).
|
Things generally run better when plugged in. That also happens to hold
for clocks. To ensure that is the case, remove calls that drop the
performance state votes while the clocks are still running.
This helps Glymur devices not crash upon resume when a display
(incl. the internal one) is plugged in.
The DSI patch is compile-tested only.
CRs-Fixed: 4618390