Migrate Glymur-CRD to the YAML partition source - #172
Open
Igor Opaniuk (igoropaniuk) wants to merge 5 commits into
Open
Igor Opaniuk (igoropaniuk) wants to merge 5 commits into
Igor Opaniuk (igoropaniuk) wants to merge 5 commits into
Conversation
In board mode -o is now optional: without it each storage is written to <outdir>/<storage-id>/partitions.xml (outdir from -C, default the current directory), so callers need not enumerate storages. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Both storages inline in the exact legacy .conf order (order determines GPT offsets). All 38 generated artifacts verified byte-identical to the .conf build. The .conf files stay until the Makefile switches over. [1] qualcomm-linux#124 Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
The board list is discovered from platforms/boards/ and each board's storage ids are read from its file; a template generates one grouped build rule per board and excludes migrated boards from the .conf glob, so adding a board needs no Makefile changes. Glymur-CRD is the first entry. Artifacts and the checksum manifest are unchanged. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Point the YAML loader parity tests at a committed .conf fixture, so they stop depending on a live board about to lose its .conf. Byte fidelity of the board itself is covered by the checksum manifest. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Glymur-CRD now builds from its YAML board; generated artifacts and the checksum manifest are unchanged. [1] qualcomm-linux#124 Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Igor Opaniuk (igoropaniuk)
force-pushed
the
feat/glymur-yaml-board
branch
from
September 20, 2026 07:10
8e6ac43 to
9e2e06e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tthe first board moves off
partitions.conf.gen_partitionboard mode gains a default output layout: without-o, each storage is written to<outdir>/<storage-id>/partitions.xml(-C, default the current directory), so callers no longer enumerate storages.platforms/boards/glymur-crd.yamldeclares both storages (NVMe+SPI-NOR) with every partition inline, in the exact order of the legacy.conffiles, since partition order determines GPT offsets.The Makefile gains a generic rule template for YAML boards - the board list is discovered from
platforms/boards/, each board declares only its storages, and migrated boards are excluded from the.confglob - so later migrations need no Makefile changes. The YAML loader parity tests are repointed to a committed fixture, and the two partitions.conf files are removed.The whole build is invoked as:
with
ptoolandgen_contentsconsuming the per-storagepartitions.xmlas before. Every generated artifact is byte-identical to the.confbuild, which CI proves via the pinned checksum manifest - nothing that gets flashed changes.[1] #124