platforms/shikra-evk: add SD card partition config - #173
ArunSahu418 wants to merge 1 commit into
Conversation
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Commit message doesn't explain why this is necessary.
1b0b1af to
fec7850
Compare
|
Updated the commit message to explain why a separate SD card partition config is needed. The SD card config is used to generate GPT files for SD card flashing. The eMMC layout cannot be reused because it places cdt in LUN 1, while SD cards expose only a single LUN, so cdt is placed in the main partition layout. |
fec7850 to
e07b3ec
Compare
|
Please fix your editor settings, your lines are way longer than the standard recommendations. |
e07b3ec to
87fc57c
Compare
|
Updated the commit message again. The subject/body are now wrapped per the 72-column recommendation, and the body explains why Shikra needs a separate SD card table. |
| --partition --name=efi --size=524288KB --type-guid=C12A7328-F81F-11D2-BA4B-00A0C93EC93B --filename=efi.bin | ||
| --partition --name=rootfs --size=16777216KB --type-guid=B921B045-1DF0-41C3-AF44-4C6F280D3FAE --filename=rootfs.img | ||
|
|
||
| --partition --name=cdt --size=128KB --type-guid=A19F205F-CCD8-4B6D-8F1E-2D9BC24CFFB1 --filename=cdt.bin |
There was a problem hiding this comment.
rootfs need to be the last partition to grow and occupy remaining disk space.
Most of the platforms support booting form SD card. Do we plan to add SD card partitions to all other platforms? |
Shikra EVK supports booting images from an SD card. Add a storage-specific table so qcom-ptool can generate the GPT and rawprogram artifacts for that flow. The existing eMMC table cannot be reused for SD card images because it places cdt in eMMC LUN 1. SD cards expose only a single LUN, so cdt must live in the main SD card layout. Keep rootfs as the last partition so it can grow to occupy the remaining SD card space. Signed-off-by: Arun Sahu <arunsahu@qti.qualcomm.com>
87fc57c to
46b8264
Compare
|
As of now, I only have confirmed SD card boot support for Shikra EVK. |
3 participants
Add the SD card partition configuration for shikra-evk.