fix: repair failing tests across utility modules - #285
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: fix wordCount whitespace splitting, implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: use Math.round for day calculation (36h -> 2 days) - validator: allow long TLDs/subdomains in isEmail, ports in isUrl All 60 tests pass. No test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the 5 utility modules. Test suite now: 60 pass / 0 fail (was 44/16). No test files modified, no dependencies added — changes are scoped to exactly what the failing tests require.
Changes
src/calculator.ts—divide(10, 0)returnedInfinity; added an explicitb === 0guard that throws.src/string-utils.ts—wordCountnow trims and splits on/\s+/(was counting empty elements from consecutive spaces); implemented the stubbedtruncate(reserves 3 chars for"...", cuts back to a word boundary, hard-cuts single long words, slices directly whenmaxLength <= 3).src/task-manager.ts— implementedremove(delegates toMap.deletefor the found/not-found boolean),update(per-field!== undefinedmerge, returnsfalsefor unknown id), andsortBy(explicit rank maps for priority;createdAtoldest-first with an id tiebreaker for same-millisecond determinism).src/date-utils.ts— day calc usedMath.floorso 36h reported "1 day ago"; switched toMath.roundonMath.abs(diffHours)(avoids JS's round-half-toward-+∞ skewing future vs past dates).src/validator.ts—isEmailno longer caps the TLD at 4 chars (.museumnow valid; subdomains supported);isUrldropped a redundantport === ""check that rejectedhttp://localhost:3000.Verification
bun test→ 60 pass, 0 failtsc --noEmitcleanAssumptions & notes
maxLengthclamping intruncate, dropping the numeric-id coupling in thecreatedAttiebreak, underscore-in-domain narrowing inisEmail) — deliberately not applied here to avoid changing behavior the tests don't cover. These are candidates for a follow-up if these functions gain real consumers.