Deepseekv4 with npi - #1291
Open
ochougul wants to merge 22 commits into
Open
Deepseekv4 with npi#1291ochougul wants to merge 22 commits into
ochougul wants to merge 22 commits into
Conversation
ochougul
marked this pull request as ready for review
September 9, 2026 09:53
Signed-off-by: ochougul <ochougul@qti.qualcomm.com>
Signed-off-by: ochougul <ochougul@qti.qualcomm.com>
Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com>
Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com>
Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com>
Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com>
Signed-off-by: ochougul <ochougul@qti.qualcomm.com>
The raw sliding-window attention path in all four cache layers (sliding, HCA, CSA) gathered context_length (the full ctx_len-wide retained-state buffer) on every decode step instead of just the sliding_window-wide recent window, and the model-level causal mask was built at the same unnecessarily wide ctx_len. Both are now narrowed to sliding_window width via a shared _sliding_window_context_indices helper, removing O(ctx_len) wasted attention/ReduceMax compute from every decode step without changing model output. Verified via the existing CPU parity tests (test_deepseek_v4_*, full test_model_quickcheck.py suite unaffected) and by matching generated token IDs on real QAIC hardware, before and after the fix, for both the current ping-pong CSA cache and (previously) the legacy overlap layout. Signed-off-by: divytrip <divytrip@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
abhishek-singh591
force-pushed
the
deepsekv4_with_npi
branch
from
September 10, 2026 09:30
4c43ac3 to
20cf3d6
Compare
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
abhishek-singh591
force-pushed
the
deepsekv4_with_npi
branch
from
September 10, 2026 09:56
4bb867f to
39c49d3
Compare
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
abhishek-singh591
force-pushed
the
deepsekv4_with_npi
branch
from
September 15, 2026 19:44
061a89b to
43852c7
Compare
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
abhishek-singh591
force-pushed
the
deepsekv4_with_npi
branch
2 times, most recently
from
September 23, 2026 06:07
d281635 to
15bd6f9
Compare
Signed-off-by: Abhishek kumar singh <sabhis@qti.qualcomm.com>
abhishek-singh591
force-pushed
the
deepsekv4_with_npi
branch
from
September 23, 2026 06:07
15bd6f9 to
415b1f8
Compare
Signed-off-by: divytrip3005 <divytrip@qti.qualcomm.com> (cherry picked from commit 9b9e932e0fa81856e0d52f49138907fa4e94946a)
perf(deepseek-v4): fold sliding attention cache
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.