Skip to content

Delete with 204 response (and empty body) causes JSON parse error #55

Open
Open
Delete with 204 response (and empty body) causes JSON parse error#55

Description

@tim-hitchins-ekkosense
tim-hitchins-ekkosense
opened on Feb 16, 2022

the JSON:API spec allows for delete requests to have a status code 204, and have no content in the body. This causes an error in this library because it tries to JSON parse the response before checking the status code.

The issue is in src/jsonapi_client/session.py, line 538.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions