fix(understackctl): make version stamping actually work - #2192
Open
cardoe wants to merge 1 commit into
Open
Conversation
|
LGTM by looking at the code. I haven't tried the ctl manually myself on my laptop. Is there a definitive guide which I could follow to test this myself? Would I require a dev setup of understack in my local to test this? |
Contributor
Author
https://rackerlabs.github.io/understack/operator-guide/understackctl/ |
cardoe
enabled auto-merge
August 5, 2026 23:48
The Makefile has always built LDFLAGS with -X main.version and -X main.commit, but neither variable existed and nothing exposed a --version flag. build-all also expanded $() instead of $(LDFLAGS). Declare both variables, wire them into `understackctl --version`.
cardoe
force-pushed
the
understackctl-build-fixes
branch
from
August 10, 2026 19:36
ca6bbb3 to
d6effa3
Compare
|
I thought we decided to sepearate version change and the change in the MAKEFILE separate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile has always built LDFLAGS with -X main.version and$() instead of $ (LDFLAGS).
-X main.commit, but neither variable existed and nothing exposed a
--version flag. build-all also expanded
Declare both variables, wire them into
understackctl --version.