Skip to content

chore(argocd-understack): remove unnecessary ref in multi-source app - #2218

Open
cardoe wants to merge 1 commit into
mainfrom
remove-unnecessary-refs
Open

chore(argocd-understack): remove unnecessary ref in multi-source app#2218
cardoe wants to merge 1 commit into
mainfrom
remove-unnecessary-refs

Conversation

@cardoe

@cardoe cardoe commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Fast follow to #2205, addressing item 3 from the pass-4 review.

These ref: fields are never dereferenced — no source in these Applications uses $understack/ or $deploy/ in helm.valueFiles or anywhere else. Per 8f9e2d7 and 92ee95e, an unnecessary ref causes ArgoCD to crash with a runtime exception due to argoproj/argo-cd#25460, and that fix still has not been backported to any release branch.

Those two commits only covered the single-source Applications. This covers the multi-source ones that were missed:

Application Removed
application-argo-events.yaml ref: understack, ref: deploy
application-argo-events-workflows.yaml ref: understack, ref: deploy
application-global-workflows.yaml ref: understack, ref: deploy
application-openstack-sync-plugins.yaml ref: understack, ref: deploy
application-external-secrets.yaml ref: understack
application-openstack.yaml ref: understack
application-snmp-exporter.yaml the whole ref-only - ref: understack source

application-openstack.yaml keeps ref: deploy, which its valueFiles dereferences. application-snmp-exporter.yaml had a source consisting only of ref: understack with no path, referenced by nothing, so the source is dropped rather than just the ref. application-openstack-sync-operator.yaml keeps both of its refs since its helm.valueFiles dereferences each one.

Verification

Every ref: understack/ref: deploy in the chart was checked against whether its Application dereferences $understack//$deploy/. After this change no unused refs remain, and no Application references a ref it no longer declares.

Rendering charts/argocd-understack against both ci/example.yaml and ci/example-global.yaml, with all affected components enabled, gives 13 lines removed and 0 added versus main — only the ref: lines and the dead snmp-exporter source. No other manifest changes.

🤖 Generated with Claude Code

These refs are never dereferenced: no source in these Applications uses
$understack/ or $deploy/ in helm.valueFiles or anywhere else. This ref
causes ArgoCD to crash with a runtime exception due to
argoproj/argo-cd#25460 and the fix not being backported to any release
branch yet.

8f9e2d7 and 92ee95e removed these from the single-source Applications.
This covers the multi-source ones that were missed, including the
openstack-sync-plugins Application added in #2205, and drops the ref-only
source in the snmp-exporter Application that nothing referenced.

The openstack-sync-operator Application keeps both of its refs since its
helm.valueFiles dereferences each one.

Rendering charts/argocd-understack against both ci/ values files with the
affected components enabled produces no change other than the removed
ref lines.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@cardoe
cardoe requested a review from a team August 14, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant