Repository navigation
Conversation
Deploying document with
|
| Latest commit: |
62c614c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1628791b.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-speech-first-permission.document-7hm.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[NEEDS_CHANGE]
Exact-head CI passed at
62c614c, but a fresh interaction review reproduced additional correctness and UX gaps below. These should be addressed before merging. Functional commits remain separate; this PR is not merged.Summary
Functional commits remain separate. History persistence, model defaults, dependencies and document review permissions are unchanged.
Risk Analysis
Cross-cutting assistant lifecycle changes are protected by per-run identity, original-document scope checks, verified outcomes, owned Apply barriers and serialized provider drain. Pending requests and drafts remain volatile; disk history stays opt-in.
Code Concerns
Specification and quality reviews approved history, Stop, request performance, queue execution, Apply ownership, disclosure, title navigation and the delayed startup draft fix. The follow-up interaction review supersedes the earlier approval.
Follow-up Review
sessions.ts:157drops that owner, andpanel.ts:2747switches to the restored conversation. The queued text is left under a removed session and the composer is empty. Reproduced in Chromium with a real Word editor and a controlled panel test; an already accepted Hello is the passing control. Preserve the identity of a session owning in-flight/pending work rather than rebinding its document context.panel.ts:2628applies document-position/history freshness to conversation-only requests. Separate proven conversation-only requests from editor-bound tasks while retaining provider/session/abort guards.request-queue.ts:141–165rejects the active entry. Remove does nothing; Edit incorrectly says the empty composer contains a draft (panel.ts:1786). Reproduced in Chromium. Expose preparing state and truthful availability, or support cancel-and-settle editing/removal.history-search.ts:181collapses corpus whitespace while:225does not normalize query whitespace. Chromium Worker and fallback paths both return zero matches foralpha betaand one foralpha betaagainst the same source. Normalize both consistently.panel.ts:800returns false andspeech-input.ts:233exits. Source review only. Align voice draft entry with the new typed queue, or visibly explain its unavailable state.Optimization evidence is separate from correctness: shared ChatView restoration of 1,000 synthetic messages (1,122 characters per assistant answer) produced 19,023 DOM nodes and a 135ms pending-timer delay on one Chromium machine. Render the latest window first, then load earlier turns. The CPU exact-token budget also repeatedly recounts one-turn-shorter histories; this is a pre-existing CPU-path issue, not a measured GPU regression. Real local-GPU first-visible-text timing remains unmeasured.
Verification
Conclusion basis: Verified
62c614c: 5,664 unit tests in 194 files passed; production build, workspace/application type checks and formatting passed. Quality checks verified all 1,511 immutable evaluation artifacts.Limits
Physical local-GPU first-token/drain time and the user's microphone were not measured. Three legacy corpus-format cases are unavailable locally. Long conversations trim older complete turns to fit the model budget; this PR does not add semantic summarization.
All 20 reported checks passed at exact head
62c614c, including regular, Docker-image and Cloudflare-semantics E2E, timing budgets, lint, preview smoke and deployment. The formerly failing regular/Docker history shards both passed.Exact-head CI.
Preview.
Acceptance record.