Deprecate radius kwarg for shapes - #215
Open
raphaelquast wants to merge 1 commit into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #215 +/- ##
==========================================
+ Coverage 76.19% 76.21% +0.02%
==========================================
Files 23 23
Lines 11199 11209 +10
==========================================
+ Hits 8533 8543 +10
Misses 2666 2666 ☔ View full report in Codecov by Sentry. |
raphaelquast
force-pushed
the
deprecate_radius
branch
2 times, most recently
from
December 22, 2023 07:27
42e0a5e to
7cd8ecd
Compare
raphaelquast
force-pushed
the
deprecate_radius
branch
2 times, most recently
from
January 3, 2024 21:16
d728aca to
2d6d46c
Compare
raphaelquast
force-pushed
the
deprecate_radius
branch
from
January 30, 2024 10:45
2d6d46c to
8b62114
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the use of the
"radius"and"radius_crs"kwargs of shapes in favor of"size"and"crs".The
"radius"and"radius_crs"kwargs ofm.set_shape.<SHAPE>(...)are deprecated in favor of"size"and"crs".rectanglesetc.EOmaps > v8.5