Conversation
|
Please do not submit against |
keytouch
marked this pull request as draft
September 26, 2026 10:31
keytouch
marked this pull request as ready for review
September 26, 2026 10:31
lurch
reviewed
Sep 27, 2026
lurch
reviewed
Sep 27, 2026
lurch
reviewed
Sep 27, 2026
* sleep_us(2) before waiting for low signal * check iteration variable j to avoid out of bound write on data[5] * flip last directly instead of polling again * 1 bit is 70us and 0 bit is about 26-28us, fix the check on polling count
Contributor
|
Changes look reasonable to me, but I don't have a DHT-11 or DHT-22 sensor to check that the code still works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was testing, without prior sleep_us(2) before waiting for low signal, it turned out to be Bad data.
Tested on DHT11, I don't own a DHT22, but the line protocol should be the same.
sleep_us(2) before waiting for low signal
check iteration variable j to avoid out of bound write on data[5]
flip last directly instead of polling again
1 bit is 70us and 0 bit is about 26-28us, fix the check on polling count