RDKEMW-22731 : [support/8.5.3.0] [SECVULN][7.5] Remove sensitive information from property files in /etc - #590
Merged
Merged
Conversation
…rmation from property files in /etc
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets hardening of deployed configuration by removing sensitive/static endpoint and credential-like values from /etc property files, reducing the risk of shipping internal infrastructure details or secrets in default images.
Changes:
- Removed multiple hardcoded server IPs from
etc/config.properties. - Removed hardcoded upload usernames/passwords from
etc/config.properties. - Removed multiple hardcoded endpoint IPs from
etc/common.properties.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| etc/config.properties | Removes hardcoded crash upload server IPs and dump upload credentials from the default /etc configuration. |
| etc/common.properties | Removes hardcoded proxy/CDL/image/TFTP-related endpoint IPs from the default /etc configuration. |
Comments suppressed due to low confidence (1)
etc/config.properties:28
POTOMAC_SVRstill hardcodes a server IP in/etc/config.properties. Since this PR is removing sensitive endpoints from /etc, consider making this a placeholder (empty) and supplying it via provisioning/runtime configuration.
POTOMAC_SVR=69.252.107.55
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
Jul 30, 2026
nhanasi
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.