Skip to content

fix: restore classic JSX runtime#371

Merged
zombieJ merged 1 commit into
react-component:masterfrom
QDyanbing:fix-jsx-runtime
Jul 9, 2026
Merged

fix: restore classic JSX runtime#371
zombieJ merged 1 commit into
react-component:masterfrom
QDyanbing:fix-jsx-runtime

Conversation

@QDyanbing

@QDyanbing QDyanbing commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore the TypeScript JSX emit to the classic React runtime.
  • Keep the published output using React.createElement instead of importing react/jsx-runtime.
  • Avoid bundling a build-time React JSX runtime into downstream UMD bundles.

Test

  • npm run tsc
  • npm test -- --runInBand
  • Temporary TS emit check confirmed the JSX output no longer imports react/jsx-runtime.

Summary by CodeRabbit

  • Chores
    • 调整了 JSX 编译配置,提升了项目对 React 相关语法的兼容性。

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel.

A member of the Team first needs to authorize it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TypeScript configuration in tsconfig.json by changing the jsx compiler option from "react-jsx" to "react". There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a4335bd5-c788-4f65-bf8c-28c0169a3b55

📥 Commits

Reviewing files that changed from the base of the PR and between cdb09b8 and 04c6045.

📒 Files selected for processing (1)
  • tsconfig.json

Walkthrough

本次变更仅修改 tsconfig.json 中的一行配置,将 compilerOptions.jsx 的值由 "react-jsx" 改为 "react",影响 TypeScript 对 JSX 语法的编译处理方式。

Changes

TypeScript 配置调整

Layer / File(s) Summary
JSX 编译模式变更
tsconfig.json
将 compilerOptions.jsx 从 "react-jsx" 修改为 "react"。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

一行配置轻轻改,
jsx 模式换新颜,
小兔蹦跳过草原,
react-jsx 变 react,
编译顺畦心欢畦!🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了将 JSX 运行时恢复为经典 React runtime 的主要变更。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (cdb09b8) to head (04c6045).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          19       19           
  Lines         831      831           
  Branches      203      201    -2     
=======================================
  Hits          806      806           
  Misses         25       25           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zombieJ zombieJ merged commit b25b129 into react-component:master Jul 9, 2026
11 of 12 checks passed
@QDyanbing QDyanbing deleted the fix-jsx-runtime branch July 9, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants