Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119500886. |
coado
force-pushed
the
export-D119500886
branch
from
September 16, 2026 13:19
6f04a43 to
230d1f4
Compare
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D119500886
branch
from
September 16, 2026 14:05
230d1f4 to
283b8a9
Compare
meta-codesync
Bot
changed the title
Summary: Declare direct CSS dependencies for renderer targets that consume CSS headers instead of relying on View or Graphics to expose them transitively. Cover Buck, CMake, CocoaPods, and SwiftPM without changing header visibility or runtime behavior. Changelog: [Internal] Reviewed By: javache Differential Revision: D119489856
Summary: Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior. Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized. Changelog: [Internal] Reviewed By: javache Differential Revision: D119500849
Summary: Keep the CSS-free color parsing helpers (`parsePlatformColorFn`, `fromRawValueShared`, and `parsePlatformColor`) in the public Graphics API so the platform `fromRawValue` wrappers remain inline. Move `hashGetColourArguments` and `configurePlatformColorCacheInvalidationHook` into private implementation scope. Stop exporting CSS, fbjni, and the Android cache library from the Buck target, and express implementation-only dependencies privately in Buck and CMake. The retained shared helper header depends only on `RawValue`, `Color`, and `ContextContainer`; CSS parsing headers remain confined to the implementation file. Regenerate C++ API snapshots to remove the private hash and cache declarations while retaining the public color parser helpers and inline `fromRawValue` entry point. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D119500886
coado
force-pushed
the
export-D119500886
branch
from
October 1, 2026 08:34
283b8a9 to
d02ee88
Compare
|
This pull request has been merged in b47915d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep the CSS-free color parsing helpers (
parsePlatformColorFn,fromRawValueShared, andparsePlatformColor) in the public Graphics API so the platformfromRawValuewrappers remain inline. MovehashGetColourArgumentsandconfigurePlatformColorCacheInvalidationHookinto private implementation scope.Stop exporting CSS, fbjni, and the Android cache library from the Buck target, and express implementation-only dependencies privately in Buck and CMake. The retained shared helper header depends only on
RawValue,Color, andContextContainer; CSS parsing headers remain confined to the implementation file.Regenerate C++ API snapshots to remove the private hash and cache declarations while retaining the public color parser helpers and inline
fromRawValueentry point.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D119500886