Conversation
This was referenced Sep 24, 2026
huntie
force-pushed
the
community-cli-plugin-config
branch
from
September 24, 2026 14:13
a78f557 to
3a631a9
Compare
huntie
marked this pull request as ready for review
September 24, 2026 14:18
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D121634885. |
huntie
force-pushed
the
community-cli-plugin-config
branch
from
September 25, 2026 12:52
3a631a9 to
c6827db
Compare
cortinico
approved these changes
Sep 25, 2026
|
@Abbondanzo merged this pull request in b26baae. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Summary: Replaces #57353. Follows #58670. Depends on react-native-community/cli#2817. See also react-native-community/template#235 and react-native-community/template#254, which moves the template to CLI 21.0.0-alpha.1 (the template-app CI jobs here stay red until it lands). Deletes the `react-native.config.js` file we ship with `react-native`. The iOS and Android Community CLI platforms are moving back to being included by default (and in the first place, should not have been wired up here!), and all commands are self-registered by `react-native/community-cli-plugin`. RNTester moves to `react-native-community/cli` 21.0.0-alpha.1, which includes the iOS and Android platforms, and drops its `cli-platform-ios` and `cli-platform-android` devDependencies. HelloWorld gains the same CLI devDependency: its Gradle autolinking runs `npx react-native-community/cli config` after an `npm install` in the app, which otherwise fetches the `latest` (20.x) CLI. Changelog: [General][Changed] - Platform registration config for the Community CLI is removed from the `react-native` package. No breaking change with `react-native-community/cli` 21.x (required). Pull Request resolved: #58671 Test Plan: With `react-native-community/cli` 21.0.0-alpha.1 installed in the monorepo. **RNTester, HelloWorld, and a template-shaped app** (no `react-native.config.js` anywhere) - ✅ `react-native config` registers `ios` and `android` and resolves each project: `RNTesterPods.xcworkspace` / `com.facebook.react.uiapp`, `HelloWorld.xcworkspace` / `com.helloworld` - ✅ `react-native` is absent from `config` dependencies - ✅ `bundle`, `start`, `spm`, and `codegen` are registered by `react-native/community-cli-plugin` - ✅ `react-native bundle --platform ios --dev false` completes for RNTester Screenshots of the template-shaped app are in the react-native-community/cli#2817 test plan. **Internal validation** - ✅ `./xplat/yarn-validation/bin/yarn-validation` (validates `xplat/js`, `xplat/js/public`, and `xplat/js/react-native-github`) - ✅ Root `yarn install --offline --force --ignore-scripts --ignore-engines --ignore-platform --skip-integrity-check` - ✅ `arc lint` Reviewed By: cipolleschi Differential Revision: D122744239 Pulled By: cortinico fbshipit-source-id: 3e46c0f1021fa92863523f2b9865e8c0c770caa8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces #57352.
Self-register commands from the
community-cli-pluginpackage viareact-native.config.js— meaning we can remove the redirect withinpackages/react-native/react-native.config.js.Progress towards removing
community-cli-pluginas a direct dep ofreact-native, and paired with react-native-community/template#235.RNTester and HelloWorld list
@react-native/community-cli-pluginindevDependencies, as the template now does (react-native-community/template#235).Changelog:
[General][Breaking] -
@react-native/community-cli-pluginwill no longer be auto-detected fromreact-native. It must now be specified indevDependencies.Test Plan:
Compared
react-native configoutput with@react-native-community/cli20.2.0.RNTester
main@react-native/community-cli-plugindevDependency dropsbundle,start,spm, andcodegen, so they are registered by plugin discoveryTemplate-shaped app (plugin in
devDependencies, no projectreact-native.config.js)bundle,start,spm, andcodegenare registered