Conversation
meta-cla
Bot
added
the
CLA Signed
|
@jasozh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121559781. |
cortinico
approved these changes
Sep 30, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
jasozh
force-pushed
the
export-D121559781
branch
from
September 30, 2026 18:22
d1be494 to
1f68082
Compare
jasozh
added a commit
to jasozh/react-native
that referenced
this pull request
Sep 30, 2026
Summary: Prevents the RNTester examples in Animated > Transform Styles from exhibiting the issue referenced in [react#43763](react#43763), where rotateX and rotateY show animation artifacting on iOS. ### Root Cause Fabric flattens away the parent view that would normally provide a native layer boundary. iOS Core Animation then processes the rotateX/rotateY 3D layer in the same hierarchy as sibling controls, causing incorrect depth composition and rendering artifacts. ### This PR Modify `TransformStylesExample.js` to add the `isolation: 'isolate'` style on the View wrapper so it is retained in the native stacking context. This doesn't fix the root problem but documents the root cause and a workaround until a framework fix is implemented. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D121559781
Summary: Pull Request resolved: react#58675 Prevents the RNTester examples in Animated > Transform Styles from exhibiting the issue referenced in [react#43763](react#43763), where rotateX and rotateY show animation artifacting on iOS. ### Root Cause Fabric flattens away the parent view that would normally provide a native layer boundary. iOS Core Animation then processes the rotateX/rotateY 3D layer in the same hierarchy as sibling controls, causing incorrect depth composition and rendering artifacts. ### This PR Modify `TransformStylesExample.js` to add the `isolation: 'isolate'` style on the View wrapper so it is retained in the native stacking context. This doesn't fix the root problem but documents the root cause and a workaround until a framework fix is implemented. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D121559781
jasozh
force-pushed
the
export-D121559781
branch
from
September 30, 2026 18:25
1f68082 to
176ed65
Compare
|
This pull request has been merged in cf9eab1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Prevents the RNTester examples in Animated > Transform Styles from exhibiting the issue referenced in #43763, where rotateX and rotateY show animation artifacting on iOS.
Root Cause
Fabric flattens away the parent view that would normally provide a native layer boundary. iOS Core Animation then processes the rotateX/rotateY 3D layer in the same hierarchy as sibling controls, causing incorrect depth composition and rendering artifacts.
This PR
Modify
TransformStylesExample.jsto add theisolation: 'isolate'style on the View wrapper so it is retained in the native stacking context. This doesn't fix the root problem but documents the root cause and a workaround until a framework fix is implemented.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D121559781