Conversation
Summary: Migrate React-Fabric mounting headers to consume the RendererCore, Graphics, and Utils stable umbrellas instead of guarded leaf headers. Add the coreUmbrella dependency to the mounting subspec so dynamic-framework consumers receive the owning header. Avoid RendererDebug.h because its eager utility-template exports change downstream overload lookup; RendererCore already provides the debug flags and declaration types used by mounting. Drop the `#ifdef ANDROID` include of `configurePlatformColorCacheInvalidationHook.h` from the Graphics umbrella. The Android `PlatformColorParser.h` already includes it, and the explicit include broke Android builds that use the cxx graphics platform headers, where that header does not exist. Changelog: [Internal] Differential Revision: D121790104
Summary: Migrate React-Fabric attributedstring headers to consume stable Debug, FeatureFlags, CSS, Graphics, MapBuffer, RendererCore, Utils, and View umbrellas instead of guarded leaf headers. Add the direct Buck and CocoaPods dependencies required by those public imports. Avoid RendererDebug.h because its current utility-template export changes downstream overload lookup; RendererCore already provides the debug declaration types used by attributedstring. Changelog: [Internal] Differential Revision: D121793359
Summary: The public `react/renderer/imagemanager/primitives.h` header included the private `react/renderer/debug/debugStringConvertibleUtils.h` for the inline body of `ImageSource::getDebugProps()`. Because the include was unconditional, any strict consumer of `<React/ImageManager.h>` or `<React/Image.h>` (which reaches `primitives.h` through the Image event emitter) hit the private header guard and failed to compile. Include the public `DebugStringConvertible.h` and `flags.h` headers instead, which provide `SharedDebugStringConvertibleList` and `RN_DEBUG_STRING_CONVERTIBLE`, and keep only the `getDebugProps()` declaration in the header under the existing `RN_DEBUG_STRING_CONVERTIBLE` guard. Move its unchanged implementation into a new `primitives.cpp`, the only place that needs the private debug helpers. Buck, CMake, and CocoaPods already compile every `imagemanager/*.cpp`, so no build-file changes are needed. Changelog: [Internal] Differential Revision: D122534446
Summary: Keep the Image component's exported headers self-contained and free of implementation-only dependencies, following the MapBuffer cleanup. - Move the `ImageSource` and `ImageResizeMode` `fromRawValue`/`toString` implementations from `conversions.h` into a new `conversions.cpp`. The header now only declares them, so it no longer exports `glog/logging.h` and `react_native_expect.h`. Every consumer of `conversions.h` (Image props, text input props, and generated component props) already links the Image library in Buck, CocoaPods, and CMake. - Drop the unused Android-only `MapBuffer.h` and `MapBufferBuilder.h` includes from `ImageState.h`; nothing in the Image module uses MapBuffer. - Declare standard-library dependencies directly in the Image headers (`<memory>`, `<utility>`, `<optional>`, `<string>`, `<cstdint>`). Changelog: [Internal] Differential Revision: D122534476
Summary: Fabric component codegen emitted the fine-grained `react/renderer/imagemanager/primitives.h`, `react/renderer/imagemanager/ImageRequest.h`, and `react/renderer/components/image/conversions.h` headers for `ImageSource` and `ImageRequest` props. Those headers are guarded public module headers, so a strict consumer compiling generated code for a component with an image prop hit the umbrella guard. Emit `<React/ImageManager.h>` for the `ImageSource` and `ImageRequest` types and `<React/Image.h>` for the `ImageSource` conversions instead, matching how generated code already consumes `<React/View.h>` and `<React/ComponentRegistry.h>`. Both umbrellas are published by Buck, CMake, CocoaPods (including dynamic frameworks), the iOS prebuild, and Android prefab, and every generated components library already depends on the Image and ImageManager targets. Refresh the affected codegen snapshots. Changelog: [Internal] Differential Revision: D122543836
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122543836. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fabric component codegen emitted the fine-grained
react/renderer/imagemanager/primitives.h,react/renderer/imagemanager/ImageRequest.h, andreact/renderer/components/image/conversions.hheaders forImageSourceandImageRequestprops. Those headers are guarded public module headers, so a strict consumer compiling generated code for a component with an image prop hit the umbrella guard.Emit
<React/ImageManager.h>for theImageSourceandImageRequesttypes and<React/Image.h>for theImageSourceconversions instead, matching how generated code already consumes<React/View.h>and<React/ComponentRegistry.h>. Both umbrellas are published by Buck, CMake, CocoaPods (including dynamic frameworks), the iOS prebuild, and Android prefab, and every generated components library already depends on the Image and ImageManager targets. Refresh the affected codegen snapshots.Changelog: [Internal]
Differential Revision: D122543836