Remove componentNameByReactViewName from public API - #58771
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
Summary: Changelog: [Internal] Changes guard for `componentNameByReactViewName.h` to private and removes it from public umbrella. Comment in its implementation file says ``` // We need this function only for the transition period; // eventually, all names will be unified. ``` which strongly suggests it shouldn't be part of the public API. Differential Revision: D122570794
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122570794. |
facebook-github-tools
Bot
added
p: Software Mansion
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Changes guard for
componentNameByReactViewName.hto private and removes it from public umbrella.Comment in its implementation file says
which strongly suggests it shouldn't be part of the public API.
Differential Revision: D122570794