Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122780825. |
Summary: Mark the following tracing headers as private instead of for-frameworks. All of them are implementation details of React Native's tracing infrastructure, and no for-frameworks header includes them: - `EventLoopReporter` is an RAII helper the runtime scheduler uses to report event loop task and microtask phases to the performance tracer. It is only used by `EventLoopReporter.cpp` and `RuntimeScheduler_Modern.cpp`. - `RuntimeSamplingProfileTraceEventSerializer` turns a runtime sampling profile into trace events. It is only used by tracing sources, `TracingAgent.cpp` and its own unit test. - `TraceEventSerializer` serializes trace events to `folly::dynamic`. It is only used by tracing sources and `TracingAgent.cpp`. - `TraceEventGenerator` builds trace events for the performance tracer and the host profile serializer. It is only used by tracing sources and was already not exported in Buck. - `ProfileTreeNode` is an auxiliary tree used to build the profile and deduplicate identical frames. It is only used by `RuntimeSamplingProfileTraceEventSerializer.cpp` and its own unit test. - `Timing.h` defines the tracing clock origin and the conversions from `HighResTimeStamp` and `HighResDuration` to trace event microseconds. It is only used by tracing sources and a tracing unit test. `TracingAgent.h` included `Timing.h` without using it; that include is removed. React Native's own targets define `RN_BUILDING`, so the private guard does not affect them. Changelog: [Internal] Differential Revision: D122780825
coado
force-pushed
the
export-D122780825
branch
from
October 2, 2026 11:13
3e200ff to
62f2277
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mark the following tracing headers as private instead of for-frameworks. All of them are implementation details of React Native's tracing infrastructure, and no for-frameworks header includes them:
EventLoopReporteris an RAII helper the runtime scheduler uses to report event loop task and microtask phases to the performance tracer. It is only used byEventLoopReporter.cppandRuntimeScheduler_Modern.cpp.RuntimeSamplingProfileTraceEventSerializerturns a runtime sampling profile into trace events. It is only used by tracing sources,TracingAgent.cppand its own unit test.TraceEventSerializerserializes trace events tofolly::dynamic. It is only used by tracing sources andTracingAgent.cpp.TraceEventGeneratorbuilds trace events for the performance tracer and the host profile serializer. It is only used by tracing sources and was already not exported in Buck.ProfileTreeNodeis an auxiliary tree used to build the profile and deduplicate identical frames. It is only used byRuntimeSamplingProfileTraceEventSerializer.cppand its own unit test.Timing.hdefines the tracing clock origin and the conversions fromHighResTimeStampandHighResDurationto trace event microseconds. It is only used by tracing sources and a tracing unit test.TracingAgent.hincludedTiming.hwithout using it; that include is removed.React Native's own targets define
RN_BUILDING, so the private guard does not affect them.Changelog: [Internal]
Differential Revision: D122780825