Properly enable Pressable after disabled prop reset - #58799
Closed
bigcupcoffee wants to merge 1 commit into
Closed
bigcupcoffee wants to merge 1 commit into
bigcupcoffee wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@zeyap has imported this pull request. If you are a Meta employee, you can view this in D122872380. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
JSI drops
undefinedkeys, so resetingdisabledfromtruetoundefinedon Touchables/Pressables never runssetEnabled(true)There is props diffing feature flag that fixes this, which is off by default
Also added safety check against explicit
null& reset on recyclingFixes #56777 and supersedes #58795
Changelog:
[ANDROID] [FIXED] - Properly enable Pressable after
disabledprop resets fromtrueTest Plan:
Added BaseViewManagerTest as well as videos of testing it on Pressable:
before.mov
after.mov