Standalone decorator#228
Open
JayPanoz wants to merge 72 commits into
Open
Conversation
- Observe Readium CSS changes - Handle font loading - Handle Chrome Zoom discrepancy in rects/positioning
TMP. will deal with this in new build.
- Use shadow DOM to isolate from Readium CSS - check and adjust contrast for all types - defaults specific to type
So that it can be easier to create highlights in FXL
Otherwise it is overflowing and clipped
Achievable through mask + Layout/Width options
So that it does not create types in other packages
This is underspecified in the API, and we must discuss what to make of it.
strikethrough + bounds
This is needed for standalone Decorator, so that the build is not bloated by other packages of the monorepo. Since I have to align build options of the new packages, it makes sense to merge it into standalone decorator first.
No more building in order to get types, etc.
So that it is not accidentally caught up by bundler outside of the monorepo
+ Migration guide
Used across navigator and injectables so it makes sense to have it in helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need Decorators in Readium Speech as standalone (on any webpage), which is not necessarily trivial given our Decorator module was designed with
iframein mind. Especially as we will also use Readium Speech in the context of Navigator…This should be considered an exploratory PR whose code may dramatically change in the near feature.