net: park orphans without locking mempool on the P2P reactor - #409
Merged
Conversation
Nightly p2p_ibd_txrelay and feature_bip68_sequence stalled after a park: the debug log called orphan_count(), which takes the inner RwLock on tokio-rt-worker and panics the reader, so ping/block-sync never complete. Log the txid only; GETDATA parents is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
p2p_ibd_txrelay.py looks for that substring in debug.log. Keep production as txrelay: park; the shim emits Core's needle. Co-authored-by: Cursor <cursoragent@cursor.com>
rearden-grok
Bot
added
the
core-functional
The park→was-not-accepted rule is a harness contract. Run the existing map_debuglog_test.sh from nightly.sh so labeled PRs and cron hit it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core-functionalon master (run 34471796784) failedfeature_bip68_sequence.py(block sync timeout) andp2p_ibd_txrelay.py(ping timeout after an unsolicited missing-input tx). Both sit on the orphanage merge (P2P orphanage: park is not reject, fetch parents, 1p1c, compact extra #404).orphan_count()(inner mempoolRwLock) ontokio-rt-worker, which panics the P2P reader so ping/block-sync never complete. The park log now emitstxrelay: park {txid}with no lock; parent GETDATA is unchanged.p2p_ibd_txrelay.pylooks forwas not acceptedin debug.log. That needle is emitted by the shim (debuglog_map.toml), not by changing production reject/park language.Test plan
cargo test -p rbitcoin-net parked_orphan./scripts/core-functional/map_debuglog_test.shcore-functionalnightly set (this PR)Made with Cursor