ibd: drop leftover always-zero perf tokens (thru/bodies, last-pin adopt/publish) - #410
Merged
Conversation
added 2 commits
September 10, 2026 07:28
![rbitcoin-grok[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Parent-cache snapshot still returns four zero slots so the sizes line prints load thru= and bodies= (and perf thru=) even when stuffed. Extend the omit-token pin so those tokens fail until sample/format drop them.
…lish parent_cache_perf_snapshot always returned four zeros so the IBD sample could keep a five-tuple; production last-pin stored adopt/publish as 0. Delete those slots and tokens. Header-plan occupancy stays on conf_plans=/plans= from process_owned_size_snapshot. Slow-load INFO uses LastPinPhases::format_slow_pin. Live lookup/load/scripts/write timers are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish remaining suggested-order step 2 dead meters after #405.
Query::parent_cache_perf_snapshotstill returned(0, 0, 0, 0, header_plans)so IBDibd: perf/perf_dbgprintedthru=/load thru=/bodies=forever. Productionnote_last_pinalways stored last-pinadopt/publishas 0, but the slow-load INFO line still formatted them.This PR deletes those never-meaningful slots and tokens. Live named lookup / load / scripts / write timers stay. Header-plan occupancy is
conf_plans=/plans=fromprocess_owned_size_snapshot.Inventory IDs: X-01 step 1 leftovers, Q-01 remaining tuple, Q-02 last-pin adopt/publish, Q-03 snapshot scaffolding. S-02
HeadLookupStatsalready gone in #405. Not this PR: liveSH_COLLECT_PIN,ASM_PREV_*,SPEND_ANN_PREAD_SKIP, reconstructBODY_STORE; X-01 steps 2–3 ConfirmStats.Test plan
format_lines_omit_never_written_inventory_tokensred onthru=/load thru=/bodies=, then greensampler_statspinsLastPinPhases::format_slow_pinomittingadopt=/publish=(including stuffed ns)cargo test -p rbitcoin-net --lib ibd::perf_log::testscargo test -p rbitcoin-consensus --lib pin_stamp_outs/ pin_for_wirecargo test -p rbitcoin-query --lib connect_chain_query_surfaceDo not merge unless asked.