test: shared Tiny-regtest hub opener for net tests (N-04) - #412
Merged
Conversation
added 2 commits
September 10, 2026 09:11
![rbitcoin-grok[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
N-04: net tests still copy Tiny query + ChainHub::new + regtest params. One helper next to ChainHub opens Tiny heads on a unique path that is gone after drop, with hub params ChainParams::regtest().
peer_tests (69 hubs) and named tmp_hub in chain/reorg/assign call the shared opener. Query-only peer tests keep tiny_query_labeled. Fuzz diff_regtest_params, dersig/cltv overlays, and production stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
N-04: one Tiny-regtest
ChainHubopener in net so tests do not copy Tiny query +ChainHub::new+ regtest params.tiny_regtest_hub/tiny_regtest_hub_labelednext toChainHub— compose existingtiny_query_labeled+ shippedChainHub::new(..., ChainParams::regtest(), Milestone::NONE). Unique path, Tiny heads (64 slots), drop-cleans. Production default stays Mainnet.peer_tests.rs(69 hubs) and namedtmp_hubinchain.rs/ibd/reorg.rs/ibd/assign.rscall it.tiny_query_labeled. Fuzzdiff_regtest_params, dersig/cltv overlays, productionP2PNode, and I-14 confirm-reject farm are unchanged.Test plan
shared_tiny_regtest_hub_is_tiny_unique_regtest_and_drop_cleans(red then green)cargo test -p rbitcoin-net --libfilters: pin test,p2p_serve_line_names_ntx_bytes_wall,hold_body_caps_at_320_fifo,classify_corrupt_vs_competing,download_gate_stops_getdata_when_tip_plus_one_unconfirmableTESTING.mdnames the hub openerDo not merge unless asked. Coverage ≥90% is the required
coveragejob.