test: remaining suggested-order 4 fixtures (I-14 A-21 C-14 Q-17 SH-15 N-03) - #414
Merged
Conversation
added 3 commits
September 10, 2026 09:52
![rbitcoin-grok[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
confirm_reject, parent_height, path, progress, archive, dial, and confirm engine tests opened Tiny query + ChainHub::new+regtest by hand. They now call tiny_regtest_hub_labeled (or tiny_query_labeled when only Query is needed). Reject class pins stay.
…SH-15) RPC methods/server, query catchup, and consensus structure-rule tests open Tiny via TempDir/tiny_query. BIP34 encoding asserts live in bip34_tests; structure-rule keeps the wrong-encoding reject pin. scripthash_tests tmp() is store TempDir. connect_chain_query_surface stays (only height_of_hash/merkle_proof journey).
Production handle_peer_frame already takes packed follow state. Tests construct PeerFollowState and call that function. The cfg(test) unpacking shim is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish suggested-order step 4 fixture consolidations on top of X-06 / N-04.
confirm_reject_tests, parent_height, path, progress, archive, dial, confirm engine) calltiny_regtest_hub_labeled. Query-only merkle pin usestiny_query_labeled. Blacklist vs cascade vs BadPrev pins stay.methods_tests/serverleftovertemp_dirinlines useTempDir.tiny_query; BIP34 encoding twins live inbip34_tests; structure-rule keeps the wrong-encoding reject pin.catchupinlines usetiny_query_labeled.connect_chain_query_surfacestays (onlyheight_of_hash/tx_output_at_fk/merkle_proofjourney).scripthash_teststmp()is storeTempDir. Bulk/extent/unsorted edge-packing pins kept.PeerFollowStateand call shippedhandle_peer_frame. The 11-arg unpacking shim is deleted.Production default stays Mainnet. Fixture size stays Tiny.
Test plan
confirm_reject_class_matches_substring_table/bad_prev_gathers_winner_via_bq_by_hashbloom_disabled_messages_request_disconnectbip34_wrong_push_encoding_rejected_after_activation/small_heights_use_op_nquery_index_products_follow_mode_and_flagsblockchain_empty_store/rpc_smoke_getblockcount_and_helpsh_body_create_grows_64k_not_slabDo not merge unless asked. Coverage ≥90% is the required
coveragejob.