Relax base64 dependency to allow 0.3.x - #965
Open
romanoff wants to merge 1 commit into
Open
Conversation
The exact ~> 0.2.0 pin prevents this gem from being installed alongside gems that require base64 ~> 0.3.0. The client's only usage is a single Base64.encode64 call for Basic auth, which is unchanged in 0.3.x. Full test suite passes against base64 0.3.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
romanoff
force-pushed
the
relax-base64-constraint
branch
from
August 5, 2026 20:55
d073550 to
7d8dded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relaxes the
base64runtime dependency from~> 0.2.0to>= 0.2, < 0.4.Motivation
The exact
~> 0.2.0pin (added in #920 to accommodate the gem's removal from the Ruby 3.4 stdlib) makes this client uninstallable alongside gems that requirebase64 ~> 0.3.0— for exampletravel_time >= 0.8.0. Bundler cannot resolve a bundle containing both:Safety
Base64.encode64call for the Basic auth header inlib/recurly/client.rb, whose behavior is unchanged in base64 0.3.x.>= 0.2, < 0.4) for the same reason.